From: Emil Velikov <emil.l.velikov@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/omap: remove unused function
Date: Thu, 29 Mar 2018 14:24:40 +0100 [thread overview]
Message-ID: <CACvgo51zyd3wBguae0edcLz7z5mk9Ws=5uoDJ==TmcW3ZXjp2w@mail.gmail.com> (raw)
In-Reply-To: <20180329123159.o7bmwmtvwixmdiuc@earth.universe>
On 29 March 2018 at 13:31, Sebastian Reichel
<sebastian.reichel@collabora.co.uk> wrote:
> Hi,
>
> On Thu, Mar 29, 2018 at 12:00:18PM +0100, Emil Velikov wrote:
>> On 29 March 2018 at 11:40, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> > omap_framebuffer_get_next_connector() is not used, remove it.
>> >
>> Seems to have been unused for a few years now.
>> Namely since commit 5a35876e2830511cb8110667fc426c6a6165a593
>>
>> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
>
> I have a pending patch using that function to basically restore the
> functionality from the referenced commit:
>
> https://patchwork.kernel.org/patch/10207759/
>
Hmm I can see very few users of dirtyfb - modesetting, opentegra,
vmgfx, intel (sna only) + the odd IGT test.
Wondering if that's because it doesn't provide that much of a benefit...
Although it might be because DRM drivers don't fully implement the
functionality ;-)
Just thinking out loud ^^.
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-29 13:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 10:40 [PATCH 1/3] drm/omap: fix uninitialized ret variable Tomi Valkeinen
2018-03-29 10:40 ` [PATCH 2/3] drm/omap: fix possible NULL ref issue in tiler_reserve_2d Tomi Valkeinen
2018-03-29 11:02 ` Emil Velikov
2018-04-03 11:03 ` Laurent Pinchart
2018-03-29 10:40 ` [PATCH 3/3] drm/omap: remove unused function Tomi Valkeinen
2018-03-29 11:00 ` Emil Velikov
2018-03-29 12:31 ` Sebastian Reichel
2018-03-29 12:49 ` Tomi Valkeinen
2018-03-29 14:44 ` Sebastian Reichel
2018-03-30 6:24 ` Tomi Valkeinen
2018-03-29 13:24 ` Emil Velikov [this message]
2018-03-29 14:23 ` Sebastian Reichel
2018-03-29 10:58 ` [PATCH 1/3] drm/omap: fix uninitialized ret variable Emil Velikov
2018-03-29 12:11 ` Tomi Valkeinen
2018-04-03 11:01 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvgo51zyd3wBguae0edcLz7z5mk9Ws=5uoDJ==TmcW3ZXjp2w@mail.gmail.com' \
--to=emil.l.velikov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=sebastian.reichel@collabora.co.uk \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.