From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Subject: Re: [PATCH 01/26] drm/irq: Don't check for DRIVER_HAVE_IRQ in drm_irq_(un)install Date: Fri, 25 Jan 2019 15:09:00 +0000 Message-ID: References: <20190124165831.16427-1-daniel.vetter@ffwll.ch> <20190124165831.16427-2-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190124165831.16427-2-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: linux-arm-msm , Intel Graphics Development , amd-gfx mailing list , "open list:VIRTIO GPU DRIVER" , linux-renesas-soc@vger.kernel.org, DRI Development , spice-devel@lists.freedesktop.org, Daniel Vetter , linux-amlogic@lists.infradead.org, freedreno@lists.freedesktop.org, LAKML List-Id: linux-arm-msm@vger.kernel.org T24gVGh1LCAyNCBKYW4gMjAxOSBhdCAxNjo1OCwgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRl ckBmZndsbC5jaD4gd3JvdGU6Cj4KPiBJZiBhIG5vbi1sZWdhY3kgZHJpdmVyIGNhbGxzIHRoZXNl IGl0J3MgdmFsaWQgdG8gYXNzdW1lIHRoZXJlIGlzCj4gaW50ZXJydXB0IHN1cHBvcnQuIFRoZSBm bGFnIGlzIHJlYWxseSBvbmx5IG5lZWRlZCBmb3IgbGVnYWN5IGRyaXZlcnMuCgouLi4gbGVnYWN5 IGRyaXZlcnMgd2hpY2ggaXNzdWUgdGhlIElSUSB2aWEgdGhlIERSTV9JT0NUTF9DT05UUk9MIGxl Z2FjeSBJT0NUTC4KCkF0IGEgbGF0ZXIgc3RhZ2UsIHdlIG1pZ2h0IGFzIHdlbGwgYWRkIExFR0FD WSB0byB0aGUgbmFtZToKRFJJVkVSX0xFR0FDWV9IQVZFX0lSUT8KCgo+ICBkcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGdwdS9hbWRncHVfZHJ2LmMgICAgICB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJt L2FybS9oZGxjZF9kcnYuYyAgICAgICAgICAgICAgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9h dG1lbC1obGNkYy9hdG1lbF9obGNkY19kYy5jIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJt X2lycS5jICAgICAgICAgICAgICAgICAgICB8IDYgLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9m c2wtZGN1L2ZzbF9kY3VfZHJtX2Rydi5jICAgIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vZ21h NTAwL3BzYl9kcnYuYyAgICAgICAgICAgICB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuYyAgICAgICAgICAgICAgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9tZXNvbi9t ZXNvbl9kcnYuYyAgICAgICAgICAgIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9k cnYuYyAgICAgICAgICAgICAgICB8IDMgKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9teHNmYi9teHNm Yl9kcnYuYyAgICAgICAgICAgIHwgMyArLS0KPiAgZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfZHJ2 LmMgICAgICAgICAgICAgICAgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9u X2Rydi5jICAgICAgICAgIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvc2htb2Jf ZHJtX2Rydi5jICAgICB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL3RpbGNkYy90aWxjZGNfZHJ2 LmMgICAgICAgICAgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2Rydi5jICAgICAg ICAgICAgICAgIHwgMSAtCj4gIGRyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2Rydi5jICAg ICAgICAgIHwgMiArLQo+ICBkcml2ZXJzL3N0YWdpbmcvdmJveHZpZGVvL3Zib3hfZHJ2LmMgICAg ICAgICB8IDIgKy0KCkxvY2FsIGdyZXAgc2hvd3Mgb25lIG1vcmUgbm9uLWxlZ2FjeSBlbnRyeSBp bgpkcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hpYm1jX2RybV9kcnYuYwoKV2l0aCB0 aGF0IGZpbGUgYWRkcmVzc2VkIGFuZCB0cml2aWFsIGNvbW1lbnQgYWRkaXRpb25zLCBwYXRjaGVz OiAxLCAyLAozIGFuZCAyNiBhcmUKUmV2aWV3ZWQtYnk6IEVtaWwgVmVsaWtvdiA8ZW1pbC52ZWxp a292QGNvbGxhYm9yYS5jb20+CgpIVEgKRW1pbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D96DC282C0 for ; Fri, 25 Jan 2019 15:12:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BFEE218D0 for ; Fri, 25 Jan 2019 15:12:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gn2eoqLK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726269AbfAYPMx (ORCPT ); Fri, 25 Jan 2019 10:12:53 -0500 Received: from mail-vs1-f66.google.com ([209.85.217.66]:36271 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbfAYPMx (ORCPT ); Fri, 25 Jan 2019 10:12:53 -0500 Received: by mail-vs1-f66.google.com with SMTP id v205so5857292vsc.3; Fri, 25 Jan 2019 07:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qeeS4c88knSK89mk8R7AcXjNNhDwhbuq8XG6IWuEQUk=; b=gn2eoqLKbhkShzqIB3CeXdajIYFk17aTIdPZdkEeNNHuHTnorLv57GuUFcRyyRLpl/ fJTwVJdNyXDk+somaX/sl7vN/EjYYZyrihbBBbSo6ZiyE0IJn8P5MMxI5pY8h9SE2VhM zKpG9/qf+nFTvbqr2By762JF/pDZeq+rDqW7Ry/cVEvV6AHDdcgG15vSM9tNsNxadfNE Pl8ISJlu5u+cVEEEz2hm74/KSsh8DO8wWOqYFB84KMOig9r6VNCDcmiLj1A8knbulC5I 65lFE2rgoq48vrzmIoXYJaRX07PTCm+QQTPJWK2rEm9xPzL7EpaLVRysFVPbDu+doaoq 0KLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qeeS4c88knSK89mk8R7AcXjNNhDwhbuq8XG6IWuEQUk=; b=aR4nwJQjnCI4YPWon8kaY3Y4uHdAOLj8PS3mJtIcAgb17qp4HhGHOJ9okAVPjEw1YN P1fGRMldV0SELflO8w5BwE8ZlULD/eviMwF851WXJkv6geNnoX1Xg2NWytBGAdxKhkeg IwjDzfkr6nxn4cnlIJX9QaXXFoJhrEnmNtXANzE3b4FbdTq4nUBFO4XdA35/19V6PMNI BUYJ0jPXjnOk/uAPkV6Pm/ULXAGQSY80TPGtFx9M62oHLkMxEbY9Jgp/L9RwKmxukWjY tMSR2S1lx0g+HTwMNBbOadSbZsg3Ak+BuyHDM5ZHTVRL8f40P1HDxvEhJPs/XQ7gbcFt s/hg== X-Gm-Message-State: AJcUukcwRzgoc04DmuxSbuC34MBm+3P33pSznwqSkhj6Ifc7eQtGgYs5 UWGHrQZUIpA3DUPQ61AjbQu5SfhK9GcsmJFvVLcyoA== X-Google-Smtp-Source: ALg8bN4TdPePO5U3SZKFlVwm6CHk+iHb487nVCQWm00orfsqe8O/kc6JsiOLu8DUZqBq5yIaJW7RSm7lKVV6TgnDTu0= X-Received: by 2002:a67:cf02:: with SMTP id y2mr4613740vsl.118.1548429171526; Fri, 25 Jan 2019 07:12:51 -0800 (PST) MIME-Version: 1.0 References: <20190124165831.16427-1-daniel.vetter@ffwll.ch> <20190124165831.16427-2-daniel.vetter@ffwll.ch> In-Reply-To: <20190124165831.16427-2-daniel.vetter@ffwll.ch> From: Emil Velikov Date: Fri, 25 Jan 2019 15:09:00 +0000 Message-ID: Subject: Re: [PATCH 01/26] drm/irq: Don't check for DRIVER_HAVE_IRQ in drm_irq_(un)install To: Daniel Vetter Cc: DRI Development , Daniel Vetter , linux-arm-msm , Intel Graphics Development , amd-gfx mailing list , "open list:VIRTIO GPU DRIVER" , linux-renesas-soc@vger.kernel.org, spice-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, freedreno@lists.freedesktop.org, LAKML Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, 24 Jan 2019 at 16:58, Daniel Vetter wrote: > > If a non-legacy driver calls these it's valid to assume there is > interrupt support. The flag is really only needed for legacy drivers. ... legacy drivers which issue the IRQ via the DRM_IOCTL_CONTROL legacy IOCTL. At a later stage, we might as well add LEGACY to the name: DRIVER_LEGACY_HAVE_IRQ? > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- > drivers/gpu/drm/arm/hdlcd_drv.c | 2 +- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- > drivers/gpu/drm/drm_irq.c | 6 ------ > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +- > drivers/gpu/drm/gma500/psb_drv.c | 2 +- > drivers/gpu/drm/i915/i915_drv.c | 2 +- > drivers/gpu/drm/meson/meson_drv.c | 2 +- > drivers/gpu/drm/msm/msm_drv.c | 3 +-- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +-- > drivers/gpu/drm/qxl/qxl_drv.c | 2 +- > drivers/gpu/drm/radeon/radeon_drv.c | 2 +- > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 2 +- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- > drivers/gpu/drm/vc4/vc4_drv.c | 1 - > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +- > drivers/staging/vboxvideo/vbox_drv.c | 2 +- Local grep shows one more non-legacy entry in drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c With that file addressed and trivial comment additions, patches: 1, 2, 3 and 26 are Reviewed-by: Emil Velikov HTH Emil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 973D9C282C0 for ; Fri, 25 Jan 2019 15:13:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67E66218D0 for ; Fri, 25 Jan 2019 15:13:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JsmUbTWG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gn2eoqLK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67E66218D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xvbAMFVsfFsDJBnHg5s24kAxIhFpHQn62m86TKDivj4=; b=JsmUbTWGodiIVc gtAOZR9TjcQxX3AbkVkZ3IepkDJUcYgBX3VePZF6DHcSC2ilfqgJ910ejKPuY4UytJBn1wLI1bR8+ l5Gk/UrMnSUpC+84POXO0mnV4+NFNTSRBvcRU7Rqknhlf3ACk6h4ti8dHwd2C1U1UtthoNXPEUSw8 9kjlCK8mvr2WmhApnegpRFvU+vuTVaoEtk7PCGpK0gcZDxTyikGlXt6VFywCHML1OpsTaIX1q4wjV HJmcZ9PQFAHSftgRyKRjQLTPpaoKlseVwntcIONcz3QjKwd4IM3qx6qXsG78JJCQMrVxOlFCfCRPF SOCtv/4gj4CjNNyT7eZg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gn3AA-0006Lw-1z; Fri, 25 Jan 2019 15:12:58 +0000 Received: from mail-vs1-xe42.google.com ([2607:f8b0:4864:20::e42]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gn3A6-0006L4-Du; Fri, 25 Jan 2019 15:12:55 +0000 Received: by mail-vs1-xe42.google.com with SMTP id z3so5847259vsf.7; Fri, 25 Jan 2019 07:12:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qeeS4c88knSK89mk8R7AcXjNNhDwhbuq8XG6IWuEQUk=; b=gn2eoqLKbhkShzqIB3CeXdajIYFk17aTIdPZdkEeNNHuHTnorLv57GuUFcRyyRLpl/ fJTwVJdNyXDk+somaX/sl7vN/EjYYZyrihbBBbSo6ZiyE0IJn8P5MMxI5pY8h9SE2VhM zKpG9/qf+nFTvbqr2By762JF/pDZeq+rDqW7Ry/cVEvV6AHDdcgG15vSM9tNsNxadfNE Pl8ISJlu5u+cVEEEz2hm74/KSsh8DO8wWOqYFB84KMOig9r6VNCDcmiLj1A8knbulC5I 65lFE2rgoq48vrzmIoXYJaRX07PTCm+QQTPJWK2rEm9xPzL7EpaLVRysFVPbDu+doaoq 0KLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qeeS4c88knSK89mk8R7AcXjNNhDwhbuq8XG6IWuEQUk=; b=nFjdaOeiH2BYfQAxrkqIsZUkL3IsZ1oRvyp52/UQwzIBloZr98pS+SHHLpCHgtrMrZ oQBmBEaAECqoJsyIa7uSlC5O4lZzkydSMZqpjQ2pN+oNKoDjZf3FsTH8lxkRtLLMeMb0 Wg4ji0WKakvTeLUdTTnKey0hUXX/S83x3R4EevbHfLPdrsQ5nsTIuzcT972q7WMG7OD9 ynLg/o3KOSfrr88JMya7EyKvgXT+6nYkocjXITuMABrORGZpPSfdsKlzuoSfTYqvec++ O0M+lO46jkFJ1MLImWnOsqvvajzA+vdHsJgvQT51oHuTvXvbBPlJRE2uj2cUHzqFaNlR zj7A== X-Gm-Message-State: AJcUukeJJmfV2FTt5RaN1Rq1aqR+BVs+IYkqfcn18tC6mb+jzoH9Lkju SyrpImijrQ+N3irkLZKbfdeb5pO4L0AYctQy4RI= X-Google-Smtp-Source: ALg8bN4TdPePO5U3SZKFlVwm6CHk+iHb487nVCQWm00orfsqe8O/kc6JsiOLu8DUZqBq5yIaJW7RSm7lKVV6TgnDTu0= X-Received: by 2002:a67:cf02:: with SMTP id y2mr4613740vsl.118.1548429171526; Fri, 25 Jan 2019 07:12:51 -0800 (PST) MIME-Version: 1.0 References: <20190124165831.16427-1-daniel.vetter@ffwll.ch> <20190124165831.16427-2-daniel.vetter@ffwll.ch> In-Reply-To: <20190124165831.16427-2-daniel.vetter@ffwll.ch> From: Emil Velikov Date: Fri, 25 Jan 2019 15:09:00 +0000 Message-ID: Subject: Re: [PATCH 01/26] drm/irq: Don't check for DRIVER_HAVE_IRQ in drm_irq_(un)install To: Daniel Vetter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190125_071254_495891_A33100BE X-CRM114-Status: UNSURE ( 7.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm , Intel Graphics Development , amd-gfx mailing list , "open list:VIRTIO GPU DRIVER" , linux-renesas-soc@vger.kernel.org, DRI Development , spice-devel@lists.freedesktop.org, Daniel Vetter , linux-amlogic@lists.infradead.org, freedreno@lists.freedesktop.org, LAKML Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 24 Jan 2019 at 16:58, Daniel Vetter wrote: > > If a non-legacy driver calls these it's valid to assume there is > interrupt support. The flag is really only needed for legacy drivers. ... legacy drivers which issue the IRQ via the DRM_IOCTL_CONTROL legacy IOCTL. At a later stage, we might as well add LEGACY to the name: DRIVER_LEGACY_HAVE_IRQ? > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- > drivers/gpu/drm/arm/hdlcd_drv.c | 2 +- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- > drivers/gpu/drm/drm_irq.c | 6 ------ > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +- > drivers/gpu/drm/gma500/psb_drv.c | 2 +- > drivers/gpu/drm/i915/i915_drv.c | 2 +- > drivers/gpu/drm/meson/meson_drv.c | 2 +- > drivers/gpu/drm/msm/msm_drv.c | 3 +-- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +-- > drivers/gpu/drm/qxl/qxl_drv.c | 2 +- > drivers/gpu/drm/radeon/radeon_drv.c | 2 +- > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 2 +- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- > drivers/gpu/drm/vc4/vc4_drv.c | 1 - > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +- > drivers/staging/vboxvideo/vbox_drv.c | 2 +- Local grep shows one more non-legacy entry in drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c With that file addressed and trivial comment additions, patches: 1, 2, 3 and 26 are Reviewed-by: Emil Velikov HTH Emil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76871C282C0 for ; Fri, 25 Jan 2019 15:13:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 455A0218D0 for ; Fri, 25 Jan 2019 15:13:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SszRNREI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gn2eoqLK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 455A0218D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MbT9QUm1FjmjprEoztkw9Jb8VGE694I7Sw3gfRwaseI=; b=SszRNREISNpO0U qVRtgj7AonabBKyU/6YkSZoh4/GM7w8l34dHXsDu5Jg9Dp8XfUT9BIKgbZ14dwJu85YDhnUIKritY 7+URImHMlLId2YGvVx13BmHCh0IE/sDMUo2H93v81hjgZDu4ErQqo6TKxO+1CjlzadiYgQz1zMQEV 9HeJmaKHNQ6tQC9UKu9bxViAZ3OWO4FIgOOA+7hU8AzBkIw+2zubTxwFIukDWsGkoJZvDPEKy/ak+ S2MC0CvY3FL2jXWAjF64HdbRkJ2BgThGQZET1pjIUjLjPXBHSeqndqcm+qVY+a4Do5bjbvl97RlW8 zyOoKnIb5I2pooWdwdGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gn3A8-0006LU-Nf; Fri, 25 Jan 2019 15:12:56 +0000 Received: from mail-vs1-xe42.google.com ([2607:f8b0:4864:20::e42]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gn3A6-0006L4-Du; Fri, 25 Jan 2019 15:12:55 +0000 Received: by mail-vs1-xe42.google.com with SMTP id z3so5847259vsf.7; Fri, 25 Jan 2019 07:12:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qeeS4c88knSK89mk8R7AcXjNNhDwhbuq8XG6IWuEQUk=; b=gn2eoqLKbhkShzqIB3CeXdajIYFk17aTIdPZdkEeNNHuHTnorLv57GuUFcRyyRLpl/ fJTwVJdNyXDk+somaX/sl7vN/EjYYZyrihbBBbSo6ZiyE0IJn8P5MMxI5pY8h9SE2VhM zKpG9/qf+nFTvbqr2By762JF/pDZeq+rDqW7Ry/cVEvV6AHDdcgG15vSM9tNsNxadfNE Pl8ISJlu5u+cVEEEz2hm74/KSsh8DO8wWOqYFB84KMOig9r6VNCDcmiLj1A8knbulC5I 65lFE2rgoq48vrzmIoXYJaRX07PTCm+QQTPJWK2rEm9xPzL7EpaLVRysFVPbDu+doaoq 0KLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qeeS4c88knSK89mk8R7AcXjNNhDwhbuq8XG6IWuEQUk=; b=nFjdaOeiH2BYfQAxrkqIsZUkL3IsZ1oRvyp52/UQwzIBloZr98pS+SHHLpCHgtrMrZ oQBmBEaAECqoJsyIa7uSlC5O4lZzkydSMZqpjQ2pN+oNKoDjZf3FsTH8lxkRtLLMeMb0 Wg4ji0WKakvTeLUdTTnKey0hUXX/S83x3R4EevbHfLPdrsQ5nsTIuzcT972q7WMG7OD9 ynLg/o3KOSfrr88JMya7EyKvgXT+6nYkocjXITuMABrORGZpPSfdsKlzuoSfTYqvec++ O0M+lO46jkFJ1MLImWnOsqvvajzA+vdHsJgvQT51oHuTvXvbBPlJRE2uj2cUHzqFaNlR zj7A== X-Gm-Message-State: AJcUukeJJmfV2FTt5RaN1Rq1aqR+BVs+IYkqfcn18tC6mb+jzoH9Lkju SyrpImijrQ+N3irkLZKbfdeb5pO4L0AYctQy4RI= X-Google-Smtp-Source: ALg8bN4TdPePO5U3SZKFlVwm6CHk+iHb487nVCQWm00orfsqe8O/kc6JsiOLu8DUZqBq5yIaJW7RSm7lKVV6TgnDTu0= X-Received: by 2002:a67:cf02:: with SMTP id y2mr4613740vsl.118.1548429171526; Fri, 25 Jan 2019 07:12:51 -0800 (PST) MIME-Version: 1.0 References: <20190124165831.16427-1-daniel.vetter@ffwll.ch> <20190124165831.16427-2-daniel.vetter@ffwll.ch> In-Reply-To: <20190124165831.16427-2-daniel.vetter@ffwll.ch> From: Emil Velikov Date: Fri, 25 Jan 2019 15:09:00 +0000 Message-ID: Subject: Re: [PATCH 01/26] drm/irq: Don't check for DRIVER_HAVE_IRQ in drm_irq_(un)install To: Daniel Vetter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190125_071254_495891_A33100BE X-CRM114-Status: UNSURE ( 7.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm , Intel Graphics Development , amd-gfx mailing list , "open list:VIRTIO GPU DRIVER" , linux-renesas-soc@vger.kernel.org, DRI Development , spice-devel@lists.freedesktop.org, Daniel Vetter , linux-amlogic@lists.infradead.org, freedreno@lists.freedesktop.org, LAKML Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Thu, 24 Jan 2019 at 16:58, Daniel Vetter wrote: > > If a non-legacy driver calls these it's valid to assume there is > interrupt support. The flag is really only needed for legacy drivers. ... legacy drivers which issue the IRQ via the DRM_IOCTL_CONTROL legacy IOCTL. At a later stage, we might as well add LEGACY to the name: DRIVER_LEGACY_HAVE_IRQ? > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- > drivers/gpu/drm/arm/hdlcd_drv.c | 2 +- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- > drivers/gpu/drm/drm_irq.c | 6 ------ > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +- > drivers/gpu/drm/gma500/psb_drv.c | 2 +- > drivers/gpu/drm/i915/i915_drv.c | 2 +- > drivers/gpu/drm/meson/meson_drv.c | 2 +- > drivers/gpu/drm/msm/msm_drv.c | 3 +-- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +-- > drivers/gpu/drm/qxl/qxl_drv.c | 2 +- > drivers/gpu/drm/radeon/radeon_drv.c | 2 +- > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 2 +- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- > drivers/gpu/drm/vc4/vc4_drv.c | 1 - > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +- > drivers/staging/vboxvideo/vbox_drv.c | 2 +- Local grep shows one more non-legacy entry in drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c With that file addressed and trivial comment additions, patches: 1, 2, 3 and 26 are Reviewed-by: Emil Velikov HTH Emil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic