All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: "David Airlie" <airlied@linux.ie>,
	"ML dri-devel" <dri-devel@lists.freedesktop.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Emil Velikov" <emil.velikov@collabora.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Dan Carpenter" <dan.carpenter@oracle.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 02/12] drm/pci: Hide legacy PCI functions from non-legacy code
Date: Tue, 3 Dec 2019 11:09:28 +0000	[thread overview]
Message-ID: <CACvgo52UvEBSYTg3nTjrHvTg2kZ_Rd9LLLtNwrLbvcJ3k9yFGA@mail.gmail.com> (raw)
In-Reply-To: <CACvgo50oHVLgjcv=ipQq=ZuWv2=mu20VHkVRx3x6+zhp5H9YYQ@mail.gmail.com>

On Tue, 3 Dec 2019 at 11:06, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>
> Hi Thomas,
>
> On Tue, 3 Dec 2019 at 10:04, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> >
> > Declarations of drm_legacy_pci_{init,exit}() are being moved to
> > drm_legacy.h. CONFIG_DRM_LEGACY protects the implementation.
> >
> > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> > ---
> >  drivers/gpu/drm/drm_pci.c |  4 ++++
> >  include/drm/drm_legacy.h  | 29 ++++++++++++++++++++++++++++-
> >  include/drm/drm_pci.h     | 15 ---------------
> >  3 files changed, 32 insertions(+), 16 deletions(-)
> >
> How about we make this patch 01/12, this way we can avoid the current
> case of - add code only to be moved in next patch.
>
> As always - couple of ideas for follow-up cleanups.
>  - drm_irq_by_busid() is legacy codebase (see the DRIVER_LEGACY check
> at the top). How about we give it a _legacy_ name?
>  - WE HAVE A FEW driver_features

Pardon there, the last one should read:
- We have a few instances that read driver_features directly, instead
of using the drm_core_check_feature() helper.
Might be a good idea to address those.

Just some nitpicks noticed while skimming through. It's not a
requirement by any means.

HTH
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-12-03 11:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03 10:03 [PATCH 00/12] Clean up drm_pci.{c,h} Thomas Zimmermann
2019-12-03 10:03 ` [PATCH 01/12] drm/pci: Only build drm_pci.c if CONFIG_PCI is set Thomas Zimmermann
2019-12-03 10:03 ` [PATCH 02/12] drm/pci: Hide legacy PCI functions from non-legacy code Thomas Zimmermann
2019-12-03 11:06   ` Emil Velikov
2019-12-03 11:09     ` Emil Velikov [this message]
2019-12-03 11:27       ` Thomas Zimmermann
2019-12-03 10:03 ` [PATCH 03/12] drm/ast: Don't include <drm/drm_pci.h> Thomas Zimmermann
2019-12-03 15:23   ` kbuild test robot
2019-12-03 15:23     ` kbuild test robot
2019-12-03 10:03 ` [PATCH 04/12] drm/i810: " Thomas Zimmermann
2019-12-03 10:03 ` [PATCH 05/12] drm/mga: " Thomas Zimmermann
2019-12-03 10:04 ` [PATCH 06/12] drm/mgag200: " Thomas Zimmermann
2019-12-03 10:04 ` [PATCH 07/12] drm/r128: " Thomas Zimmermann
2019-12-03 10:04 ` [PATCH 08/12] drm/radeon: " Thomas Zimmermann
2019-12-03 10:04 ` [PATCH 09/12] drm/savage: " Thomas Zimmermann
2019-12-03 10:04 ` [PATCH 10/12] drm/sis: " Thomas Zimmermann
2019-12-03 10:04 ` [PATCH 11/12] drm/tdfx: " Thomas Zimmermann
2019-12-03 10:04 ` [PATCH 12/12] drm/via: " Thomas Zimmermann
2019-12-03 11:11 ` [PATCH 00/12] Clean up drm_pci.{c,h} Emil Velikov
2019-12-03 12:13 ` Sam Ravnborg
2019-12-03 12:54   ` Thomas Zimmermann
2019-12-03 14:35 ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACvgo52UvEBSYTg3nTjrHvTg2kZ_Rd9LLLtNwrLbvcJ3k9yFGA@mail.gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.velikov@collabora.com \
    --cc=kraxel@redhat.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.