From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D48C433E0 for ; Tue, 2 Jun 2020 12:22:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBE04206A2 for ; Tue, 2 Jun 2020 12:22:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iS1cNpg0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727782AbgFBMWA (ORCPT ); Tue, 2 Jun 2020 08:22:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726937AbgFBMV5 (ORCPT ); Tue, 2 Jun 2020 08:21:57 -0400 Received: from mail-vk1-xa43.google.com (mail-vk1-xa43.google.com [IPv6:2607:f8b0:4864:20::a43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22B77C061A0E for ; Tue, 2 Jun 2020 05:21:57 -0700 (PDT) Received: by mail-vk1-xa43.google.com with SMTP id f126so821114vkb.13 for ; Tue, 02 Jun 2020 05:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uhS6wUtL1nQqq687nk7bY+rt6oHfCz/bP20I3cjBhSw=; b=iS1cNpg05xcEK6kyHjMSJ22ATuO9KFDUcoDquBU2iOe8OtEp/aHvoOY+Hc1jbuHZ1j /Zf/spKV28Tbu++/etF4Zjj4sXvh8pAXYEwRxpTd1PNTIZGqQQJMnllTJIXyTvig+rl7 ONIP/BDM5lHyDtCrPjr1f21Oc9Ywr8DNAM0/z8teiTSPg84vkpYs7bwL7S0qIB8mmj3v mf9cWjDavFRqvO/HxzSGtzUfqAggg0QxBs0uvP1uv0pRsy+lSebm+Nv0HhZ2FR2wX0HW cXjB8Ebc8hym8wolXa/Elydr/XWJoBacagzzpPtMsoudz8jLUVGbIiOVugOlM5dRixRi NKWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uhS6wUtL1nQqq687nk7bY+rt6oHfCz/bP20I3cjBhSw=; b=E8MEKPAqWSiMahOR8GQkrMF79zA+ah8APGD3ViUpiXJ7KcLXBqZTQ9WAiPILQXiwXJ meQtdpnutX0DM39OGGuEIspjWeMc7MTu4J3ETRAD/4xkL/IiN6GROJjILiQqsmFNOdVL y20bkiVaKac1RgjYvRLTQn37sJZ4xt/XImoQSAAxI6wcPj2/3FQwyo+viLXFSThhFrT4 ksPw2oeV1RQOVS2s0Ihtw3FCH05yBTMKN93ctx+jWLLh7e8QvjQ3jLfugU7l/ugBglrc nHU39uBgbdIRW9sckI20jVpRDzhtEPublPAu0+1JNBmHIP4nKnveQh8CAoxFjIbJrDia pbuw== X-Gm-Message-State: AOAM532ieD9DxvmP3p+dGiJdtTeUlKefhAaeBSOO1JD22euVVsQkeG31 +OhzppmX3X+fzdejnHi8Hjl1T3XXBzc30KoXs+4Exw== X-Google-Smtp-Source: ABdhPJyFkrbYplf5gWUM2GeUq/gzW7pUpT6I7Z+yO1zl/pK104ACL5dbJongfx+Bv5rPOloANFKde8VOkcaaziUl7fU= X-Received: by 2002:a1f:2ac6:: with SMTP id q189mr8911630vkq.28.1591100516362; Tue, 02 Jun 2020 05:21:56 -0700 (PDT) MIME-Version: 1.0 References: <20200531131237.24781-1-realwakka@gmail.com> <20200601002520.hajvtpefi7yzvmuq@smtp.gmail.com> In-Reply-To: <20200601002520.hajvtpefi7yzvmuq@smtp.gmail.com> From: Emil Velikov Date: Tue, 2 Jun 2020 13:18:38 +0100 Message-ID: Subject: Re: [PATCH] drm/vkms: Optimize compute_crc(), blend() To: Rodrigo Siqueira Cc: Sidong Yang , Daniel Vetter , Haneen Mohammed , David Airlie , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Jun 2020 at 01:25, Rodrigo Siqueira wrote: > > Hi, > > First of all, thanks a lot for all your patch. And thanks Emil for your > feedback. > > I have a suggestion here: > > Emil: > Could you give me your Acked-by or maybe Reviewed-by for the writeback > series? With that, I can finally apply the series. > Sure, once the issues highlighted are resolved. Just left you some more comprehensive feedback. -Emil P.S. Something something top posting sucks :-P From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E76B2C433DF for ; Tue, 2 Jun 2020 12:21:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF131206A2 for ; Tue, 2 Jun 2020 12:21:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iS1cNpg0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF131206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E7C56E1D3; Tue, 2 Jun 2020 12:21:58 +0000 (UTC) Received: from mail-vk1-xa42.google.com (mail-vk1-xa42.google.com [IPv6:2607:f8b0:4864:20::a42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F6BD6E1D3 for ; Tue, 2 Jun 2020 12:21:57 +0000 (UTC) Received: by mail-vk1-xa42.google.com with SMTP id s192so840331vkh.3 for ; Tue, 02 Jun 2020 05:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uhS6wUtL1nQqq687nk7bY+rt6oHfCz/bP20I3cjBhSw=; b=iS1cNpg05xcEK6kyHjMSJ22ATuO9KFDUcoDquBU2iOe8OtEp/aHvoOY+Hc1jbuHZ1j /Zf/spKV28Tbu++/etF4Zjj4sXvh8pAXYEwRxpTd1PNTIZGqQQJMnllTJIXyTvig+rl7 ONIP/BDM5lHyDtCrPjr1f21Oc9Ywr8DNAM0/z8teiTSPg84vkpYs7bwL7S0qIB8mmj3v mf9cWjDavFRqvO/HxzSGtzUfqAggg0QxBs0uvP1uv0pRsy+lSebm+Nv0HhZ2FR2wX0HW cXjB8Ebc8hym8wolXa/Elydr/XWJoBacagzzpPtMsoudz8jLUVGbIiOVugOlM5dRixRi NKWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uhS6wUtL1nQqq687nk7bY+rt6oHfCz/bP20I3cjBhSw=; b=XZw5nARrBE+/wLoYJlEKFSgsxXoda+V2X/HOL6AedJSdXrKJmpxgvpBK91zcf31n4n PKlb4vYr5VYTS5P96jhXWRUvgpEpO/2tpFwjteyYseYfwEJSGh53mWlGYzXzSIxkCZdA kctKoE2U1HBFS6LUwYUYkglDmLB4aQ18KJyS8lEenh2DXYW/ba5zn1UZTOqPzkb/PP73 HH2xM6eFzPOjNE4rlqVEM0qXLqr0Hp4WksqIx8Y+nDfY6D2OAf5cnrtJvJ/IZ3uqp5Lm M0LJJDBODYr1jxOItdDkVHI9n/1EJ+ib7rEExuCiEqSh6H5EmpbheTATV2I50zKO4GwZ KitQ== X-Gm-Message-State: AOAM531CG6XsxpOvqglmZBS4x7/yWLs4TSJPmKwebfyNce0BI7dsO3QZ Y4WfvG//gz44oW6RnlwTEzx5K/pk9DPc4qOUqpg= X-Google-Smtp-Source: ABdhPJyFkrbYplf5gWUM2GeUq/gzW7pUpT6I7Z+yO1zl/pK104ACL5dbJongfx+Bv5rPOloANFKde8VOkcaaziUl7fU= X-Received: by 2002:a1f:2ac6:: with SMTP id q189mr8911630vkq.28.1591100516362; Tue, 02 Jun 2020 05:21:56 -0700 (PDT) MIME-Version: 1.0 References: <20200531131237.24781-1-realwakka@gmail.com> <20200601002520.hajvtpefi7yzvmuq@smtp.gmail.com> In-Reply-To: <20200601002520.hajvtpefi7yzvmuq@smtp.gmail.com> From: Emil Velikov Date: Tue, 2 Jun 2020 13:18:38 +0100 Message-ID: Subject: Re: [PATCH] drm/vkms: Optimize compute_crc(), blend() To: Rodrigo Siqueira X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , David Airlie , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , Sidong Yang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 1 Jun 2020 at 01:25, Rodrigo Siqueira wrote: > > Hi, > > First of all, thanks a lot for all your patch. And thanks Emil for your > feedback. > > I have a suggestion here: > > Emil: > Could you give me your Acked-by or maybe Reviewed-by for the writeback > series? With that, I can finally apply the series. > Sure, once the issues highlighted are resolved. Just left you some more comprehensive feedback. -Emil P.S. Something something top posting sucks :-P _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel