From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6CB7C47088 for ; Wed, 26 May 2021 16:21:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB347613CA for ; Wed, 26 May 2021 16:21:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB347613CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DDAF6EDBF; Wed, 26 May 2021 16:21:34 +0000 (UTC) Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D0D26EDBF; Wed, 26 May 2021 16:21:33 +0000 (UTC) Received: by mail-ua1-x934.google.com with SMTP id d14so1092420ual.5; Wed, 26 May 2021 09:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=TyjCiPAhnrbf2fMWsVTrk+vNWjZDmn66jkggQRHDV8c=; b=gNsx/PovsvIHJh6zP3RNNianCSGTUaAHeSnG+PhW5IPBoI55ICu+xSz20fgt94lT5y VsjFnMVaaN1ObOjcJt2Z6wOP0CKmwHl+a8xqzA3lX2kvEF7EqKy9xy7SV7LhNyBcMuVN z19i+t1ILqT8YPRIk6wJWcOWjNxuvHwsZOZsx+6Ys8RN2D7mL6tvXAsqYMDK9VN6dLZB 0UkDSkB7YNnmHluph8O8zHG6CYHbyYjNmaJdAoqoJFgagdMhz8LLLROl8CD/cHumePnV K7ScuFvZZ2eW8b0DCdQANzHstXq05H+NqpsEWGE/uMgTtDJMbtzh/O/PWfvw/GGtfdvV 62yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TyjCiPAhnrbf2fMWsVTrk+vNWjZDmn66jkggQRHDV8c=; b=GZKBXpXNHW57YNdDjrB7NvdUJz8tDcpWi8DVrneLOq8f0xHzzW6YvlXyWTJLd6F73t WgEdDxfiRpEy2PokMQPhy/skJK/z9P/sP94Li+ch5LDuc2QXt6TMjYa89PXF1fXOmQvD QUUDYLRURSI6crTvxNrk/G6bq4bPAkc/2NxEvEbhk9vh8hthSIGqeTqHXThRmaEMNI/V qVWfXGmMv79JWrcSmbryWzjmkmrxGb+UpOqko2xaFW4+uCCxAAmlU4mvbH78Kj6J4NPU kcPODUree+bbLHw/NHTgFZsh1gg2RwLwJza7Ree+V8RcBwCZU4Q30IGwcgRqn7LAV7sg 8/aw== X-Gm-Message-State: AOAM5327oHavNxj6lY/J58okacXX5UDNC3a4R6dKBOhXj51LKUUO7Tq+ qjXc9oG9GoLNMnwU/IHQbZFFLEtW/zP8cFSMNoA= X-Google-Smtp-Source: ABdhPJxkFIJHD5G+sHKDDZhetQ7golkfaXMDUXrac4w6e5h1b2229x+b1/izFo1mNEU6RW8ztIANhysBmulXZm1TYlA= X-Received: by 2002:a1f:b488:: with SMTP id d130mr31749720vkf.17.1622046092243; Wed, 26 May 2021 09:21:32 -0700 (PDT) MIME-Version: 1.0 References: <20210516171432.1734268-1-emil.l.velikov@gmail.com> In-Reply-To: From: Emil Velikov Date: Wed, 26 May 2021 17:21:20 +0100 Message-ID: Subject: Re: [PATCH] drm/i915: only disable default vga device To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , kernel@collabora.com, ML dri-devel , Rodrigo Vivi Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Ville, On Tue, 18 May 2021 at 12:17, Ville Syrj=C3=A4l=C3=A4 wrote: > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > Hi Ville, > > > > On Mon, 17 May 2021 at 18:24, Ville Syrj=C3=A4l=C3=A4 > > wrote: > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > From: Vivek Das Mohapatra > > > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > > bootloader =E2=86=92 plymouth =E2=86=92 desktop. > > > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > > (intel in this case), so the driver can issue some io(). > > > > > > I don't understand what this commit message is trying to say. > > > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > > the actual hardware setup where this occurs. > > Does the following make sense? > > > > Currently on dual GPU systems, we do not get seamless handover as the > > output flickers during the transition bootloader -> plymouth -> > > desktop. > > This happens as a result of switching (via the VGA arbiter) from the > > "other" GPU back to the default i915 one and issuing io() commands. > > Hmm. Does this work? > > --- a/drivers/gpu/drm/i915/display/intel_vga.c > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_pri= v) > i915_reg_t vga_reg =3D intel_vga_cntrl_reg(dev_priv); > u8 sr1; > > + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) > + return; > + > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > outb(SR01, VGA_SR_INDEX); > Was able to replicate the issue somewhat and the above does help quite a lo= t. Feel free to add my: Reviewed-by: Emil Velikov Tested-by: Emil Velikov Also feel free to reuse as much/little of the following setup details. To reproduce the issue: Get a dual GPU system - Intel+Nvidia in my case. Set the other (Nvidia) as default in UEFI and connect monitors to it. Ensure the bootloader (and if using splash manager like plymouth) are set to display the UEFI BGRT. Personally I tested systemd-boot, although GRUB should also work. I couldn't get plymouth to work/behave here :shrug: Note: Having the Nvidia drivers in the initramfs can lead to extra flicker so leave them out. Include the i915 drivers in initramfs. Without the patch, the existing bootslash is wiped clean almost instantaneously as the i915 driver calls intel_vga_disable(). With your patch the call is a no-op, and the bootsplash stays around until the login manager (and X) is spawned. HTH Emil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 849FFC47089 for ; Wed, 26 May 2021 16:21:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52F80613E6 for ; Wed, 26 May 2021 16:21:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52F80613E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9AFF06EDC2; Wed, 26 May 2021 16:21:35 +0000 (UTC) Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D0D26EDBF; Wed, 26 May 2021 16:21:33 +0000 (UTC) Received: by mail-ua1-x934.google.com with SMTP id d14so1092420ual.5; Wed, 26 May 2021 09:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=TyjCiPAhnrbf2fMWsVTrk+vNWjZDmn66jkggQRHDV8c=; b=gNsx/PovsvIHJh6zP3RNNianCSGTUaAHeSnG+PhW5IPBoI55ICu+xSz20fgt94lT5y VsjFnMVaaN1ObOjcJt2Z6wOP0CKmwHl+a8xqzA3lX2kvEF7EqKy9xy7SV7LhNyBcMuVN z19i+t1ILqT8YPRIk6wJWcOWjNxuvHwsZOZsx+6Ys8RN2D7mL6tvXAsqYMDK9VN6dLZB 0UkDSkB7YNnmHluph8O8zHG6CYHbyYjNmaJdAoqoJFgagdMhz8LLLROl8CD/cHumePnV K7ScuFvZZ2eW8b0DCdQANzHstXq05H+NqpsEWGE/uMgTtDJMbtzh/O/PWfvw/GGtfdvV 62yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TyjCiPAhnrbf2fMWsVTrk+vNWjZDmn66jkggQRHDV8c=; b=GZKBXpXNHW57YNdDjrB7NvdUJz8tDcpWi8DVrneLOq8f0xHzzW6YvlXyWTJLd6F73t WgEdDxfiRpEy2PokMQPhy/skJK/z9P/sP94Li+ch5LDuc2QXt6TMjYa89PXF1fXOmQvD QUUDYLRURSI6crTvxNrk/G6bq4bPAkc/2NxEvEbhk9vh8hthSIGqeTqHXThRmaEMNI/V qVWfXGmMv79JWrcSmbryWzjmkmrxGb+UpOqko2xaFW4+uCCxAAmlU4mvbH78Kj6J4NPU kcPODUree+bbLHw/NHTgFZsh1gg2RwLwJza7Ree+V8RcBwCZU4Q30IGwcgRqn7LAV7sg 8/aw== X-Gm-Message-State: AOAM5327oHavNxj6lY/J58okacXX5UDNC3a4R6dKBOhXj51LKUUO7Tq+ qjXc9oG9GoLNMnwU/IHQbZFFLEtW/zP8cFSMNoA= X-Google-Smtp-Source: ABdhPJxkFIJHD5G+sHKDDZhetQ7golkfaXMDUXrac4w6e5h1b2229x+b1/izFo1mNEU6RW8ztIANhysBmulXZm1TYlA= X-Received: by 2002:a1f:b488:: with SMTP id d130mr31749720vkf.17.1622046092243; Wed, 26 May 2021 09:21:32 -0700 (PDT) MIME-Version: 1.0 References: <20210516171432.1734268-1-emil.l.velikov@gmail.com> In-Reply-To: From: Emil Velikov Date: Wed, 26 May 2021 17:21:20 +0100 Message-ID: To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Subject: Re: [Intel-gfx] [PATCH] drm/i915: only disable default vga device X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , kernel@collabora.com, ML dri-devel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" SGkgVmlsbGUsCgpPbiBUdWUsIDE4IE1heSAyMDIxIGF0IDEyOjE3LCBWaWxsZSBTeXJqw6Rsw6QK PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPgo+IE9uIFR1ZSwgTWF5IDE4 LCAyMDIxIGF0IDEyOjA5OjU2UE0gKzAxMDAsIEVtaWwgVmVsaWtvdiB3cm90ZToKPiA+IEhpIFZp bGxlLAo+ID4KPiA+IE9uIE1vbiwgMTcgTWF5IDIwMjEgYXQgMTg6MjQsIFZpbGxlIFN5cmrDpGzD pAo+ID4gPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+ID4KPiA+ID4g T24gU3VuLCBNYXkgMTYsIDIwMjEgYXQgMDY6MTQ6MzJQTSArMDEwMCwgRW1pbCBWZWxpa292IHdy b3RlOgo+ID4gPiA+IEZyb206IFZpdmVrIERhcyBNb2hhcGF0cmEgPHZpdmVrQGNvbGxhYm9yYS5j b20+Cj4gPiA+ID4KPiA+ID4gPiBUaGlzIHBhdGNoIGlzIHRvIGRvIHdpdGggc2VhbWxlc3MgaGFu ZG92ZXIsIGVnIHdoZW4gdGhlIHNlcXVlbmNlIGlzCj4gPiA+ID4gYm9vdGxvYWRlciDihpIgcGx5 bW91dGgg4oaSIGRlc2t0b3AuCj4gPiA+ID4KPiA+ID4gPiBJdCBzd2l0Y2hlcyB0aGUgdmdhIGFy Yml0ZXIgZnJvbSB0aGUgIm90aGVyIiBHUFUgdG8gdGhlIGRlZmF1bHQgb25lCj4gPiA+ID4gKGlu dGVsIGluIHRoaXMgY2FzZSksIHNvIHRoZSBkcml2ZXIgY2FuIGlzc3VlIHNvbWUgaW8oKS4KPiA+ ID4KPiA+ID4gSSBkb24ndCB1bmRlcnN0YW5kIHdoYXQgdGhpcyBjb21taXQgbWVzc2FnZSBpcyB0 cnlpbmcgdG8gc2F5Lgo+ID4gPgo+ID4gQnVuY2ggb2YgY29udGV4dCBpcyBsb3N0IGR1ZSB0byB0 aGUgcGF0Y2ggYWdlLCBzbyBJJ20gbm90IDEwMCUgc3VyZSBvZgo+ID4gdGhlIGFjdHVhbCBoYXJk d2FyZSBzZXR1cCB3aGVyZSB0aGlzIG9jY3Vycy4KPiA+IERvZXMgdGhlIGZvbGxvd2luZyBtYWtl IHNlbnNlPwo+ID4KPiA+IEN1cnJlbnRseSBvbiBkdWFsIEdQVSBzeXN0ZW1zLCB3ZSBkbyBub3Qg Z2V0IHNlYW1sZXNzIGhhbmRvdmVyIGFzIHRoZQo+ID4gb3V0cHV0IGZsaWNrZXJzIGR1cmluZyB0 aGUgdHJhbnNpdGlvbiBib290bG9hZGVyIC0+IHBseW1vdXRoIC0+Cj4gPiBkZXNrdG9wLgo+ID4g VGhpcyBoYXBwZW5zIGFzIGEgcmVzdWx0IG9mIHN3aXRjaGluZyAodmlhIHRoZSBWR0EgYXJiaXRl cikgZnJvbSB0aGUKPiA+ICJvdGhlciIgR1BVIGJhY2sgdG8gdGhlIGRlZmF1bHQgaTkxNSBvbmUg YW5kIGlzc3VpbmcgaW8oKSBjb21tYW5kcy4KPgo+IEhtbS4gRG9lcyB0aGlzIHdvcms/Cj4KPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3ZnYS5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF92Z2EuYwo+IEBAIC0yOSw2ICsyOSw5IEBA IHZvaWQgaW50ZWxfdmdhX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICAgICAgICAgaTkxNV9yZWdfdCB2Z2FfcmVnID0gaW50ZWxfdmdhX2NudHJsX3JlZyhkZXZf cHJpdik7Cj4gICAgICAgICB1OCBzcjE7Cj4KPiArICAgICAgIGlmIChpbnRlbF9kZV9yZWFkKGRl dl9wcml2LCB2Z2FfcmVnKSAmIFZHQV9ESVNQX0RJU0FCTEUpCj4gKyAgICAgICAgICAgICAgIHJl dHVybjsKPiArCj4gICAgICAgICAvKiBXYUVuYWJsZVZHQUFjY2Vzc1Rocm91Z2hJT1BvcnQ6Y3Rn LGVsayxpbGssc25iLGl2Yix2bHYsaHN3ICovCj4gICAgICAgICB2Z2FfZ2V0X3VuaW50ZXJydXB0 aWJsZShwZGV2LCBWR0FfUlNSQ19MRUdBQ1lfSU8pOwo+ICAgICAgICAgb3V0YihTUjAxLCBWR0Ff U1JfSU5ERVgpOwo+CldhcyBhYmxlIHRvIHJlcGxpY2F0ZSB0aGUgaXNzdWUgc29tZXdoYXQgYW5k IHRoZSBhYm92ZSBkb2VzIGhlbHAgcXVpdGUgYSBsb3QuCkZlZWwgZnJlZSB0byBhZGQgbXk6ClJl dmlld2VkLWJ5OiBFbWlsIFZlbGlrb3YgPGVtaWwudmVsaWtvdkBjb2xsYWJvcmEuY29tPgpUZXN0 ZWQtYnk6IEVtaWwgVmVsaWtvdiA8ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5jb20+CgpBbHNvIGZl ZWwgZnJlZSB0byByZXVzZSBhcyBtdWNoL2xpdHRsZSBvZiB0aGUgZm9sbG93aW5nIHNldHVwIGRl dGFpbHMuCgpUbyByZXByb2R1Y2UgdGhlIGlzc3VlOgoKR2V0IGEgZHVhbCBHUFUgc3lzdGVtIC0g SW50ZWwrTnZpZGlhIGluIG15IGNhc2UuIFNldCB0aGUgb3RoZXIKKE52aWRpYSkgYXMgZGVmYXVs dCBpbiBVRUZJIGFuZCBjb25uZWN0IG1vbml0b3JzIHRvIGl0LgpFbnN1cmUgdGhlIGJvb3Rsb2Fk ZXIgKGFuZCBpZiB1c2luZyBzcGxhc2ggbWFuYWdlciBsaWtlIHBseW1vdXRoKSBhcmUKc2V0IHRv IGRpc3BsYXkgdGhlIFVFRkkgQkdSVC4gUGVyc29uYWxseSBJIHRlc3RlZCBzeXN0ZW1kLWJvb3Qs CmFsdGhvdWdoIEdSVUIgc2hvdWxkIGFsc28gd29yay4gSSBjb3VsZG4ndCBnZXQgcGx5bW91dGgg dG8gd29yay9iZWhhdmUKaGVyZSA6c2hydWc6CgpOb3RlOiBIYXZpbmcgdGhlIE52aWRpYSBkcml2 ZXJzIGluIHRoZSBpbml0cmFtZnMgY2FuIGxlYWQgdG8gZXh0cmEKZmxpY2tlciBzbyBsZWF2ZSB0 aGVtIG91dC4gSW5jbHVkZSB0aGUgaTkxNSBkcml2ZXJzIGluIGluaXRyYW1mcy4KCldpdGhvdXQg dGhlIHBhdGNoLCB0aGUgZXhpc3RpbmcgYm9vdHNsYXNoIGlzIHdpcGVkIGNsZWFuIGFsbW9zdApp bnN0YW50YW5lb3VzbHkgYXMgdGhlIGk5MTUgZHJpdmVyIGNhbGxzIGludGVsX3ZnYV9kaXNhYmxl KCkuCldpdGggeW91ciBwYXRjaCB0aGUgY2FsbCBpcyBhIG5vLW9wLCBhbmQgdGhlIGJvb3RzcGxh c2ggc3RheXMgYXJvdW5kCnVudGlsIHRoZSBsb2dpbiBtYW5hZ2VyIChhbmQgWCkgaXMgc3Bhd25l ZC4KCkhUSApFbWlsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=