From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756067AbeARNIE (ORCPT ); Thu, 18 Jan 2018 08:08:04 -0500 Received: from mail-wr0-f181.google.com ([209.85.128.181]:37131 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753361AbeARNIC (ORCPT ); Thu, 18 Jan 2018 08:08:02 -0500 X-Google-Smtp-Source: ACJfBotG0Nji2lQa76JWkYctvI+wjG8KnvINToVU1cq+OUTuG038sABOCiVVg/67EhfOh4GdjVNO1e/1Al2XBgYVOrY= MIME-Version: 1.0 In-Reply-To: References: <20180117140159.27611-1-daniel.vetter@ffwll.ch> <20180117140159.27611-2-daniel.vetter@ffwll.ch> From: Emil Velikov Date: Thu, 18 Jan 2018 13:08:01 +0000 Message-ID: Subject: Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state To: Daniel Thompson Cc: Daniel Vetter , DRI Development , LKML , Jingoo Han , Daniel Vetter , Lee Jones Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17 January 2018 at 16:37, Daniel Thompson wrote: > > > On 17/01/18 14:36, Emil Velikov wrote: >> >> On 17 January 2018 at 14:01, Daniel Vetter wrote: >>> >>> Nothing in the entire tree ever sets this, which means this is dead >>> code. Remove it. >>> >>> Cc: Lee Jones >>> Cc: Daniel Thompson >>> Cc: Jingoo Han >>> Signed-off-by: Daniel Vetter >>> --- >>> drivers/video/backlight/generic_bl.c | 5 ----- >> >> >> Fly-by comment, while waiting for coffee to kick-in. >> I think this patch should be after pandora/others have stopped abusing >> BL_CORE_DRIVER1. > > > You sure? > > I can't see why the use or disuse of BL_CORE_DRIVER1 in this driver should > influence another independent driver. > Right my bad. Got mislead by the driver name. -Emil From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Subject: Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state Date: Thu, 18 Jan 2018 13:08:01 +0000 Message-ID: References: <20180117140159.27611-1-daniel.vetter@ffwll.ch> <20180117140159.27611-2-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr0-x22b.google.com (mail-wr0-x22b.google.com [IPv6:2a00:1450:400c:c0c::22b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1F03E6E58A for ; Thu, 18 Jan 2018 13:08:02 +0000 (UTC) Received: by mail-wr0-x22b.google.com with SMTP id p6so22523335wrd.0 for ; Thu, 18 Jan 2018 05:08:02 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Thompson Cc: Daniel Vetter , LKML , DRI Development , Jingoo Han , Daniel Vetter , Lee Jones List-Id: dri-devel@lists.freedesktop.org T24gMTcgSmFudWFyeSAyMDE4IGF0IDE2OjM3LCBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50aG9t cHNvbkBsaW5hcm8ub3JnPiB3cm90ZToKPgo+Cj4gT24gMTcvMDEvMTggMTQ6MzYsIEVtaWwgVmVs aWtvdiB3cm90ZToKPj4KPj4gT24gMTcgSmFudWFyeSAyMDE4IGF0IDE0OjAxLCBEYW5pZWwgVmV0 dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPiB3cm90ZToKPj4+Cj4+PiBOb3RoaW5nIGluIHRo ZSBlbnRpcmUgdHJlZSBldmVyIHNldHMgdGhpcywgd2hpY2ggbWVhbnMgdGhpcyBpcyBkZWFkCj4+ PiBjb2RlLiBSZW1vdmUgaXQuCj4+Pgo+Pj4gQ2M6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+Cj4+PiBDYzogRGFuaWVsIFRob21wc29uIDxkYW5pZWwudGhvbXBzb25AbGluYXJvLm9y Zz4KPj4+IENjOiBKaW5nb28gSGFuIDxqaW5nb29oYW4xQGdtYWlsLmNvbT4KPj4+IFNpZ25lZC1v ZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+Pj4gLS0tCj4+ PiAgIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2dlbmVyaWNfYmwuYyB8IDUgLS0tLS0KPj4KPj4K Pj4gRmx5LWJ5IGNvbW1lbnQsIHdoaWxlIHdhaXRpbmcgZm9yIGNvZmZlZSB0byBraWNrLWluLgo+ PiBJIHRoaW5rIHRoaXMgcGF0Y2ggc2hvdWxkIGJlIGFmdGVyIHBhbmRvcmEvb3RoZXJzIGhhdmUg c3RvcHBlZCBhYnVzaW5nCj4+IEJMX0NPUkVfRFJJVkVSMS4KPgo+Cj4gWW91IHN1cmU/Cj4KPiBJ IGNhbid0IHNlZSB3aHkgdGhlIHVzZSBvciBkaXN1c2Ugb2YgQkxfQ09SRV9EUklWRVIxIGluIHRo aXMgZHJpdmVyIHNob3VsZAo+IGluZmx1ZW5jZSBhbm90aGVyIGluZGVwZW5kZW50IGRyaXZlci4K PgpSaWdodCBteSBiYWQuIEdvdCBtaXNsZWFkIGJ5IHRoZSBkcml2ZXIgbmFtZS4KCi1FbWlsCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=