From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Date: Mon, 18 May 2020 13:19:57 +0000 Subject: Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau Message-Id: List-Id: References: <20200517220524.4036334-1-emil.l.velikov@gmail.com> <20200517220524.4036334-2-emil.l.velikov@gmail.com> <87d071aedu.fsf@mpe.ellerman.id.au> <3bd8fb59-2a91-64d7-bef9-d5f717c49bfb@samsung.com> In-Reply-To: <3bd8fb59-2a91-64d7-bef9-d5f717c49bfb@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bartlomiej Zolnierkiewicz Cc: linux-fbdev , Michael Ellerman , ML dri-devel , Paul Mackerras , linuxppc-dev On Mon, 18 May 2020 at 13:48, Bartlomiej Zolnierkiewicz wrote: > > > On 5/18/20 1:19 PM, Emil Velikov wrote: > > Hi Michael, > > > > On Mon, 18 May 2020 at 08:30, Michael Ellerman wrote: > >> > >> Emil Velikov writes: > >>> As mentioned in earlier commit, the riva and nvidia fbdev drivers have > >>> seen no love over the years, are short on features and overall below par > >>> > >>> Users are encouraged to switch to the nouveau drm driver instead. > >>> > >>> v2: Split configs to separate patch, enable nouveau (Bartlomiej) > >>> > >>> Cc: Antonino Daplas > >>> Cc: Bartlomiej Zolnierkiewicz > >>> Cc: linux-fbdev@vger.kernel.org > >>> Cc: dri-devel@lists.freedesktop.org > >>> Cc: Michael Ellerman > >>> Cc: Benjamin Herrenschmidt > >>> Cc: Paul Mackerras > >>> Cc: linuxppc-dev@lists.ozlabs.org > >>> Signed-off-by: Emil Velikov > >>> Acked-by: Daniel Vetter (v1) > >>> --- > >>> Hi all unless, there are objections I would prefer to merge this via > >>> the drm tree. > >> > >> Have you tested that the resulting kernels work on the relevant > >> hardware? > >> > > Sadly, no I haven't. I'm updating the defconfigs as requested by the > > fbdev maintainer. > > I've just noticed that v1 (patch #1/1) & v2 (patch #1/2) lack > Cc: to powerpc Maintainers so they cannot see the context of > changes in this patch. > Haven't see any instances of fbdev/drm patches being Cc to arch/ developers. As such I made sure the commit message illustrates 1/2 as clearly as possible. > Also you've proposed v1 yourself and it has already contained > modifications to defconfigs (removal of setting the config > options for the old drivers) in addition to marking the old > drivers as BROKEN. > > It now turns out that v1 has also never been tested. :( > > Please don't submit untested patches without marking them > as such. > Does x86 box with nv34 GPU count as testing? I suspect not :-( It was been using nouveau ever since I bought it 15+ years ago. Will be more careful in the future. -Emil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59977C433DF for ; Mon, 18 May 2020 13:24:07 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C33412065F for ; Mon, 18 May 2020 13:24:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P/j+l4rl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C33412065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49QfqR08BLzDqbW for ; Mon, 18 May 2020 23:24:03 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::e42; helo=mail-vs1-xe42.google.com; envelope-from=emil.l.velikov@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=P/j+l4rl; dkim-atps=neutral Received: from mail-vs1-xe42.google.com (mail-vs1-xe42.google.com [IPv6:2607:f8b0:4864:20::e42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49Qfl33hslzDqWc for ; Mon, 18 May 2020 23:20:12 +1000 (AEST) Received: by mail-vs1-xe42.google.com with SMTP id l15so3637851vsr.3 for ; Mon, 18 May 2020 06:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=smFwrGW+2ZYyRm3yJx9TvCDHllY75XTU0ZDXk/besJY=; b=P/j+l4rloAGJ5+zOh7ldG3MH1MdKGjKsbOchWEgDz0r3TcptKxJ1Bp8HWPcC1S3fmm rX/Ml0ruOt+Zix5rJNR8BVurvVsN/K4gCUQfEm62amnKjAll6C/pestSxWW+iWgQY9jy tTWNTrDxkQrfrVc+lNfLeVJrBgZ7/vicsqJWKimsblBlPKhR/CVoKdlJ3NNCPiHj0qtI bJ6v+HqXqrmGR0xZPvzDg/uhV1AwqgA3sHXFT5MkuzYewlbMnfUAmm2kngveuxpuS8e+ 8bF+VeDJ1VAOdMMzqlMvEgvuvxO+HvNfpuR4H+ZPstuBIbaUn4xjW0RSWNyPxwHa3724 uDUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=smFwrGW+2ZYyRm3yJx9TvCDHllY75XTU0ZDXk/besJY=; b=Evavm/3uZzxND4RGPEsrJt3yC5KuNOT1wriLl0npYHVo3yMVDbY7onn31tQK/T4XHj MwFJfrIi1s5NBuMYRd1ILUp25uHNiduf5R8XoUppeS2yUpvIQW1lqbFYiD806CB1XY7e 74hsi2ngttMUJl+GWGAWx8IFT3wvUBApMj09eqfzHVc3Hrka+A1nHR2PDFOssb9VfY4E ht7W06YPFpJiukpVzoez6BLRia2bo7bHxmT8BahrHiQ42qCaQ+lM6KCFNCFMlzlZKDmi Z8txJkIeltgYtNTNdPc5ukT8nkeRJvf7fwNYeJA7yIdkwzC07TKEK3keYvmETU3nNojD aJJg== X-Gm-Message-State: AOAM531id2R4Vd+8yhM4vFL0VPkGQ2DkpRnmcWF12wP0TP2kEpOl12OQ qWXM/Opq4TYG5c8Jm5TEiLhhNUkUi2C60rJMQ2A= X-Google-Smtp-Source: ABdhPJyB9j3yxm/3uct+3is6hkBldRsVNEHECFEnQ4z23rMWJaJ9Tdo/jYPHQ+KXggCqQyHhC6tZDoDIkFVYF/4KxZU= X-Received: by 2002:a67:be19:: with SMTP id x25mr1506536vsq.37.1589808009106; Mon, 18 May 2020 06:20:09 -0700 (PDT) MIME-Version: 1.0 References: <20200517220524.4036334-1-emil.l.velikov@gmail.com> <20200517220524.4036334-2-emil.l.velikov@gmail.com> <87d071aedu.fsf@mpe.ellerman.id.au> <3bd8fb59-2a91-64d7-bef9-d5f717c49bfb@samsung.com> In-Reply-To: <3bd8fb59-2a91-64d7-bef9-d5f717c49bfb@samsung.com> From: Emil Velikov Date: Mon, 18 May 2020 14:19:57 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau To: Bartlomiej Zolnierkiewicz Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev , Antonino Daplas , ML dri-devel , Paul Mackerras , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 18 May 2020 at 13:48, Bartlomiej Zolnierkiewicz wrote: > > > On 5/18/20 1:19 PM, Emil Velikov wrote: > > Hi Michael, > > > > On Mon, 18 May 2020 at 08:30, Michael Ellerman wrote: > >> > >> Emil Velikov writes: > >>> As mentioned in earlier commit, the riva and nvidia fbdev drivers have > >>> seen no love over the years, are short on features and overall below par > >>> > >>> Users are encouraged to switch to the nouveau drm driver instead. > >>> > >>> v2: Split configs to separate patch, enable nouveau (Bartlomiej) > >>> > >>> Cc: Antonino Daplas > >>> Cc: Bartlomiej Zolnierkiewicz > >>> Cc: linux-fbdev@vger.kernel.org > >>> Cc: dri-devel@lists.freedesktop.org > >>> Cc: Michael Ellerman > >>> Cc: Benjamin Herrenschmidt > >>> Cc: Paul Mackerras > >>> Cc: linuxppc-dev@lists.ozlabs.org > >>> Signed-off-by: Emil Velikov > >>> Acked-by: Daniel Vetter (v1) > >>> --- > >>> Hi all unless, there are objections I would prefer to merge this via > >>> the drm tree. > >> > >> Have you tested that the resulting kernels work on the relevant > >> hardware? > >> > > Sadly, no I haven't. I'm updating the defconfigs as requested by the > > fbdev maintainer. > > I've just noticed that v1 (patch #1/1) & v2 (patch #1/2) lack > Cc: to powerpc Maintainers so they cannot see the context of > changes in this patch. > Haven't see any instances of fbdev/drm patches being Cc to arch/ developers. As such I made sure the commit message illustrates 1/2 as clearly as possible. > Also you've proposed v1 yourself and it has already contained > modifications to defconfigs (removal of setting the config > options for the old drivers) in addition to marking the old > drivers as BROKEN. > > It now turns out that v1 has also never been tested. :( > > Please don't submit untested patches without marking them > as such. > Does x86 box with nv34 GPU count as testing? I suspect not :-( It was been using nouveau ever since I bought it 15+ years ago. Will be more careful in the future. -Emil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16941C433E0 for ; Mon, 18 May 2020 13:20:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDB822065F for ; Mon, 18 May 2020 13:20:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P/j+l4rl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDB822065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 798DA6E154; Mon, 18 May 2020 13:20:11 +0000 (UTC) Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 076946E154 for ; Mon, 18 May 2020 13:20:09 +0000 (UTC) Received: by mail-vs1-xe44.google.com with SMTP id 62so5529194vsi.2 for ; Mon, 18 May 2020 06:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=smFwrGW+2ZYyRm3yJx9TvCDHllY75XTU0ZDXk/besJY=; b=P/j+l4rloAGJ5+zOh7ldG3MH1MdKGjKsbOchWEgDz0r3TcptKxJ1Bp8HWPcC1S3fmm rX/Ml0ruOt+Zix5rJNR8BVurvVsN/K4gCUQfEm62amnKjAll6C/pestSxWW+iWgQY9jy tTWNTrDxkQrfrVc+lNfLeVJrBgZ7/vicsqJWKimsblBlPKhR/CVoKdlJ3NNCPiHj0qtI bJ6v+HqXqrmGR0xZPvzDg/uhV1AwqgA3sHXFT5MkuzYewlbMnfUAmm2kngveuxpuS8e+ 8bF+VeDJ1VAOdMMzqlMvEgvuvxO+HvNfpuR4H+ZPstuBIbaUn4xjW0RSWNyPxwHa3724 uDUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=smFwrGW+2ZYyRm3yJx9TvCDHllY75XTU0ZDXk/besJY=; b=b8Wtwam0BgZbkKapjamFxGrNvueflGFBEgnZtAflpkW6Dp9h/vlEmtaFC6pX7tGnec L1YR2ecTvqwDu9L4NU5BQqkyqnwzTYIOafeN+CGG6CQwcsGAJMvCXWYaYt8NYNd8nLDW yBbzvlOV9qSSxIp5yxYn78hHUpwwYLm+u497baBVb0OuTZPc6rFz+r+b6Kh/tR35E6OX lX9W4ChGR2u9bPxqrWm4rJFHv0Whmf+LnavkqtGXrdEjdXJfajklGo2e+ybL367DNdwv B16HYAhPd1kStVJqGAaFuNqkOe0Z3rQGtKr9mBwLQHKojc/l1pzomcilb8KQ8XOGb4Hx bvmg== X-Gm-Message-State: AOAM531SKuRh6mguuDsOkIOPSKO0XwxdbkH0onQDGqIruc8uUTp71At9 zEyNC3zjPyngOrgl+wdDX+DLIeKtOwVmakwSo60= X-Google-Smtp-Source: ABdhPJyB9j3yxm/3uct+3is6hkBldRsVNEHECFEnQ4z23rMWJaJ9Tdo/jYPHQ+KXggCqQyHhC6tZDoDIkFVYF/4KxZU= X-Received: by 2002:a67:be19:: with SMTP id x25mr1506536vsq.37.1589808009106; Mon, 18 May 2020 06:20:09 -0700 (PDT) MIME-Version: 1.0 References: <20200517220524.4036334-1-emil.l.velikov@gmail.com> <20200517220524.4036334-2-emil.l.velikov@gmail.com> <87d071aedu.fsf@mpe.ellerman.id.au> <3bd8fb59-2a91-64d7-bef9-d5f717c49bfb@samsung.com> In-Reply-To: <3bd8fb59-2a91-64d7-bef9-d5f717c49bfb@samsung.com> From: Emil Velikov Date: Mon, 18 May 2020 14:19:57 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau To: Bartlomiej Zolnierkiewicz X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev , Michael Ellerman , ML dri-devel , Paul Mackerras , linuxppc-dev Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 18 May 2020 at 13:48, Bartlomiej Zolnierkiewicz wrote: > > > On 5/18/20 1:19 PM, Emil Velikov wrote: > > Hi Michael, > > > > On Mon, 18 May 2020 at 08:30, Michael Ellerman wrote: > >> > >> Emil Velikov writes: > >>> As mentioned in earlier commit, the riva and nvidia fbdev drivers have > >>> seen no love over the years, are short on features and overall below par > >>> > >>> Users are encouraged to switch to the nouveau drm driver instead. > >>> > >>> v2: Split configs to separate patch, enable nouveau (Bartlomiej) > >>> > >>> Cc: Antonino Daplas > >>> Cc: Bartlomiej Zolnierkiewicz > >>> Cc: linux-fbdev@vger.kernel.org > >>> Cc: dri-devel@lists.freedesktop.org > >>> Cc: Michael Ellerman > >>> Cc: Benjamin Herrenschmidt > >>> Cc: Paul Mackerras > >>> Cc: linuxppc-dev@lists.ozlabs.org > >>> Signed-off-by: Emil Velikov > >>> Acked-by: Daniel Vetter (v1) > >>> --- > >>> Hi all unless, there are objections I would prefer to merge this via > >>> the drm tree. > >> > >> Have you tested that the resulting kernels work on the relevant > >> hardware? > >> > > Sadly, no I haven't. I'm updating the defconfigs as requested by the > > fbdev maintainer. > > I've just noticed that v1 (patch #1/1) & v2 (patch #1/2) lack > Cc: to powerpc Maintainers so they cannot see the context of > changes in this patch. > Haven't see any instances of fbdev/drm patches being Cc to arch/ developers. As such I made sure the commit message illustrates 1/2 as clearly as possible. > Also you've proposed v1 yourself and it has already contained > modifications to defconfigs (removal of setting the config > options for the old drivers) in addition to marking the old > drivers as BROKEN. > > It now turns out that v1 has also never been tested. :( > > Please don't submit untested patches without marking them > as such. > Does x86 box with nv34 GPU count as testing? I suspect not :-( It was been using nouveau ever since I bought it 15+ years ago. Will be more careful in the future. -Emil _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel