From: Emil Velikov <emil.l.velikov@gmail.com>
To: "Christian König" <deathsimple@vodafone.de>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"Cui, Flora" <Flora.Cui@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"Zhang, Hawking" <Hawking.Zhang@amd.com>
Subject: Re: [PATCH 1/2] drm/ttm: remove unused placement flags
Date: Fri, 9 Sep 2016 14:54:54 +0100 [thread overview]
Message-ID: <CACvgo53AAEsxAoQvAe=ffMnQiZiE=MPWne2Abg=rAt4bRkK8NQ@mail.gmail.com> (raw)
In-Reply-To: <79da37c4-8259-5301-8a42-ef2f28769728@vodafone.de>
On 9 September 2016 at 12:24, Christian König <deathsimple@vodafone.de> wrote:
> Hi Hawking,
>
>> Removing the flag will make ttm_mem_type_from_place skip counting the
>> corresponding placement and thus have impact on mem region create and bo
>> movement.
>
> And that is exactly the reason why I want to remove the unused flags.
>
>> There is no guarantee that amdgpu would never introduce new memory domain
>> in future.
>
> Irrelevant, if any driver wants to use additional domains it should add them
> when they are used.
>
> BTW: Why would we want to add another TTM domain? I really don't see any
> need for that.
>
>> Then how about keep these flags?
>
> Actually we used to have automated scanners which complain about unused
> code. I'm wondering why they don't detected that earlier.
>
> Anyway any code which isn't used in a while should be removed.
>
Fwiw I second Christian here. If they are unused in open-source
drivers there's no reason to keep them.
If/as that changes the (newly introduced) user can add back the relevant code.
If closed-source driver(s) use them, then they can keep it as part of
their blob. Upstream kernel does not cater for closed-source drivers,
period.
I realise that's not the answer some are hoping for, so if you want to
question it take it up with Linus and co.
Regards,
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-09-09 13:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 13:41 [PATCH 1/2] drm/ttm: remove unused placement flags Christian König
2016-09-08 13:41 ` [PATCH 2/2] drm/ttm: move placement structures into ttm_placement.h Christian König
2016-09-09 6:42 ` zhoucm1
[not found] ` <1473342102-324-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-09-09 6:41 ` [PATCH 1/2] drm/ttm: remove unused placement flags zhoucm1
[not found] ` <57D2598C.1070903-5C7GfCeVMHo@public.gmane.org>
2016-09-09 7:01 ` Flora Cui
2016-09-09 9:06 ` Christian König
[not found] ` <79675437-85ae-2fbf-93e1-b49321e6a41e-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-09-09 10:21 ` Zhang, Hawking
2016-09-09 10:35 ` Zhang, Hawking
[not found] ` <BN6PR12MB120407ACA888A0E57CA16D7AFCFA0-/b2+HYfkarSdTuMsQheahAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-09-09 11:24 ` Christian König
2016-09-09 13:41 ` Deucher, Alexander
[not found] ` <MWHPR12MB1694DB49A6A9336A654384C3F7FA0-Gy0DoCVfaSW4WA4dJ5YXGAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-09-09 14:17 ` Christian König
2016-09-09 13:54 ` Emil Velikov [this message]
[not found] ` <CACvgo53AAEsxAoQvAe=ffMnQiZiE=MPWne2Abg=rAt4bRkK8NQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-09 14:30 ` Christian König
2016-09-09 15:11 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvgo53AAEsxAoQvAe=ffMnQiZiE=MPWne2Abg=rAt4bRkK8NQ@mail.gmail.com' \
--to=emil.l.velikov@gmail.com \
--cc=Christian.Koenig@amd.com \
--cc=Flora.Cui@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.