From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753844AbcJLL2v (ORCPT ); Wed, 12 Oct 2016 07:28:51 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:35329 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497AbcJLL2n (ORCPT ); Wed, 12 Oct 2016 07:28:43 -0400 MIME-Version: 1.0 In-Reply-To: <87lgxvqlg3.fsf@intel.com> References: <87h98ktxow.fsf@intel.com> <87lgxvqlg3.fsf@intel.com> From: Emil Velikov Date: Wed, 12 Oct 2016 12:28:40 +0100 Message-ID: Subject: Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate". To: Jani Nikula Cc: "Sun, Jing A" , Takashi Iwai , "airlied@linux.ie" , "Vetter, Daniel" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "a.hajda@samsung.com" , Thierry Reding Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11 October 2016 at 10:33, Jani Nikula wrote: > On Tue, 11 Oct 2016, "Sun, Jing A" wrote: >> It's needed that DRM Driver module could be removed and reloaded after >> kernel booting on the projects that I have been working on, and I hope >> such module type change could be accepted. Looks like Iwai has similar >> change request as well. Would you please review it and let us know if >> any concerns? > > Looking at the Kconfig, selecting CONFIG_DRM_MIPI_DSI is against the > recommendations of Documentation/kbuild/kconfig-language.txt: > > select should be used with care. select will force > a symbol to a value without visiting the dependencies. > By abusing select you are able to select a symbol FOO even > if FOO depends on BAR that is not set. > In general use select only for non-visible symbols > (no prompts anywhere) and for symbols with no dependencies. > That will limit the usefulness but on the other hand avoid > the illegal configurations all over. > > Indeed, you may end up with CONFIG_DRM_MIPI_DSI=y and CONFIG_DRM=m, > which violates DRM_MIPI_DSI dependency on CONFIG_DRM. This is broken and > should be fixed. The suggested patch does *not* fix this issue. > Jani, git log suggests you as the unfortunate author of the select DRM_MIPI_DSI/select DRM_PANEL hunks in i915 ;-) >>From a cutesy skim through panel/ there are a handful of things to squash - unused select/depend on, s/select/depend on/ etc. Sadly I don't have the time to address these :-\ Regards, Emil From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Subject: Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate". Date: Wed, 12 Oct 2016 12:28:40 +0100 Message-ID: References: <87h98ktxow.fsf@intel.com> <87lgxvqlg3.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 061646E1FC for ; Wed, 12 Oct 2016 11:28:43 +0000 (UTC) Received: by mail-lf0-x242.google.com with SMTP id x23so896846lfi.1 for ; Wed, 12 Oct 2016 04:28:42 -0700 (PDT) In-Reply-To: <87lgxvqlg3.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Sun, Jing A" , "Vetter, Daniel" , Thierry Reding List-Id: dri-devel@lists.freedesktop.org T24gMTEgT2N0b2JlciAyMDE2IGF0IDEwOjMzLCBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGlu dXguaW50ZWwuY29tPiB3cm90ZToKPiBPbiBUdWUsIDExIE9jdCAyMDE2LCAiU3VuLCBKaW5nIEEi IDxqaW5nLmEuc3VuQGludGVsLmNvbT4gd3JvdGU6Cj4+IEl0J3MgbmVlZGVkIHRoYXQgRFJNIERy aXZlciBtb2R1bGUgY291bGQgYmUgcmVtb3ZlZCBhbmQgcmVsb2FkZWQgYWZ0ZXIKPj4ga2VybmVs IGJvb3Rpbmcgb24gdGhlIHByb2plY3RzIHRoYXQgSSBoYXZlIGJlZW4gd29ya2luZyBvbiwgYW5k IEkgaG9wZQo+PiBzdWNoIG1vZHVsZSB0eXBlIGNoYW5nZSBjb3VsZCBiZSBhY2NlcHRlZC4gTG9v a3MgbGlrZSBJd2FpIGhhcyBzaW1pbGFyCj4+IGNoYW5nZSByZXF1ZXN0IGFzIHdlbGwuIFdvdWxk IHlvdSBwbGVhc2UgcmV2aWV3IGl0IGFuZCBsZXQgdXMga25vdyBpZgo+PiBhbnkgY29uY2VybnM/ Cj4KPiBMb29raW5nIGF0IHRoZSBLY29uZmlnLCBzZWxlY3RpbmcgQ09ORklHX0RSTV9NSVBJX0RT SSBpcyBhZ2FpbnN0IHRoZQo+IHJlY29tbWVuZGF0aW9ucyBvZiBEb2N1bWVudGF0aW9uL2tidWls ZC9rY29uZmlnLWxhbmd1YWdlLnR4dDoKPgo+ICAgICAgICAgc2VsZWN0IHNob3VsZCBiZSB1c2Vk IHdpdGggY2FyZS4gc2VsZWN0IHdpbGwgZm9yY2UKPiAgICAgICAgIGEgc3ltYm9sIHRvIGEgdmFs dWUgd2l0aG91dCB2aXNpdGluZyB0aGUgZGVwZW5kZW5jaWVzLgo+ICAgICAgICAgQnkgYWJ1c2lu ZyBzZWxlY3QgeW91IGFyZSBhYmxlIHRvIHNlbGVjdCBhIHN5bWJvbCBGT08gZXZlbgo+ICAgICAg ICAgaWYgRk9PIGRlcGVuZHMgb24gQkFSIHRoYXQgaXMgbm90IHNldC4KPiAgICAgICAgIEluIGdl bmVyYWwgdXNlIHNlbGVjdCBvbmx5IGZvciBub24tdmlzaWJsZSBzeW1ib2xzCj4gICAgICAgICAo bm8gcHJvbXB0cyBhbnl3aGVyZSkgYW5kIGZvciBzeW1ib2xzIHdpdGggbm8gZGVwZW5kZW5jaWVz Lgo+ICAgICAgICAgVGhhdCB3aWxsIGxpbWl0IHRoZSB1c2VmdWxuZXNzIGJ1dCBvbiB0aGUgb3Ro ZXIgaGFuZCBhdm9pZAo+ICAgICAgICAgdGhlIGlsbGVnYWwgY29uZmlndXJhdGlvbnMgYWxsIG92 ZXIuCj4KPiBJbmRlZWQsIHlvdSBtYXkgZW5kIHVwIHdpdGggQ09ORklHX0RSTV9NSVBJX0RTST15 IGFuZCBDT05GSUdfRFJNPW0sCj4gd2hpY2ggdmlvbGF0ZXMgRFJNX01JUElfRFNJIGRlcGVuZGVu Y3kgb24gQ09ORklHX0RSTS4gVGhpcyBpcyBicm9rZW4gYW5kCj4gc2hvdWxkIGJlIGZpeGVkLiBU aGUgc3VnZ2VzdGVkIHBhdGNoIGRvZXMgKm5vdCogZml4IHRoaXMgaXNzdWUuCj4KSmFuaSwgZ2l0 IGxvZyBzdWdnZXN0cyB5b3UgYXMgdGhlIHVuZm9ydHVuYXRlIGF1dGhvciBvZiB0aGUgc2VsZWN0 CkRSTV9NSVBJX0RTSS9zZWxlY3QgRFJNX1BBTkVMIGh1bmtzIGluIGk5MTUgOy0pCgpGcm9tIGEg Y3V0ZXN5IHNraW0gdGhyb3VnaCBwYW5lbC8gdGhlcmUgYXJlIGEgaGFuZGZ1bCBvZiB0aGluZ3Mg dG8Kc3F1YXNoIC0gdW51c2VkIHNlbGVjdC9kZXBlbmQgb24sIHMvc2VsZWN0L2RlcGVuZCBvbi8g ZXRjLiBTYWRseSBJCmRvbid0IGhhdmUgdGhlIHRpbWUgdG8gYWRkcmVzcyB0aGVzZSA6LVwKClJl Z2FyZHMsCkVtaWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg==