From: Emil Velikov <emil.l.velikov@gmail.com>
To: Eric Engestrom <eric.engestrom@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH libdrm] intel: use drm namespace for exported functions
Date: Thu, 6 Sep 2018 15:44:51 +0100 [thread overview]
Message-ID: <CACvgo53am6GnyTP=mv2tnnwubo5vZ+QM-6_hh0EGrwL7bDXy5w@mail.gmail.com> (raw)
In-Reply-To: <20180906135218.4700-1-eric.engestrom@intel.com>
On 6 September 2018 at 14:52, Eric Engestrom <eric.engestrom@intel.com> wrote:
> And add them to the list of exported function to fix the tests.
>
> Fixes: 4e81d4f9c9b7fd6510cf "intel: add generic functions to check PCI ID"
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
> ---
> Lucas, I'm assuming you meant to export those functions (and macros,
> like `IS_GEN11()`), right?
> If so, you need to namespace them, and add them to the list of allowed
> exports.
The function isn't one part of the public API.
So I'd keep the name and add the drm_private notation (adds visibility=hidden)
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-09-06 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 13:52 [PATCH libdrm] intel: use drm namespace for exported functions Eric Engestrom
2018-09-06 14:44 ` Emil Velikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvgo53am6GnyTP=mv2tnnwubo5vZ+QM-6_hh0EGrwL7bDXy5w@mail.gmail.com' \
--to=emil.l.velikov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.engestrom@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.