From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751132AbbCTST3 (ORCPT ); Fri, 20 Mar 2015 14:19:29 -0400 Received: from mail-yh0-f54.google.com ([209.85.213.54]:33469 "EHLO mail-yh0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbbCTST1 (ORCPT ); Fri, 20 Mar 2015 14:19:27 -0400 MIME-Version: 1.0 In-Reply-To: <1426850083-11049-2-git-send-email-javi.merino@arm.com> References: <1426850083-11049-1-git-send-email-javi.merino@arm.com> <1426850083-11049-2-git-send-email-javi.merino@arm.com> Date: Fri, 20 Mar 2015 18:19:26 +0000 Message-ID: Subject: Re: [PATCH 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL From: Emil Velikov To: Javi Merino Cc: Andrew Morton , "intel-gfx@lists.freedesktop.org" , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , Daniel Vetter , Guenter Roeck , "Darrick J. Wong" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20 March 2015 at 11:14, Javi Merino wrote: > We have grown a number of different implementations of > DIV_ROUND_CLOSEST_ULL throughout the kernel. Move the i915 one to > kernel.h so that it can be reused. > > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: David Airlie > Cc: Darrick J. Wong > Cc: Guenter Roeck > Cc: Andrew Morton > Signed-off-by: Javi Merino > --- > drivers/gpu/drm/i915/intel_drv.h | 4 +--- > include/linux/kernel.h | 11 +++++++++++ > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index eef79ccd0b7c..346e28fdd7dd 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include Hi Javi, Small suggestion - can we include the header only where needed ? i915/intel_panel.c seems to be the only user of DIV_ROUND_CLOSEST which will need an update. Somewhat trivial pick but it will prevent ~40 unnecessary dives in kernel.h. Cheers, Emil From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Subject: Re: [PATCH 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL Date: Fri, 20 Mar 2015 18:19:26 +0000 Message-ID: References: <1426850083-11049-1-git-send-email-javi.merino@arm.com> <1426850083-11049-2-git-send-email-javi.merino@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1426850083-11049-2-git-send-email-javi.merino@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Javi Merino Cc: "intel-gfx@lists.freedesktop.org" , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , Daniel Vetter , Andrew Morton , Guenter Roeck , "Darrick J. Wong" List-Id: dri-devel@lists.freedesktop.org T24gMjAgTWFyY2ggMjAxNSBhdCAxMToxNCwgSmF2aSBNZXJpbm8gPGphdmkubWVyaW5vQGFybS5j b20+IHdyb3RlOgo+IFdlIGhhdmUgZ3Jvd24gYSBudW1iZXIgb2YgZGlmZmVyZW50IGltcGxlbWVu dGF0aW9ucyBvZgo+IERJVl9ST1VORF9DTE9TRVNUX1VMTCB0aHJvdWdob3V0IHRoZSBrZXJuZWwu ICBNb3ZlIHRoZSBpOTE1IG9uZSB0bwo+IGtlcm5lbC5oIHNvIHRoYXQgaXQgY2FuIGJlIHJldXNl ZC4KPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiBDYzog SmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogRGF2aWQgQWly bGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYXJyaWNrIEouIFdvbmcgPGRqd29uZ0B1cy5p Ym0uY29tPgo+IENjOiBHdWVudGVyIFJvZWNrIDxsaW51eEByb2Vjay11cy5uZXQ+Cj4gQ2M6IEFu ZHJldyBNb3J0b24gPGFrcG1AbGludXgtZm91bmRhdGlvbi5vcmc+Cj4gU2lnbmVkLW9mZi1ieTog SmF2aSBNZXJpbm8gPGphdmkubWVyaW5vQGFybS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rydi5oIHwgIDQgKy0tLQo+ICBpbmNsdWRlL2xpbnV4L2tlcm5lbC5oICAg ICAgICAgICB8IDExICsrKysrKysrKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5kZXgg ZWVmNzljY2QwYjdjLi4zNDZlMjhmZGQ3ZGQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYu aAo+IEBAIC0yOCw2ICsyOCw3IEBACj4gICNpbmNsdWRlIDxsaW51eC9hc3luYy5oPgo+ICAjaW5j bHVkZSA8bGludXgvaTJjLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9oZG1pLmg+Cj4gKyNpbmNsdWRl IDxsaW51eC9rZXJuZWwuaD4KSGkgSmF2aSwKClNtYWxsIHN1Z2dlc3Rpb24gLSBjYW4gd2UgaW5j bHVkZSB0aGUgaGVhZGVyIG9ubHkgd2hlcmUgbmVlZGVkID8KaTkxNS9pbnRlbF9wYW5lbC5jIHNl ZW1zIHRvIGJlIHRoZSBvbmx5IHVzZXIgb2YgRElWX1JPVU5EX0NMT1NFU1QKd2hpY2ggd2lsbCBu ZWVkIGFuIHVwZGF0ZS4KClNvbWV3aGF0IHRyaXZpYWwgcGljayBidXQgaXQgd2lsbCBwcmV2ZW50 IH40MCB1bm5lY2Vzc2FyeSBkaXZlcyBpbiBrZXJuZWwuaC4KCkNoZWVycywKRW1pbApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=