From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65652C3F2D1 for ; Fri, 28 Feb 2020 11:43:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 363EB246A0 for ; Fri, 28 Feb 2020 11:43:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iSF2h8Wj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 363EB246A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD5836F414; Fri, 28 Feb 2020 11:43:13 +0000 (UTC) Received: from mail-vk1-xa44.google.com (mail-vk1-xa44.google.com [IPv6:2607:f8b0:4864:20::a44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0E5156F414 for ; Fri, 28 Feb 2020 11:43:13 +0000 (UTC) Received: by mail-vk1-xa44.google.com with SMTP id y201so824002vky.8 for ; Fri, 28 Feb 2020 03:43:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E3m86ksh6JFmu3VknsoJDtsgFMq7t6y1ig8+9IFNC7o=; b=iSF2h8WjrzLANZPthBLsPysYtOFZhfyKXWP81wIHGIYPPblKRtSZFZYnBzBrzwlXpX TfjJpu33pPZ2lmrgcDY+N7Rz3SfDAMf+JDv6HBuR+mjc8ZaJXb9jqJJBD4a6u8Bh2RhW NDOXxq3DzG8hVN50y/7DLhPfvs00tSfsJCY3liPqQL3CjOFQhMy1Llomu7adDRRFXixL bGDlYoIhwLnu555tDCtStbgvoYHNt7Lq70gND463YPOLamodlkIZ6tvaIF6q5bsqo/Yx Z1SRuT4jIRpFrAGAOKZTAZZbZp7LA1NBFEcmP5coLxdhNjrbqv3yPXUMStoX693YsGxS j7lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E3m86ksh6JFmu3VknsoJDtsgFMq7t6y1ig8+9IFNC7o=; b=MP+JpXSAMZC3BUwJ6063PoinIDPIxuIu9ZHcnuYVMsgRNiEkYwyBVZ84S2zGm1a0Fx GpmBFjmfz5aT0Y3xIrbLbfbTrFLH0HGfft9JBYwZMkRGUH5oVRlVfPzcvS23Mje+N8ey cZAdvtzeHw9g6gO+LgpO3lzVe5tVKeh1B6z815JebWtcMfNDQwguEsCmt11/VfabvbZl dJ6GeN68Gb3Hgv2ML/mrG7LGh366+Mpq/hrVG4RTc1nmB7kvhooLUn7km4rxbJN5lyH/ hT/yLUJ7fk1S8NyhmsSj4IXwn19n02DH06QKZdXoQskA41XCd5bUhv3VHyK2DY40N+GV L/Hw== X-Gm-Message-State: ANhLgQ28kjzG6AevvdWJDMCEAdH626LT8fsvelE82tNSFtPu4DQs3pVY KDnu+0hs8h/8LzTWJgxHOIYhP+Fjd1AmMgBtkwc3NR+Xf2U= X-Google-Smtp-Source: ADFU+vsWwohEwX3ZoU6MtCUGU4exfDPSpM7FN+Re7PZw9MZ0+gIVfUZIBQzdcHS2j0Mhc3Uurt3uAGIFmtK9R/OqcyQ= X-Received: by 2002:a1f:c982:: with SMTP id z124mr2158683vkf.6.1582890192246; Fri, 28 Feb 2020 03:43:12 -0800 (PST) MIME-Version: 1.0 References: <20200224140726.1550689-1-bigeasy@linutronix.de> <20200224140726.1550689-2-bigeasy@linutronix.de> In-Reply-To: <20200224140726.1550689-2-bigeasy@linutronix.de> From: Emil Velikov Date: Fri, 28 Feb 2020 11:42:46 +0000 Message-ID: Subject: Re: [PATCH 2/2] drm/vmwgfx: Remove a few unused functions To: Sebastian Andrzej Siewior X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Hellstrom , VMware Graphics , Thomas Gleixner , ML dri-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sebastian, On Mon, 24 Feb 2020 at 16:55, Sebastian Andrzej Siewior wrote: > > I noticed that there is a prototype for vmw_fifo_ping_host_locked() but > no function. Then I looked further and noticed more functions which are > not used anymore or functions protoypes which remained after the > function was removed. > > Remove unused function (prototypes). > Seems like the last user was removed in 2015 with commit a278724aa23c ("drm/vmwgfx: Implement fbdev on kms v2"). With this patch, the section of "VGA registers" in struct vmw_private becomes dead code. IMHO it would make sense to also remove those with this patch. HTH Emil _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel