---------- Forwarded message --------- From: Debleena Sen Date: Wed, Mar 6, 2019 at 3:10 PM Subject: Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue To: Greg KH On Wed, Mar 6, 2019 at 2:45 PM Greg KH wrote: > On Tue, Mar 05, 2019 at 09:54:44PM +0530, Debleena Sen wrote: > > On Tue, Mar 5, 2019 at 1:10 PM Greg KH > wrote: > > > > > On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote: > > > > Break the line and match the indentation to remove the > > > > checkpatch.pl warning: > > > > WARNING: line over 80 characters > > > > > > > > Signed-off-by: Debleena Sen > > > > --- > > > > drivers/staging/pi433/rf69.c | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > What changed from the previous versions? That information always goes > > > below the --- line please. > > > > > > Please fix up and resend. > > > > > > thanks, > > > > > > greg k-h > > > > > > > I'm not able to find the commit. > > > > I tried using "git reset --mixed e19b9ce" but it shows an error: > > > > error: object e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9 is a blob, not a > > commit > > fatal: could not parse object 'e19b9ce' > > > > How can I recover it so that I can add the changes? > > I have no idea what you are trying to do here, sorry. Why are you > running 'git reset'? > > confused, > > greg k-h > In the tutorial it was written to edit a commit we need to use git reset --mixed So I thought to use that. It was my first patch probably. I already told you in another mail that there were like 16 warnings of the same type and same styling issue in pi433/rf69.c So in this patch I had fixed only one warning. Yesterday I sent another patch in which I've fixed the other 15 warnings. In the tutorial, it was written to edit a commit we need to use git reset --mixed So I thought to use that to add the version change log. But when I tried it, this error popped. I'm sorry. I think I've messed up.