From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932599Ab1LOQj7 (ORCPT ); Thu, 15 Dec 2011 11:39:59 -0500 Received: from mail-qw0-f46.google.com ([209.85.216.46]:55822 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798Ab1LOQj5 convert rfc822-to-8bit (ORCPT ); Thu, 15 Dec 2011 11:39:57 -0500 MIME-Version: 1.0 In-Reply-To: <4EEA1DA8.6040705@gmail.com> References: <1323876538-20406-1-git-send-email-robherring2@gmail.com> <1323876538-20406-4-git-send-email-robherring2@gmail.com> <20111215052512.GB21815@S2101-09.ap.freescale.net> <20111215055501.GC21815@S2101-09.ap.freescale.net> <4EE9F899.7010402@gmail.com> <4EE9FC99.6030905@gmail.com> <4EEA1DA8.6040705@gmail.com> From: Grant Likely Date: Thu, 15 Dec 2011 09:39:34 -0700 X-Google-Sender-Auth: xvmJZDQS1IUTtdCBsmWl6JCwLxk Message-ID: Subject: Re: [PATCH 3/9] irq: convert generic-chip to use irq_domain To: Rob Herring Cc: Shawn Guo , Kevin Hilman , Kukjin Kim , Tony Lindgren , Linus Walleij , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , Barry Song , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 15, 2011 at 9:17 AM, Rob Herring wrote: > On 12/15/2011 09:55 AM, Grant Likely wrote: >> On Thu, Dec 15, 2011 at 6:56 AM, Rob Herring wrote: >>> Shawn, >>> >>> On 12/15/2011 07:39 AM, Rob Herring wrote: >>>> On 12/14/2011 11:55 PM, Shawn Guo wrote: >>>>> On Thu, Dec 15, 2011 at 01:25:20PM +0800, Shawn Guo wrote: >>>>>> On Wed, Dec 14, 2011 at 09:28:52AM -0600, Rob Herring wrote: >>>>>>> From: Rob Herring >>>>>>> >>>>>>> Add irq domain support to irq generic-chip. This enables users of >>>>>>> generic-chip to support dynamic irq assignment needed for DT interrupt >>>>>>> binding. Users must be converted to use irq_data.hwirq for determining >>>>>>> local interrupt numbers rather than using the Linux irq number. >>>>>>> >>>>>>> irq_base is kept for now as there are a few users of it. Once they >>>>>>> are converted to use the irq domain, it can be removed. >>>>>>> >>>>>>> Signed-off-by: Rob Herring >>>>>>> Cc: Thomas Gleixner >>>>>>> --- >>>>>> >>>>>> Tested-by: Shawn Guo >>>>>> >>>>> Sorry, I have to take that tag back after I correct my test setup. >>>>> It does not work for imx5 TZIC case, because the following change >>>>> I suggested before is missed. >>>>> >>>>> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c >>>>> index eb763f7..2a2aac1 100644 >>>>> --- a/kernel/irq/irqdomain.c >>>>> +++ b/kernel/irq/irqdomain.c >>>>> @@ -39,7 +39,7 @@ void irq_domain_add(struct irq_domain *domain) >>>>>                         return; >>>>>                 } >>>>>                 d->domain = domain; >>>>> -               d->hwirq = hwirq; >>>>> +               d->hwirq = hwirq - domain->hwirq_base; >>>> >>>> This is a problem. It entirely defeats the point of hwirq_base and it >>>> would break the GIC. We need to fix this in the generic irq chip. >>>> >>> >>> I think I found a fix. Can you try 's/d->hwirq/(d->hwirq % 32)/' in >>> generic-chip.c. >> >> Ugh, but that hard codes an assumption that a domain cannot have more >> that 32 irqs. >> >> /me goes to dig into irq_domain code... > > No, it hard codes that generic irq chip is 32 interrupts at most which > is already the case. That's why the TZIC uses 5 generic irq chip instances. Oops, you're right. I wasn't paying close enough attention. Sorry for the noise. g. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 3/9] irq: convert generic-chip to use irq_domain Date: Thu, 15 Dec 2011 09:39:34 -0700 Message-ID: References: <1323876538-20406-1-git-send-email-robherring2@gmail.com> <1323876538-20406-4-git-send-email-robherring2@gmail.com> <20111215052512.GB21815@S2101-09.ap.freescale.net> <20111215055501.GC21815@S2101-09.ap.freescale.net> <4EE9F899.7010402@gmail.com> <4EE9FC99.6030905@gmail.com> <4EEA1DA8.6040705@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4EEA1DA8.6040705-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Rob Herring Cc: Kevin Hilman , Kukjin Kim , Tony Lindgren , Linus Walleij , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Barry Song , Thomas Gleixner List-Id: devicetree@vger.kernel.org On Thu, Dec 15, 2011 at 9:17 AM, Rob Herring wrote: > On 12/15/2011 09:55 AM, Grant Likely wrote: >> On Thu, Dec 15, 2011 at 6:56 AM, Rob Herring wro= te: >>> Shawn, >>> >>> On 12/15/2011 07:39 AM, Rob Herring wrote: >>>> On 12/14/2011 11:55 PM, Shawn Guo wrote: >>>>> On Thu, Dec 15, 2011 at 01:25:20PM +0800, Shawn Guo wrote: >>>>>> On Wed, Dec 14, 2011 at 09:28:52AM -0600, Rob Herring wrote: >>>>>>> From: Rob Herring >>>>>>> >>>>>>> Add irq domain support to irq generic-chip. This enables users of >>>>>>> generic-chip to support dynamic irq assignment needed for DT interr= upt >>>>>>> binding. Users must be converted to use irq_data.hwirq for determin= ing >>>>>>> local interrupt numbers rather than using the Linux irq number. >>>>>>> >>>>>>> irq_base is kept for now as there are a few users of it. Once they >>>>>>> are converted to use the irq domain, it can be removed. >>>>>>> >>>>>>> Signed-off-by: Rob Herring >>>>>>> Cc: Thomas Gleixner >>>>>>> --- >>>>>> >>>>>> Tested-by: Shawn Guo >>>>>> >>>>> Sorry, I have to take that tag back after I correct my test setup. >>>>> It does not work for imx5 TZIC case, because the following change >>>>> I suggested before is missed. >>>>> >>>>> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c >>>>> index eb763f7..2a2aac1 100644 >>>>> --- a/kernel/irq/irqdomain.c >>>>> +++ b/kernel/irq/irqdomain.c >>>>> @@ -39,7 +39,7 @@ void irq_domain_add(struct irq_domain *domain) >>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return; >>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 } >>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 d->domain =3D domain; >>>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 d->hwirq =3D hwirq; >>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 d->hwirq =3D hwirq - domain->hwirq_base; >>>> >>>> This is a problem. It entirely defeats the point of hwirq_base and it >>>> would break the GIC. We need to fix this in the generic irq chip. >>>> >>> >>> I think I found a fix. Can you try 's/d->hwirq/(d->hwirq % 32)/' in >>> generic-chip.c. >> >> Ugh, but that hard codes an assumption that a domain cannot have more >> that 32 irqs. >> >> /me goes to dig into irq_domain code... > > No, it hard codes that generic irq chip is 32 interrupts at most which > is already the case. That's why the TZIC uses 5 generic irq chip instance= s. Oops, you're right. I wasn't paying close enough attention. Sorry for the noise. g. From mboxrd@z Thu Jan 1 00:00:00 1970 From: grant.likely@secretlab.ca (Grant Likely) Date: Thu, 15 Dec 2011 09:39:34 -0700 Subject: [PATCH 3/9] irq: convert generic-chip to use irq_domain In-Reply-To: <4EEA1DA8.6040705@gmail.com> References: <1323876538-20406-1-git-send-email-robherring2@gmail.com> <1323876538-20406-4-git-send-email-robherring2@gmail.com> <20111215052512.GB21815@S2101-09.ap.freescale.net> <20111215055501.GC21815@S2101-09.ap.freescale.net> <4EE9F899.7010402@gmail.com> <4EE9FC99.6030905@gmail.com> <4EEA1DA8.6040705@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Dec 15, 2011 at 9:17 AM, Rob Herring wrote: > On 12/15/2011 09:55 AM, Grant Likely wrote: >> On Thu, Dec 15, 2011 at 6:56 AM, Rob Herring wrote: >>> Shawn, >>> >>> On 12/15/2011 07:39 AM, Rob Herring wrote: >>>> On 12/14/2011 11:55 PM, Shawn Guo wrote: >>>>> On Thu, Dec 15, 2011 at 01:25:20PM +0800, Shawn Guo wrote: >>>>>> On Wed, Dec 14, 2011 at 09:28:52AM -0600, Rob Herring wrote: >>>>>>> From: Rob Herring >>>>>>> >>>>>>> Add irq domain support to irq generic-chip. This enables users of >>>>>>> generic-chip to support dynamic irq assignment needed for DT interrupt >>>>>>> binding. Users must be converted to use irq_data.hwirq for determining >>>>>>> local interrupt numbers rather than using the Linux irq number. >>>>>>> >>>>>>> irq_base is kept for now as there are a few users of it. Once they >>>>>>> are converted to use the irq domain, it can be removed. >>>>>>> >>>>>>> Signed-off-by: Rob Herring >>>>>>> Cc: Thomas Gleixner >>>>>>> --- >>>>>> >>>>>> Tested-by: Shawn Guo >>>>>> >>>>> Sorry, I have to take that tag back after I correct my test setup. >>>>> It does not work for imx5 TZIC case, because the following change >>>>> I suggested before is missed. >>>>> >>>>> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c >>>>> index eb763f7..2a2aac1 100644 >>>>> --- a/kernel/irq/irqdomain.c >>>>> +++ b/kernel/irq/irqdomain.c >>>>> @@ -39,7 +39,7 @@ void irq_domain_add(struct irq_domain *domain) >>>>> ? ? ? ? ? ? ? ? ? ? ? ? return; >>>>> ? ? ? ? ? ? ? ? } >>>>> ? ? ? ? ? ? ? ? d->domain = domain; >>>>> - ? ? ? ? ? ? ? d->hwirq = hwirq; >>>>> + ? ? ? ? ? ? ? d->hwirq = hwirq - domain->hwirq_base; >>>> >>>> This is a problem. It entirely defeats the point of hwirq_base and it >>>> would break the GIC. We need to fix this in the generic irq chip. >>>> >>> >>> I think I found a fix. Can you try 's/d->hwirq/(d->hwirq % 32)/' in >>> generic-chip.c. >> >> Ugh, but that hard codes an assumption that a domain cannot have more >> that 32 irqs. >> >> /me goes to dig into irq_domain code... > > No, it hard codes that generic irq chip is 32 interrupts at most which > is already the case. That's why the TZIC uses 5 generic irq chip instances. Oops, you're right. I wasn't paying close enough attention. Sorry for the noise. g.