All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: Defer failed gpio requests by default
Date: Mon, 9 Jul 2012 22:54:41 +0100	[thread overview]
Message-ID: <CACxGe6uJUTtcmq2voo0yGQZ-OxiOK-0OEJ343qZZMDTMQc6veg@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdZ=6yP58DvY287h9tL1pL_oQk8JfjvYJhc80==yvzz=TA@mail.gmail.com>

On Mon, Jul 9, 2012 at 9:31 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Jul 9, 2012 at 1:22 PM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
>
>> Since users must be explicitly provided with a GPIO number in order to
>> request one the overwhelmingly common case for failing to request will
>> be that the required GPIO driver has not yet registered and we should
>> therefore defer until it has registered.
>>
>> In order to avoid having to code this logic in individual drivers have
>> gpio_request() return -EPROBE_DEFER when failing to look up the GPIO.
>> Drivers which don't want this behaviour can override it if they desire.
>>
>> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> While this makes perfect sense to me I would *really* like to
> wait for Grants opinion on this one patch, him having devised
> the deferral and being GPIO maintainer.
>
> Is any deferral of this deferral mechanism causing you to
> defer important work right now?

I'm fine with this patch, but the patch that adds the twizzling of the
dpm_list when probing needs some tweaking, and this patch must be
applied after that one.  I'll go and reply to that patch now (and cc
you if you're not already).

g.

  reply	other threads:[~2012-07-09 21:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-09 11:22 [PATCH] gpiolib: Defer failed gpio requests by default Mark Brown
2012-07-09 20:31 ` Linus Walleij
2012-07-09 21:54   ` Grant Likely [this message]
2012-07-10 11:07     ` Mark Brown
2012-07-17 18:20 ` Linus Walleij
  -- strict thread matches above, loose matches on Subject: below --
2012-05-02 11:49 Mark Brown
2012-05-18  4:32 ` Grant Likely
2012-05-18  8:45   ` Mark Brown
2012-05-18 16:35   ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACxGe6uJUTtcmq2voo0yGQZ-OxiOK-0OEJ343qZZMDTMQc6veg@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linus.walleij@linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.