From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6767AC07E9C for ; Tue, 6 Jul 2021 03:04:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A47D61977 for ; Tue, 6 Jul 2021 03:04:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229957AbhGFDHM (ORCPT ); Mon, 5 Jul 2021 23:07:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229879AbhGFDHJ (ORCPT ); Mon, 5 Jul 2021 23:07:09 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57A2CC06175F for ; Mon, 5 Jul 2021 20:04:30 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id m1so25945156edq.8 for ; Mon, 05 Jul 2021 20:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LCgUQ9YXkJh4ceT+VmUThz5I8QlmLbs1I7Jug0v7X9c=; b=AniVf1hg8E84bf88GbqvkjR+BefQ1f0lgfPF37iHtxf/YNkU0AyXPnMQYAxXb02mbo G48TrGfyovbNsFXOaWMWb/wyYJ2otEbO4ALwFWjEp+ou6S1UnsrushF1eZx06kGNzJN8 ZE+sG3ukhj23G3+11XF15U8C53r0c8X3EEc4Ok4kOBRxqvzy8189Ucu76sgW34Wbm8+X cTKFYWmWxoprLOtkLuVBPTW79tw5zhQYEEPwKl+lmcbOagdDirWCGWdkJ6EIa0dQXVy8 dgnLZv4WULOteK3YLraIZY9wXPfWdUjgUnwLaGWun0yx5ionzoeg2EP/vsiH019ipKeh +bSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LCgUQ9YXkJh4ceT+VmUThz5I8QlmLbs1I7Jug0v7X9c=; b=NFHd997BWKS+RPIyG1UxTnzVghik1umXanTHtcK/wUlF9b0WPJ5LfFLAIqhMI/Gbdt tgjWKvHkSf8pArb31OjWu2PGjTRs8RsKXqBXqExJdkcA2+y4pJLC6iSMnWsToOj8WBaT QdslswWKkTMPW5/RBwy9nZ3bZ1FciT60MSIBXKj2rDhkDX0GyxeXBeiijQuc5clJPu4T YEM5vCzhkAObzXAamyehjZm1rIaypFsrr7APLlhloJyNk850VC8/+DL6Ei9F0xSstndU Uv3wtmIjKETN5sIyjLdXWjxcF9uqT6XLeFs7SO0bDHvrCnCrl+7q6Cvdgfy6SiDD6V+A Vlyg== X-Gm-Message-State: AOAM533apUaIOvtcTAJAt+rtdwk9BE+bY2QTZn8+rME9NspSMtWt5kZn 4ziJbeO0porLzw5wAKyBC7pM8VEpS0mdPcQi+3ZK X-Google-Smtp-Source: ABdhPJxK8aaodUmVuDEfTR7oD0ZVR0H0WNfCSx96KkTtw1Uj+YwvZnEo/lcejGfXLnkvlfTU0w/nA3UorXy0nyt0lC8= X-Received: by 2002:a50:ff01:: with SMTP id a1mr19688860edu.253.1625540668739; Mon, 05 Jul 2021 20:04:28 -0700 (PDT) MIME-Version: 1.0 References: <20210615141331.407-1-xieyongji@bytedance.com> <20210615141331.407-11-xieyongji@bytedance.com> <8320d26d-6637-85c6-8773-49553dfa502d@redhat.com> In-Reply-To: From: Yongji Xie Date: Tue, 6 Jul 2021 11:04:18 +0800 Message-ID: Subject: Re: [PATCH v8 10/10] Documentation: Add documentation for VDUSE To: Stefan Hajnoczi Cc: Jason Wang , "Michael S. Tsirkin" , Stefano Garzarella , Parav Pandit , Christoph Hellwig , Christian Brauner , Randy Dunlap , Matthew Wilcox , Al Viro , Jens Axboe , bcrl@kvack.org, Jonathan Corbet , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Dan Carpenter , joro@8bytes.org, Greg KH , songmuchun@bytedance.com, virtualization , netdev@vger.kernel.org, kvm , linux-fsdevel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 5, 2021 at 8:50 PM Stefan Hajnoczi wrote: > > On Mon, Jul 05, 2021 at 11:36:15AM +0800, Jason Wang wrote: > > > > =E5=9C=A8 2021/7/4 =E4=B8=8B=E5=8D=885:49, Yongji Xie =E5=86=99=E9=81= =93: > > > > > OK, I get you now. Since the VIRTIO specification says "Device > > > > > configuration space is generally used for rarely-changing or > > > > > initialization-time parameters". I assume the VDUSE_DEV_SET_CONFI= G > > > > > ioctl should not be called frequently. > > > > The spec uses MUST and other terms to define the precise requiremen= ts. > > > > Here the language (especially the word "generally") is weaker and m= eans > > > > there may be exceptions. > > > > > > > > Another type of access that doesn't work with the VDUSE_DEV_SET_CON= FIG > > > > approach is reads that have side-effects. For example, imagine a fi= eld > > > > containing an error code if the device encounters a problem unrelat= ed to > > > > a specific virtqueue request. Reading from this field resets the er= ror > > > > code to 0, saving the driver an extra configuration space write acc= ess > > > > and possibly race conditions. It isn't possible to implement those > > > > semantics suing VDUSE_DEV_SET_CONFIG. It's another corner case, but= it > > > > makes me think that the interface does not allow full VIRTIO semant= ics. > > > > > > Note that though you're correct, my understanding is that config space = is > > not suitable for this kind of error propagating. And it would be very h= ard > > to implement such kind of semantic in some transports. Virtqueue shoul= d be > > much better. As Yong Ji quoted, the config space is used for > > "rarely-changing or intialization-time parameters". > > > > > > > Agreed. I will use VDUSE_DEV_GET_CONFIG in the next version. And to > > > handle the message failure, I'm going to add a return value to > > > virtio_config_ops.get() and virtio_cread_* API so that the error can > > > be propagated to the virtio device driver. Then the virtio-blk device > > > driver can be modified to handle that. > > > > > > Jason and Stefan, what do you think of this way? > > Why does VDUSE_DEV_GET_CONFIG need to support an error return value? > We add a timeout and return error in case userspace never replies to the message. > The VIRTIO spec provides no way for the device to report errors from > config space accesses. > > The QEMU virtio-pci implementation returns -1 from invalid > virtio_config_read*() and silently discards virtio_config_write*() > accesses. > > VDUSE can take the same approach with > VDUSE_DEV_GET_CONFIG/VDUSE_DEV_SET_CONFIG. > I noticed that virtio_config_read*() only returns -1 when we access a invalid field. But in the VDUSE case, VDUSE_DEV_GET_CONFIG might fail when we access a valid field. Not sure if it's ok to silently ignore this kind of error. Thanks, Yongji From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3874C07E99 for ; Tue, 6 Jul 2021 03:04:36 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F17B61977 for ; Tue, 6 Jul 2021 03:04:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F17B61977 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id DB58D4029A; Tue, 6 Jul 2021 03:04:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I7sNcqej9l1O; Tue, 6 Jul 2021 03:04:35 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id B919E400DC; Tue, 6 Jul 2021 03:04:34 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8210FC0010; Tue, 6 Jul 2021 03:04:34 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 95BCEC0010 for ; Tue, 6 Jul 2021 03:04:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 6B99540122 for ; Tue, 6 Jul 2021 03:04:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VVqBpO7W_add for ; Tue, 6 Jul 2021 03:04:31 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by smtp2.osuosl.org (Postfix) with ESMTPS id EBB04400DC for ; Tue, 6 Jul 2021 03:04:30 +0000 (UTC) Received: by mail-ed1-x532.google.com with SMTP id j11so25931834edq.6 for ; Mon, 05 Jul 2021 20:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LCgUQ9YXkJh4ceT+VmUThz5I8QlmLbs1I7Jug0v7X9c=; b=AniVf1hg8E84bf88GbqvkjR+BefQ1f0lgfPF37iHtxf/YNkU0AyXPnMQYAxXb02mbo G48TrGfyovbNsFXOaWMWb/wyYJ2otEbO4ALwFWjEp+ou6S1UnsrushF1eZx06kGNzJN8 ZE+sG3ukhj23G3+11XF15U8C53r0c8X3EEc4Ok4kOBRxqvzy8189Ucu76sgW34Wbm8+X cTKFYWmWxoprLOtkLuVBPTW79tw5zhQYEEPwKl+lmcbOagdDirWCGWdkJ6EIa0dQXVy8 dgnLZv4WULOteK3YLraIZY9wXPfWdUjgUnwLaGWun0yx5ionzoeg2EP/vsiH019ipKeh +bSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LCgUQ9YXkJh4ceT+VmUThz5I8QlmLbs1I7Jug0v7X9c=; b=GOrnvPpbacwsxQTdn67sF8iO6gR1HUhFRS1yJbPePcrvnvIGVYqFAboDN3BKqpwmyB TgP8fUkqzQcr8PbeqgZNiSOrTbW8E6cSX3ZIpym1NcOV19ikbJDumPpsITcvtMeGpSY1 SCgP8WWsYh7tGSBDHqAbVhnZdckQxwyBe3TnM5JjTqHMYkcYTHSjFMRYCHnn7Zyst9UP YPco3/gQNmFa0dAkys7+vZaBSy/C6Qavcl5zstHO/aXWus/czuvvNm+cWzoqMpV+1pUu g/6ScNCqcntaNbHi4KhEBOlU5LTFOWOkAbkDmeh4pFDBAsXMGdUPP0wNLrDik8JwIKv0 sYng== X-Gm-Message-State: AOAM533iTbIs91PJsgDI7CZTt6pYD0SS4//qAv4v1U1BIUz0kgNCGXT7 wwP/AgAkB7UILMBcoTx7XF4PSl+AX0pslPXQW+sM X-Google-Smtp-Source: ABdhPJxK8aaodUmVuDEfTR7oD0ZVR0H0WNfCSx96KkTtw1Uj+YwvZnEo/lcejGfXLnkvlfTU0w/nA3UorXy0nyt0lC8= X-Received: by 2002:a50:ff01:: with SMTP id a1mr19688860edu.253.1625540668739; Mon, 05 Jul 2021 20:04:28 -0700 (PDT) MIME-Version: 1.0 References: <20210615141331.407-1-xieyongji@bytedance.com> <20210615141331.407-11-xieyongji@bytedance.com> <8320d26d-6637-85c6-8773-49553dfa502d@redhat.com> In-Reply-To: From: Yongji Xie Date: Tue, 6 Jul 2021 11:04:18 +0800 Message-ID: Subject: Re: [PATCH v8 10/10] Documentation: Add documentation for VDUSE To: Stefan Hajnoczi Cc: kvm , "Michael S. Tsirkin" , Jason Wang , virtualization , Christian Brauner , Jonathan Corbet , Matthew Wilcox , Christoph Hellwig , Dan Carpenter , Stefano Garzarella , Al Viro , songmuchun@bytedance.com, Jens Axboe , Greg KH , Randy Dunlap , linux-kernel , iommu@lists.linux-foundation.org, bcrl@kvack.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, =?UTF-8?Q?Mika_Penttil=C3=A4?= X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gTW9uLCBKdWwgNSwgMjAyMSBhdCA4OjUwIFBNIFN0ZWZhbiBIYWpub2N6aSA8c3RlZmFuaGFA cmVkaGF0LmNvbT4gd3JvdGU6Cj4KPiBPbiBNb24sIEp1bCAwNSwgMjAyMSBhdCAxMTozNjoxNUFN ICswODAwLCBKYXNvbiBXYW5nIHdyb3RlOgo+ID4KPiA+IOWcqCAyMDIxLzcvNCDkuIvljYg1OjQ5 LCBZb25namkgWGllIOWGmemBkzoKPiA+ID4gPiA+IE9LLCBJIGdldCB5b3Ugbm93LiBTaW5jZSB0 aGUgVklSVElPIHNwZWNpZmljYXRpb24gc2F5cyAiRGV2aWNlCj4gPiA+ID4gPiBjb25maWd1cmF0 aW9uIHNwYWNlIGlzIGdlbmVyYWxseSB1c2VkIGZvciByYXJlbHktY2hhbmdpbmcgb3IKPiA+ID4g PiA+IGluaXRpYWxpemF0aW9uLXRpbWUgcGFyYW1ldGVycyIuIEkgYXNzdW1lIHRoZSBWRFVTRV9E RVZfU0VUX0NPTkZJRwo+ID4gPiA+ID4gaW9jdGwgc2hvdWxkIG5vdCBiZSBjYWxsZWQgZnJlcXVl bnRseS4KPiA+ID4gPiBUaGUgc3BlYyB1c2VzIE1VU1QgYW5kIG90aGVyIHRlcm1zIHRvIGRlZmlu ZSB0aGUgcHJlY2lzZSByZXF1aXJlbWVudHMuCj4gPiA+ID4gSGVyZSB0aGUgbGFuZ3VhZ2UgKGVz cGVjaWFsbHkgdGhlIHdvcmQgImdlbmVyYWxseSIpIGlzIHdlYWtlciBhbmQgbWVhbnMKPiA+ID4g PiB0aGVyZSBtYXkgYmUgZXhjZXB0aW9ucy4KPiA+ID4gPgo+ID4gPiA+IEFub3RoZXIgdHlwZSBv ZiBhY2Nlc3MgdGhhdCBkb2Vzbid0IHdvcmsgd2l0aCB0aGUgVkRVU0VfREVWX1NFVF9DT05GSUcK PiA+ID4gPiBhcHByb2FjaCBpcyByZWFkcyB0aGF0IGhhdmUgc2lkZS1lZmZlY3RzLiBGb3IgZXhh bXBsZSwgaW1hZ2luZSBhIGZpZWxkCj4gPiA+ID4gY29udGFpbmluZyBhbiBlcnJvciBjb2RlIGlm IHRoZSBkZXZpY2UgZW5jb3VudGVycyBhIHByb2JsZW0gdW5yZWxhdGVkIHRvCj4gPiA+ID4gYSBz cGVjaWZpYyB2aXJ0cXVldWUgcmVxdWVzdC4gUmVhZGluZyBmcm9tIHRoaXMgZmllbGQgcmVzZXRz IHRoZSBlcnJvcgo+ID4gPiA+IGNvZGUgdG8gMCwgc2F2aW5nIHRoZSBkcml2ZXIgYW4gZXh0cmEg Y29uZmlndXJhdGlvbiBzcGFjZSB3cml0ZSBhY2Nlc3MKPiA+ID4gPiBhbmQgcG9zc2libHkgcmFj ZSBjb25kaXRpb25zLiBJdCBpc24ndCBwb3NzaWJsZSB0byBpbXBsZW1lbnQgdGhvc2UKPiA+ID4g PiBzZW1hbnRpY3Mgc3VpbmcgVkRVU0VfREVWX1NFVF9DT05GSUcuIEl0J3MgYW5vdGhlciBjb3Ju ZXIgY2FzZSwgYnV0IGl0Cj4gPiA+ID4gbWFrZXMgbWUgdGhpbmsgdGhhdCB0aGUgaW50ZXJmYWNl IGRvZXMgbm90IGFsbG93IGZ1bGwgVklSVElPIHNlbWFudGljcy4KPiA+Cj4gPgo+ID4gTm90ZSB0 aGF0IHRob3VnaCB5b3UncmUgY29ycmVjdCwgbXkgdW5kZXJzdGFuZGluZyBpcyB0aGF0IGNvbmZp ZyBzcGFjZSBpcwo+ID4gbm90IHN1aXRhYmxlIGZvciB0aGlzIGtpbmQgb2YgZXJyb3IgcHJvcGFn YXRpbmcuIEFuZCBpdCB3b3VsZCBiZSB2ZXJ5IGhhcmQKPiA+IHRvIGltcGxlbWVudCBzdWNoIGtp bmQgb2Ygc2VtYW50aWMgaW4gc29tZSB0cmFuc3BvcnRzLiAgVmlydHF1ZXVlIHNob3VsZCBiZQo+ ID4gbXVjaCBiZXR0ZXIuIEFzIFlvbmcgSmkgcXVvdGVkLCB0aGUgY29uZmlnIHNwYWNlIGlzIHVz ZWQgZm9yCj4gPiAicmFyZWx5LWNoYW5naW5nIG9yIGludGlhbGl6YXRpb24tdGltZSBwYXJhbWV0 ZXJzIi4KPiA+Cj4gPgo+ID4gPiBBZ3JlZWQuIEkgd2lsbCB1c2UgVkRVU0VfREVWX0dFVF9DT05G SUcgaW4gdGhlIG5leHQgdmVyc2lvbi4gQW5kIHRvCj4gPiA+IGhhbmRsZSB0aGUgbWVzc2FnZSBm YWlsdXJlLCBJJ20gZ29pbmcgdG8gYWRkIGEgcmV0dXJuIHZhbHVlIHRvCj4gPiA+IHZpcnRpb19j b25maWdfb3BzLmdldCgpIGFuZCB2aXJ0aW9fY3JlYWRfKiBBUEkgc28gdGhhdCB0aGUgZXJyb3Ig Y2FuCj4gPiA+IGJlIHByb3BhZ2F0ZWQgdG8gdGhlIHZpcnRpbyBkZXZpY2UgZHJpdmVyLiBUaGVu IHRoZSB2aXJ0aW8tYmxrIGRldmljZQo+ID4gPiBkcml2ZXIgY2FuIGJlIG1vZGlmaWVkIHRvIGhh bmRsZSB0aGF0Lgo+ID4gPgo+ID4gPiBKYXNvbiBhbmQgU3RlZmFuLCB3aGF0IGRvIHlvdSB0aGlu ayBvZiB0aGlzIHdheT8KPgo+IFdoeSBkb2VzIFZEVVNFX0RFVl9HRVRfQ09ORklHIG5lZWQgdG8g c3VwcG9ydCBhbiBlcnJvciByZXR1cm4gdmFsdWU/Cj4KCldlIGFkZCBhIHRpbWVvdXQgYW5kIHJl dHVybiBlcnJvciBpbiBjYXNlIHVzZXJzcGFjZSBuZXZlciByZXBsaWVzIHRvCnRoZSBtZXNzYWdl LgoKPiBUaGUgVklSVElPIHNwZWMgcHJvdmlkZXMgbm8gd2F5IGZvciB0aGUgZGV2aWNlIHRvIHJl cG9ydCBlcnJvcnMgZnJvbQo+IGNvbmZpZyBzcGFjZSBhY2Nlc3Nlcy4KPgo+IFRoZSBRRU1VIHZp cnRpby1wY2kgaW1wbGVtZW50YXRpb24gcmV0dXJucyAtMSBmcm9tIGludmFsaWQKPiB2aXJ0aW9f Y29uZmlnX3JlYWQqKCkgYW5kIHNpbGVudGx5IGRpc2NhcmRzIHZpcnRpb19jb25maWdfd3JpdGUq KCkKPiBhY2Nlc3Nlcy4KPgo+IFZEVVNFIGNhbiB0YWtlIHRoZSBzYW1lIGFwcHJvYWNoIHdpdGgK PiBWRFVTRV9ERVZfR0VUX0NPTkZJRy9WRFVTRV9ERVZfU0VUX0NPTkZJRy4KPgoKSSBub3RpY2Vk IHRoYXQgdmlydGlvX2NvbmZpZ19yZWFkKigpIG9ubHkgcmV0dXJucyAtMSB3aGVuIHdlIGFjY2Vz cyBhCmludmFsaWQgZmllbGQuIEJ1dCBpbiB0aGUgVkRVU0UgY2FzZSwgVkRVU0VfREVWX0dFVF9D T05GSUcgbWlnaHQgZmFpbAp3aGVuIHdlIGFjY2VzcyBhIHZhbGlkIGZpZWxkLiBOb3Qgc3VyZSBp ZiBpdCdzIG9rIHRvIHNpbGVudGx5IGlnbm9yZQp0aGlzIGtpbmQgb2YgZXJyb3IuCgpUaGFua3Ms CllvbmdqaQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpp b21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6 Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vaW9tbXU=