All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yongji Xie <xieyongji@bytedance.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"Tiwei Bie" <tiwei.bie@intel.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Eugenio Pérez" <eperezma@redhat.com>, kvm <kvm@vger.kernel.org>,
	virtualization <virtualization@lists.linux-foundation.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2 v4] vdpa: check that offsets are within bounds
Date: Thu, 9 Dec 2021 10:35:43 +0800	[thread overview]
Message-ID: <CACycT3un+oTFoOrYiegOrpRLw2RFyU0j4OBrVBhzGZJqU9Z1sA@mail.gmail.com> (raw)
In-Reply-To: <20211208103337.GA4047@kili>

On Wed, Dec 8, 2021 at 6:33 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> In this function "c->off" is a u32 and "size" is a long.  On 64bit systems
> if "c->off" is greater than "size" then "size - c->off" is a negative and
> we always return -E2BIG.  But on 32bit systems the subtraction is type
> promoted to a high positive u32 value and basically any "c->len" is
> accepted.
>
> Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend")
> Reported-by: Xie Yongji <xieyongji@bytedance.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Xie Yongji <xieyongji@bytedance.com>

  parent reply	other threads:[~2021-12-09  2:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08 10:33 [PATCH 1/2 v4] vduse: fix memory corruption in vduse_dev_ioctl() Dan Carpenter
2021-12-08 10:33 ` Dan Carpenter
2021-12-08 10:33 ` [PATCH 2/2 v4] vdpa: check that offsets are within bounds Dan Carpenter
2021-12-08 10:33   ` Dan Carpenter
2021-12-09  2:12   ` Jason Wang
2021-12-09  2:12     ` Jason Wang
2021-12-09  2:35   ` Yongji Xie [this message]
2021-12-09  2:12 ` [PATCH 1/2 v4] vduse: fix memory corruption in vduse_dev_ioctl() Jason Wang
2021-12-09  2:12   ` Jason Wang
2021-12-09  2:34 ` Yongji Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACycT3un+oTFoOrYiegOrpRLw2RFyU0j4OBrVBhzGZJqU9Z1sA@mail.gmail.com \
    --to=xieyongji@bytedance.com \
    --cc=dan.carpenter@oracle.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=tiwei.bie@intel.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.