All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yongji Xie <xieyongji@bytedance.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	virtualization <virtualization@lists.linux-foundation.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] vdpa: potential uninitialized return in vhost_vdpa_va_map()
Date: Tue, 7 Sep 2021 16:41:35 +0800	[thread overview]
Message-ID: <CACycT3vROtG7_=zpDtZ0KDO9MgtbA_kBUrbBnLXWe0q9gtOnmA@mail.gmail.com> (raw)
In-Reply-To: <20210907073253.GB18254@kili>

On Tue, Sep 7, 2021 at 3:33 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The concern here is that "ret" can be uninitialized if we hit the
> "goto next" condition on every iteration through the loop.
>
> Fixes: 41ba1b5f9d4b ("vdpa: Support transferring virtual addressing during DMA mapping")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/vhost/vdpa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Xie Yongji <xieyongji@bytedance.com>

  reply	other threads:[~2021-09-07  8:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07  7:32 [PATCH] vdpa: potential uninitialized return in vhost_vdpa_va_map() Dan Carpenter
2021-09-07  7:32 ` Dan Carpenter
2021-09-07  8:41 ` Yongji Xie [this message]
2021-09-07  9:07 ` Jason Wang
2021-09-07  9:07   ` Jason Wang
2021-09-07  9:28 ` Stefano Garzarella
2021-09-07  9:28   ` Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACycT3vROtG7_=zpDtZ0KDO9MgtbA_kBUrbBnLXWe0q9gtOnmA@mail.gmail.com' \
    --to=xieyongji@bytedance.com \
    --cc=dan.carpenter@oracle.com \
    --cc=jasowang@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.