All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wenwei Tao <ww.tao0320@gmail.com>
To: "Matias Bjørling" <m@bjorling.me>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/3] lightnvm: check mm before use
Date: Fri, 4 Dec 2015 16:02:51 +0800	[thread overview]
Message-ID: <CACygaLBgQbm_dth3aSZs=5dp8N+7t7jpWF+1ufEY9NCnFY5G-A@mail.gmail.com> (raw)
In-Reply-To: <1449058583-27940-1-git-send-email-m@bjorling.me>

2015-12-02 20:16 GMT+08:00 Matias Bjørling <m@bjorling.me>:
> The core can initialize I/Os before a media manager is registered with
> the lightnvm subsystem. Make sure that we don't call the media manager
> prematurely.
>
> Signed-off-by: Matias Bjørling <m@bjorling.me>
> ---
>  drivers/nvme/host/lightnvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index 06c3364..762c9a7 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -455,7 +455,7 @@ static void nvme_nvm_end_io(struct request *rq, int error)
>         struct nvm_rq *rqd = rq->end_io_data;
>         struct nvm_dev *dev = rqd->dev;
>
> -       if (dev->mt->end_io(rqd, error))
> +       if (dev->mt && dev->mt->end_io(rqd, error))

Is there any chance core can initialize IOs on device without register
with a media manger ?
In my understanding core cannot create target on device without a
media manger, if core doesn't have a target how can core initialize
IOs on these devices?  If I'm wrong about this, please correct me.

  parent reply	other threads:[~2015-12-04  8:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 12:16 [PATCH RFC 1/3] lightnvm: check mm before use Matias Bjørling
2015-12-02 12:16 ` [PATCH RFC 2/3] lightnvm: comments on constants Matias Bjørling
2015-12-02 12:16 ` [PATCH RFC 3/3] lightnvm: fix media mgr registration Matias Bjørling
2015-12-04  8:40   ` Wenwei Tao
2015-12-04 10:46     ` Matias Bjørling
2015-12-04  8:02 ` Wenwei Tao [this message]
2015-12-04  9:51   ` [PATCH RFC 1/3] lightnvm: check mm before use Matias Bjørling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACygaLBgQbm_dth3aSZs=5dp8N+7t7jpWF+1ufEY9NCnFY5G-A@mail.gmail.com' \
    --to=ww.tao0320@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m@bjorling.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.