From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alejandro Lucero Subject: Re: [PATCH v2 1/6] mem: add function for checking memsegs IOVAs addresses Date: Fri, 5 Oct 2018 13:19:43 +0100 Message-ID: References: <1538741212-7922-1-git-send-email-alejandro.lucero@netronome.com> <1538741212-7922-2-git-send-email-alejandro.lucero@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: dev To: "Burakov, Anatoly" Return-path: Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id 69A9E23D for ; Fri, 5 Oct 2018 14:19:55 +0200 (CEST) Received: by mail-oi1-f196.google.com with SMTP id u74-v6so10176505oia.11 for ; Fri, 05 Oct 2018 05:19:55 -0700 (PDT) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 5, 2018 at 1:15 PM Burakov, Anatoly wrote: > On 05-Oct-18 1:06 PM, Alejandro Lucero wrote: > > A device can suffer addressing limitations. This function checks > > memsegs have iovas within the supported range based on dma mask. > > > > PMDs should use this function during initialization if device > > suffers addressing limitations, returning an error if this function > > returns memsegs out of range. > > > > Another usage is for emulated IOMMU hardware with addressing > > limitations. > > > > It is necessary to save the most restricted dma mask for checking out > > memory allocated dynamically after initialization. > > > > Signed-off-by: Alejandro Lucero > > --- > > Reviewed-by: Anatoly Burakov > > Thanks Anatoly. I have just noticed I did not remove the previous keeping of the dma mask. I will send another version just with this change and will add you review if you are happy if I do so. > -- > Thanks, > Anatoly >