From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alejandro Lucero <alejandro.lucero@netronome.com>
Subject: Re: [PATCH] drivers/net: document missing speed
 capabilities feature
Date: Tue, 16 May 2017 11:17:11 +0100
Message-ID: <CAD+H990j8=sy9aGt3ibKvmaH9xs_+u38Z45u3R661gCbj8+kiw@mail.gmail.com>
References: <20170510131053.75843-1-ferruh.yigit@intel.com>
 <17406199.hqjMraK9H2@xps>
 <CAD+H993bAMOFMOBqro3GnQjj-8FLyj4OswkXYY77mjK=1=aLxQ@mail.gmail.com>
 <3454007.3ZDP6eXIq0@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
 Shepard Siegel <shepard.siegel@atomicrules.com>,
 Ed Czeck <ed.czeck@atomicrules.com>,
 John Miller <john.miller@atomicrules.com>,
 John McNamara <john.mcnamara@intel.com>,
 Harish Patil <harish.patil@cavium.com>, Rasesh Mody <rasesh.mody@cavium.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>,
 Guy Tzalik <gtzalik@amazon.com>,
 Evgeny Schemeilin <evgenys@amazon.com>, Jing Chen <jing.d.chen@intel.com>,
 Helin Zhang <helin.zhang@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 M
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-vk0-f53.google.com (mail-vk0-f53.google.com
 [209.85.213.53]) by dpdk.org (Postfix) with ESMTP id 4D3AE20F
 for <dev@dpdk.org>; Tue, 16 May 2017 12:17:13 +0200 (CEST)
Received: by mail-vk0-f53.google.com with SMTP id y190so63064879vkc.1
 for <dev@dpdk.org>; Tue, 16 May 2017 03:17:13 -0700 (PDT)
In-Reply-To: <3454007.3ZDP6eXIq0@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, May 16, 2017 at 11:02 AM, Thomas Monjalon <thomas@monjalon.net>
wrote:

> 16/05/2017 11:39, Alejandro Lucero:
> > Maybe we need another feature for detected link speed report capability.
> >
> > There is already support for ETH_SPEED_NUM_NONE if the speed is not
> defined
> > or it can not be specified by the device. Netronome has some firmwares
> > without that link speed report capability, although maybe we are not the
> > only ones with that problem.
> >
> >
> > What do you think about this?
>
> Yes, you mean you can advertise a speed capability,
> but cannot report the real negotiated speed, right?
> So we could add this feature.
>

Perfect.


> There are also virtual drivers which cannot report some real speed.
>
>
Yes, that is right. Virtual drivers can not report speed.

We have a problem with a client using pktgen which assumes a device will
report the link speed always. By the way, I will send a patch for avoiding
this issue with pktgen.

Thanks