From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alejandro Lucero <alejandro.lucero@netronome.com>
Subject: Re: [PATCH v3 25/29] net/nfp: use eal I/O device memory
 read/write API
Date: Thu, 12 Jan 2017 10:53:17 +0000
Message-ID: <CAD+H992WfM6goFehpOuGRkN=ANXLYrDF9FMGS23MZACzFWG8TQ@mail.gmail.com>
References: <1482832175-27199-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1484212646-10338-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1484212646-10338-26-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev <dev@dpdk.org>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 jianbo.liu@linaro.org, Jan Viktorin <viktorin@rehivetech.com>,
 santosh.shukla@caviumnetworks.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-vk0-f48.google.com (mail-vk0-f48.google.com
 [209.85.213.48]) by dpdk.org (Postfix) with ESMTP id A992D5A29
 for <dev@dpdk.org>; Thu, 12 Jan 2017 11:53:18 +0100 (CET)
Received: by mail-vk0-f48.google.com with SMTP id 137so9969204vkl.0
 for <dev@dpdk.org>; Thu, 12 Jan 2017 02:53:18 -0800 (PST)
In-Reply-To: <1484212646-10338-26-git-send-email-jerin.jacob@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

I've tried to find out which dpdk repo should I use for testing this change
with NFP PMD.

It seems rte_read/write functions are not with last dpdk main repo, nor
with dpdk-net-next.

Can someone tell me which repo should I use?

On Thu, Jan 12, 2017 at 9:17 AM, Jerin Jacob <jerin.jacob@caviumnetworks.com
> wrote:

> From: Santosh Shukla <santosh.shukla@caviumnetworks.com>
>
> Replace the raw I/O device memory read/write access with eal
> abstraction for I/O device memory read/write access to fix
> portability issues across different architectures.
>
> CC: Alejandro Lucero <alejandro.lucero@netronome.com>
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  drivers/net/nfp/nfp_net_pmd.h | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/nfp/nfp_net_pmd.h b/drivers/net/nfp/nfp_net_pmd.h
> index c180972..f11b32e 100644
> --- a/drivers/net/nfp/nfp_net_pmd.h
> +++ b/drivers/net/nfp/nfp_net_pmd.h
> @@ -121,25 +121,26 @@ struct nfp_net_adapter;
>  #define NFD_CFG_MINOR_VERSION_of(x) (((x) >> 0) & 0xff)
>
>  #include <linux/types.h>
> +#include <rte_io.h>
>
>  static inline uint8_t nn_readb(volatile const void *addr)
>  {
> -       return *((volatile const uint8_t *)(addr));
> +       return rte_read8(addr);
>  }
>
>  static inline void nn_writeb(uint8_t val, volatile void *addr)
>  {
> -       *((volatile uint8_t *)(addr)) = val;
> +       rte_write8(val, addr);
>  }
>
>  static inline uint32_t nn_readl(volatile const void *addr)
>  {
> -       return *((volatile const uint32_t *)(addr));
> +       return rte_read32(addr);
>  }
>
>  static inline void nn_writel(uint32_t val, volatile void *addr)
>  {
> -       *((volatile uint32_t *)(addr)) = val;
> +       rte_write32(val, addr);
>  }
>
>  static inline uint64_t nn_readq(volatile void *addr)
> --
> 2.5.5
>
>