Re: [PATCH] drivers/net: document missing speed capabilities feature

From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
	Shepard Siegel <shepard.siegel@atomicrules.com>,
	Ed Czeck <ed.czeck@atomicrules.com>,
	John Miller <john.miller@atomicrules.com>,
	John McNamara <john.mcnamara@intel.com>,
	Harish Patil <harish.patil@cavium.com>,
	Rasesh Mody <rasesh.mody@cavium.com>,
	Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Shreyansh Jain <shreyansh.jain@nxp.com>,
	Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Marcin Wojtas <mw@semihalf.com>,
	Michal Krawczyk <mk@semihalf.com>,
	Guy Tzalik <gtzalik@amazon.com>,
	Evgeny Schemeilin <evgenys@amazon.com>,
	Jing Chen <jing.d.chen@intel.com>,
	Helin Zhang <helin.zhang@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
	M
Subject: Re: [PATCH] drivers/net: document missing speed capabilities feature
Date: Tue, 16 May 2017 10:39:53 +0100	[thread overview]
Message-ID: <CAD+H993bAMOFMOBqro3GnQjj-8FLyj4OswkXYY77mjK=1=aLxQ@mail.gmail.com> (raw)
In-Reply-To: <17406199.hqjMraK9H2@xps>

Maybe we need another feature for detected link speed report capability.

There is already support for ETH_SPEED_NUM_NONE if the speed is not defined
or it can not be specified by the device. Netronome has some firmwares
without that link speed report capability, although maybe we are not the
only ones with that problem.

What do you think about this?

On Fri, May 12, 2017 at 4:48 PM, Thomas Monjalon <thomas@monjalon.net>
wrote:

> 12/05/2017 12:49, Ferruh Yigit:
> > On 5/10/2017 2:51 PM, Thomas Monjalon wrote:
> > > 10/05/2017 15:10, Ferruh Yigit:
> > >> --- a/doc/guides/nics/features/bnx2x.ini
> > >> +++ b/doc/guides/nics/features/bnx2x.ini
> > >> @@ -4,6 +4,7 @@
> > >>  ; Refer to default.ini for the full list of available PMD features.
> > >>  ;
> > >>  [Features]
> > >> +Speed capabilities   = Y
> > >
> > > We should validate this feature only if the driver advertise the
> > > right speeds for the device.
> >
> > Hi Thomas,
> >
> > Can you please clarify more, what is expected implementation in PMD?
>
> It is expected to advertise only the speeds that the device is
> capable to offer.
>
> > And perhaps a good and a bad sample can be helpful.
>
> Good example:
> drivers/net/i40e/i40e_ethdev.c
>     if (I40E_PHY_TYPE_SUPPORT_40G(hw->phy.phy_types))
>         /* For XL710 */
>         dev_info->speed_capa = ETH_LINK_SPEED_40G;
>     else if (I40E_PHY_TYPE_SUPPORT_25G(hw->phy.phy_types))
>         /* For XXV710 */
>         dev_info->speed_capa = ETH_LINK_SPEED_25G;
>     else
>         /* For X710 */
>         dev_info->speed_capa = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_10G;
>
> Bad example:
> drivers/net/bnx2x/bnx2x_ethdev.c
>     dev_info->speed_capa = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_20G;
> Looking at qlogic.com, only some 57840 adapters are capable of 20G.
>
>