From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A12A3C433EF for ; Sun, 27 Feb 2022 18:30:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230412AbiB0Sbc (ORCPT ); Sun, 27 Feb 2022 13:31:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiB0Sb2 (ORCPT ); Sun, 27 Feb 2022 13:31:28 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93D346CA4F; Sun, 27 Feb 2022 10:30:51 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id s24so14536782edr.5; Sun, 27 Feb 2022 10:30:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7/Si1oojWqE7bZU9236xHJfvcaAmph/X2hpEfYgxQN4=; b=i3JaEoSbVEmaMs+xVWRb7yDF4KWbTEk+9m59nHltQcJIo5sclCAoMI3EBdSxD5H3FR me+dSwZYuGsv/CVO9xmWFW7KyhXdspNSKtBTNs1s0+04ZQgtAdYxDsRY+mdxhg3BV07e ONfKwEepbXyFSeId2I3rWKwaWiurwkopRwYxHD5U2s5Vte36WVScXBLrUorL7N/hQ/pf AqmEYq48gU7Nlf9onuhP5ErSUGfEMsmrLdFFRoQceMkJNSX84BksC5l51TKmcGH1s+t5 gyX3vKdyFeYapCy2adcnNXx9aTCw8FDJ8ygoP/eUILSFDPhX00TDgRknaP0+45DuoZIH K5fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7/Si1oojWqE7bZU9236xHJfvcaAmph/X2hpEfYgxQN4=; b=O+r+2lL28JGcLC6MzIy+IuOgqu7DO91BxZ0Uad5CZq6HlQ8EdWqsNSpWjz94FtZmXl E3MK7QdGKRZ27bJ/XFbpPWZzFL2pH+unxg9H63x65p5qDeJ/glpVmsvl3UL3MqgDbf8J R3v+Gw1Y0Lg9XzZL+YLOWtGwmpZSb+WW5kXDhGo5I8yU2IKA7E9LDZAKaip3zDAmVFpR nTcMrmCOQcvAIZhsL96qV9c9fPUDL3yE9+KojrYG1lrIlzB1/nyQlC5otXNCw1hsbupB KjnKawouwoV7j5kDlxPF8/poCIHXram7HlSyoxHRrxB5LHJdW+DDCoe5eMBStySAGhZA vz7Q== X-Gm-Message-State: AOAM530FhKbiV6HGViEzA8YEMhQTm8tyHb7mvDucs7AZf5UW6QUfVjLI v+1OsE4ZK+i4sQkLh2jyq4j7qjt+0Yv7ZCwdqQ8DcZDV+ZA= X-Google-Smtp-Source: ABdhPJxq1U2NB5ll7G72DsuxUPr0EaZXTef6oivkTG3UiJk+rP2wZDU8ILFMUW3vqteRnic+vCRNFngEtwzl590eB1U= X-Received: by 2002:aa7:d594:0:b0:410:ef84:f706 with SMTP id r20-20020aa7d594000000b00410ef84f706mr16156277edq.347.1645986650062; Sun, 27 Feb 2022 10:30:50 -0800 (PST) MIME-Version: 1.0 References: <20220223094149.h5lj2dwq3sd5b3tp@quack3.lan> In-Reply-To: <20220223094149.h5lj2dwq3sd5b3tp@quack3.lan> From: harshad shirwadkar Date: Sun, 27 Feb 2022 10:30:38 -0800 Message-ID: Subject: Re: [RFC 4/9] ext4: Do not call FC trace event if FS does not support FC To: Jan Kara Cc: Ritesh Harjani , Ext4 Developers List , "Theodore Ts'o" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good. Reviewed-by: Harshad Shirwadkar - Harshad On Wed, 23 Feb 2022 at 01:41, Jan Kara wrote: > > On Wed 23-02-22 02:04:12, Ritesh Harjani wrote: > > This just puts trace_ext4_fc_commit_start(sb) & ktime_get() > > for measuring FC commit time, after the check of whether sb > > supports JOURNAL_FAST_COMMIT or not. > > > > Signed-off-by: Ritesh Harjani > > Looks good. Feel free to add: > > Reviewed-by: Jan Kara > > Honza > > > --- > > fs/ext4/fast_commit.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c > > index bf70879bb4fe..7fb1eceef30c 100644 > > --- a/fs/ext4/fast_commit.c > > +++ b/fs/ext4/fast_commit.c > > @@ -1167,13 +1167,13 @@ int ext4_fc_commit(journal_t *journal, tid_t commit_tid) > > int status = EXT4_FC_STATUS_OK, fc_bufs_before = 0; > > ktime_t start_time, commit_time; > > > > + if (!test_opt2(sb, JOURNAL_FAST_COMMIT)) > > + return jbd2_complete_transaction(journal, commit_tid); > > + > > trace_ext4_fc_commit_start(sb); > > > > start_time = ktime_get(); > > > > - if (!test_opt2(sb, JOURNAL_FAST_COMMIT)) > > - return jbd2_complete_transaction(journal, commit_tid); > > - > > restart_fc: > > ret = jbd2_fc_begin_commit(journal, commit_tid); > > if (ret == -EALREADY) { > > -- > > 2.31.1 > > > -- > Jan Kara > SUSE Labs, CR