From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <20141201024911.GA4200@kroah.com> References: <20141201024911.GA4200@kroah.com> Date: Mon, 1 Dec 2014 11:05:10 +0530 Message-ID: Subject: Re: PATCH From: Parth Sane Content-Type: text/plain; charset=UTF-8 List-ID: To: Greg Kroah-Hartman Cc: "driverdev-devel@linuxdriverproject.org" Hi Greg, I have looked at the patches and documentation on how to proceed forward. But I have a doubt. Was hoping you could make it clear for me. You have said that you don't want unnecessary binary firmware files in the source which is really good. But if I how do I know which binary files are required or not? This is nearly impossible for me to guess this, since I haven't written the driver. Please help me out with this. -Parth On 1 December 2014 at 08:19, Greg Kroah-Hartman wrote: > On Sun, Nov 30, 2014 at 08:54:08PM +0000, Parth Sane wrote: >> Hi, >> Please find the attached patch file. I hope it's OK. >> -Parth >> > >> From 3a429077981db3a7cf96d1e503c0bbbc932cab32 Mon Sep 17 00:00:00 2001 >> From: Parth Sane >> Date: Mon, 1 Dec 2014 01:55:47 +0530 >> Subject: [PATCH] added_missing_driver_code >> >> --- >> drivers/staging/mt7601u/TODO~ | 10 + >> drivers/staging/mt7601u/common/image.bin | Bin 0 -> 67936 bytes >> drivers/staging/mt7601u/common/rt2870_wow.bin | Bin 0 -> 12288 bytes >> drivers/staging/mt7601u/mcu/bin/MT7601.bin | Bin 0 -> 45412 bytes >> .../staging/mt7601u/mcu/bin/MT7601_formal_1.7.bin | Bin 0 -> 47032 bytes >> .../mt7601u/mcu/bin/MT7601_formal_1.7_Debug.bin | Bin 0 -> 51944 bytes >> drivers/staging/mt7601u/mcu/bin/MT7650.bin | Bin 0 -> 59580 bytes >> drivers/staging/mt7601u/mcu/bin/RT85592.bin | Bin 0 -> 35060 bytes >> drivers/staging/mt7601u/mcu/bin/rt2860.bin | Bin 0 -> 512 bytes >> drivers/staging/mt7601u/mcu/bin/rt2870.bin | Bin 0 -> 8192 bytes >> drivers/staging/mt7601u/mcu/bin/rt2870_wow.bin | Bin 0 -> 12288 bytes >> drivers/staging/mt7601u/os/linux/rt_linux.c~ | 6215 ++++++++++++++++++++ > > Take a look at the file Documentation/SubmittingPatches for the proper > format for how to submit patches in a way that we can accept them. > > We also don't want binary firmware files in the kernel source tree, > those will have to go to the linux-firmware project, but only the ones > that the driver really needs, not all of the ones you have listed here. > > thanks, > > greg k-h