All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vikas Sajjan <vikas.sajjan@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"kgene.kim" <kgene.kim@samsung.com>,
	Tomasz Figa <t.figa@samsung.com>,
	devicetree <devicetree@vger.kernel.org>,
	InKi Dae <inki.dae@samsung.com>, Ajay kumar <ajaynumb@gmail.com>,
	Patch Tracking <patches@linaro.org>,
	linaro-kernel@lists.linaro.org
Subject: Re: [PATCH v2 5/7] ARM: dts: Update DP controller DT Node for Exynos5 based SoCs
Date: Mon, 26 Aug 2013 11:35:18 +0530	[thread overview]
Message-ID: <CAD025yQ62VW4ou67GEi5=WwQy+j5r80haBp--ioPiw9U0o-e=Q@mail.gmail.com> (raw)
In-Reply-To: <002d01cea207$ff2c57d0$fd850770$%han@samsung.com>

Hi Mr. Jingoo Han,

On 26 August 2013 08:27, Jingoo Han <jg1.han@samsung.com> wrote:
> On Tuesday, July 30, 2013 8:20 PM, Vikas Sajjan wrote:
>>
>> Moves the properties of DP controller to exynos5.dtsi which are common
>> across exynos5 SoCs like Exynos5250 and Exynos5420.
>>
>> The PHY DP Node is based on Jingoo Han's <jg1.han@samsung.com> patch at
>> https://patchwork.linuxtv.org/patch/19189/
>>
>> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
>> ---
>>  arch/arm/boot/dts/exynos5.dtsi            |   11 +++++++++++
>>  arch/arm/boot/dts/exynos5250-arndale.dts  |    3 ++-
>>  arch/arm/boot/dts/exynos5250-smdk5250.dts |    3 ++-
>>  arch/arm/boot/dts/exynos5250.dtsi         |   21 +++++++++------------
>>  4 files changed, 24 insertions(+), 14 deletions(-)
>>
>
> [....]
>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
>> index 238bdb2..1c017dc 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -614,20 +614,17 @@
>>               interrupts = <0 94 0>;
>>       };
>>
>> -     dp-controller {
>> -             compatible = "samsung,exynos5-dp";
>> -             reg = <0x145b0000 0x1000>;
>> -             interrupts = <10 3>;
>> -             interrupt-parent = <&combiner>;
>> +     dp_phy: video-phy@10040720 {
>> +             compatible = "samsung,exynos5250-dp-video-phy";
>> +             reg = <0x10040720 4>;
>> +             #phy-cells = <0>;
>> +     };
>
> Oops!!!
>
> This patch should be reverted.
> Or, fix patch should be re-sent.
> 'dp phy' driver is not yet merged to mainline kernel.
>

As you suggest, since the DP-PHY driver is NOT yet in mainline, we may
have to keep this patch reverted till your patch series gets merged to
have DP working on exynos5 .

>
>> +
>> +     dp-controller@145b0000 {
>>               clocks = <&clock 342>;
>>               clock-names = "dp";
>> -             #address-cells = <1>;
>> -             #size-cells = <0>;
>> -
>> -             dptx-phy {
>> -                     reg = <0x10040720>;
>> -                     samsung,enable-mask = <1>;
>> -             };
>> +             phys = <&dp_phy>;
>> +             phy-names = "dp";
>>       };
>
> Thus, 'dptx-phy' node should be used until dp phy driver is merged.
>
> Vikas Sajjan,
> Please test your patch on real boards when you send your patch.
>

I tested the patch before sending on Exynos5250-SMDK5250 using  Kishon
Vijay Abraham's series at http://lwn.net/Articles/559487/
 which contains DP-PHY driver posted by you
 1.  phy: Add driver for Exynos DP PHY
 2.  video: exynos_dp: remove non-DT support for Exynos Display Port
 3.  video: exynos_dp: Use the generic PHY driver


 >
> Best regards,
> Jingoo Han
>
>
>



-- 
Thanks and Regards
 Vikas Sajjan

  reply	other threads:[~2013-08-26  6:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30 11:19 [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250 Vikas Sajjan
2013-08-01 14:49   ` Tomasz Figa
2013-08-05 10:04     ` Vikas Sajjan
2013-08-05 10:29       ` Sachin Kamat
2013-08-12  6:57         ` Vikas Sajjan
2013-08-14  5:56     ` Kukjin Kim
2013-08-14  8:16       ` Tomasz Figa
2013-08-14  8:40         ` Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 2/7] ARM: dts: Update FIMD DT node for Exynos5 SoCs Vikas Sajjan
2013-08-14  7:33   ` Kukjin Kim
2013-08-14  8:09     ` Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 3/7] ARM: dts: Add basic PM domains for EXYNOS5420 Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 4/7] ARM: dts: Add FIMD DT node to exynos5420 DTS files Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 5/7] ARM: dts: Update DP controller DT Node for Exynos5 based SoCs Vikas Sajjan
2013-08-26  2:57   ` Jingoo Han
2013-08-26  6:05     ` Vikas Sajjan [this message]
2013-09-12 10:36       ` Kukjin Kim
2013-09-12 10:56         ` Jingoo Han
2013-07-30 11:19 ` [PATCH v2 6/7] ARM: dts: Add DP controller DT node to exynos5420 SoC Vikas Sajjan
2013-07-30 11:19 ` [PATCH v2 7/7] ARM: dts: Add pin state information for DP HPD support to Exynos5420 Vikas Sajjan
2013-08-14  5:58 ` [PATCH v2 0/7] Add DT nodes for FIMD and DP controller for Exynos5420 SoC Kukjin Kim
2013-08-14  6:00   ` Vikas Sajjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD025yQ62VW4ou67GEi5=WwQy+j5r80haBp--ioPiw9U0o-e=Q@mail.gmail.com' \
    --to=vikas.sajjan@linaro.org \
    --cc=ajaynumb@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=inki.dae@samsung.com \
    --cc=jg1.han@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.