From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vikas Sajjan Subject: Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts Date: Fri, 10 May 2013 08:25:33 +0530 Message-ID: References: <1367992894-20198-1-git-send-email-vikas.sajjan@linaro.org> <1367992894-20198-4-git-send-email-vikas.sajjan@linaro.org> <4212940.hYf2k9NPUY@flatron> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7946656014511352876==" Return-path: In-Reply-To: <4212940.hYf2k9NPUY@flatron> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Tomasz Figa Cc: "kgene.kim" , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, Patch Tracking List-Id: devicetree@vger.kernel.org --===============7946656014511352876== Content-Type: multipart/alternative; boundary=001a11c379fa22400c04dc544ede --001a11c379fa22400c04dc544ede Content-Type: text/plain; charset=ISO-8859-1 Hi Tomasz, On 10 May 2013 05:35, Tomasz Figa wrote: > Hi Vikas, > > On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote: > > Adds display timing node for a DP panel to Arndale Board DTS file > > > > Signed-off-by: Vikas Sajjan > > --- > > arch/arm/boot/dts/exynos5250-arndale.dts | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts > > b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c > > 100644 > > --- a/arch/arm/boot/dts/exynos5250-arndale.dts > > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts > > @@ -459,4 +459,20 @@ > > samsung,lane-count = <4>; > > }; > > > > + display-timings { > > + native-mode = <&timing0>; > > + timing0: timing@0 { > > + /* 2560x1600 DP panel */ > > + clock-frequency = <50000>; > > + hactive = <2560>; > > + vactive = <1600>; > > + hfront-porch = <48>; > > + hback-porch = <80>; > > + hsync-len = <32>; > > + vback-porch = <16>; > > + vfront-porch = <8>; > > + vsync-len = <6>; > > + }; > > + }; > > What display are those timings used for? Shouldn't they be placed inside > node of that display? > > This timing information will be used parsed by the FIMD probe with the help of "Video Helper function" as done in this link https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0 Please refer to this patch which is used for exynos4412-origen and exynos5250-smdk5250 respectively in similar way https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=0207775d6ff7e6a6eddb9931f9328f0f0173a338 https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=06c460b73f75894cabfb1f5277f27cddbc92745c Best regards, > Tomasz > > -- Thanks and Regards Vikas Sajjan --001a11c379fa22400c04dc544ede Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi Tomasz,


On 10 May 2013 05:35, Tomasz Figa <<= a href=3D"mailto:tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" target=3D"_blank">tomasz.figa@gmail= .com> wrote:
Hi Vikas,

On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
> Adds display timing node for a DP panel to Arndale Board DTS file
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> =A0arch/arm/boot/dts/exynos5250-arndale.dts | =A0 16 ++++++++++++++++<= br> > =A01 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c
> 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -459,4 +459,20 @@
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 samsung,lane-count =3D <4>;
> =A0 =A0 =A0 };
>
> + =A0 =A0 display-timings {
> + =A0 =A0 =A0 =A0 =A0 =A0 native-mode =3D <&timing0>;
> + =A0 =A0 =A0 =A0 =A0 =A0 timing0: timing@0 {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* 2560x1600 DP panel */
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-frequency =3D <5000= 0>;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 hactive =3D <2560>; > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 vactive =3D <1600>; > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 hfront-porch =3D <48>;=
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 hback-porch =3D <80>;<= br> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 hsync-len =3D <32>; > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 vback-porch =3D <16>;<= br> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 vfront-porch =3D <8>;<= br> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 vsync-len =3D <6>;
> + =A0 =A0 =A0 =A0 =A0 =A0 };
> + =A0 =A0 };

What display are those timings used for? Shouldn't they be = placed inside
node of that display?

Best regards,
Tomasz




--
Thanks and Regards
= =A0Vikas Sajjan
--001a11c379fa22400c04dc544ede-- --===============7946656014511352876== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============7946656014511352876==--