From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40779C4CEC4 for ; Wed, 18 Sep 2019 10:46:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1142D214AF for ; Wed, 18 Sep 2019 10:46:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PXCOCYZL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbfIRKqk (ORCPT ); Wed, 18 Sep 2019 06:46:40 -0400 Received: from mail-ua1-f67.google.com ([209.85.222.67]:45857 "EHLO mail-ua1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbfIRKqj (ORCPT ); Wed, 18 Sep 2019 06:46:39 -0400 Received: by mail-ua1-f67.google.com with SMTP id j5so2152167uak.12; Wed, 18 Sep 2019 03:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BrhjnjM/XptL/cFMvLE/Y5Ttnqqp6IMVWZhIN4+ypyQ=; b=PXCOCYZLhjJjZhE0mCL7O99pzsqv5a9ePHsS5rpMpNEI66tHMcwkt6QXk6xsoRFdnX 5xGiHw/Gq49SKAqf4iYSz+w/1DwypCsVdYkNzpMGceTRdxpzhk8epbsMm5g8Vhp0qgu0 f4Gfg4dN+IDjBLnrk813NbLfH/un016KuQeOfs3ol+qbLgNt9wD4UZ1k+ns6Rh8DfLUb COOV5Sjf5+a33CIabIm4SZZfN7T4C1VbzYvwPZneQLdUxApH1uUnjIyavc8Ok9YwDiWA KOLH2G1jDo+JzZD/gzTPSh9TrxVelvjKdbYIFktwsLhftDuNpYvSRZfS1Aq5BrYg856k BKjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BrhjnjM/XptL/cFMvLE/Y5Ttnqqp6IMVWZhIN4+ypyQ=; b=fhM8qQboz3zb5QCqFGkgtCht7BkqvzNwgeFs1GFconCcqMf+F2MaSVBN4najtQODjM HgcT4aXbY1/58Bv2uaIlOvuBtl/SmO5byw5kQZ8dxK0bMAdz3EHVhLkiNVkBNF4BBeO1 A7nC50ScyFdj4isg+toMpHbxfdK0ca7sFMmJnpSDywm1scSlzYAiNCK30lBariGsp4GI x0zBN5QNjK5LrAwKWPsJjpFoaU7vA59iwGj4TbuhLzR/I/HP5gJKcQKmcc5ihS/IP1wX zPH+gMSUtvlLdAZkxFt05TH39ugMPPO67VqRWmZS8PWz4ekwPMkywj76XiPT6hul5oMf +AqQ== X-Gm-Message-State: APjAAAWeCPOd8sw6zGMtQM+KX1vVn3YtvwrpSpbB812sFj7Gz0tqsGVP qES2D3A7yD3/7P/Qs3/kDK8ev6C11uu7xapy/tE= X-Google-Smtp-Source: APXvYqwIg2lHMqtsEN5dzTh1ZkxryX4kas0pMBnOy6W/Vn/g0zZ7QGhTYumeAnuCciJllbWcyxE3Z6bF4YyOBG+Ro2A= X-Received: by 2002:ab0:2808:: with SMTP id w8mr1785489uap.75.1568803597279; Wed, 18 Sep 2019 03:46:37 -0700 (PDT) MIME-Version: 1.0 References: <20190917054726.GA2058532@kroah.com> <004401d56dc9$b00fd7a0$102f86e0$@samsung.com> <20190918061605.GA1832786@kroah.com> <20190918063304.GA8354@jagdpanzerIV> <20190918082658.GA1861850@kroah.com> <20190918092405.GC2959@kadam> <20190918100803.GD2959@kadam> In-Reply-To: <20190918100803.GD2959@kadam> From: Ju Hyung Park Date: Wed, 18 Sep 2019 19:46:25 +0900 Message-ID: Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to To: Dan Carpenter Cc: devel@driverdev.osuosl.org, linkinjeon@gmail.com, Valdis Kletnieks , Sergey Senozhatsky , Namjae Jeon , Greg KH , linux-kernel@vger.kernel.org, alexander.levin@microsoft.com, sergey.senozhatsky@gmail.com, linux-fsdevel@vger.kernel.org, sj1557.seo@samsung.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 18, 2019 at 7:09 PM Dan Carpenter wrote: > Use Kconfig. Not just that. There are a lot of non-static functions that's not marked ex/sdfat-specific. (which we would have to clean it up eventually) Even with sdFAT base, there are some non-static functions named as exfat. Figuring out a solution for this is pretty pointless imho when one of the drivers will be dropped soon(ish) anyways. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CEA6C4CEC9 for ; Wed, 18 Sep 2019 10:46:42 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 416BE21906 for ; Wed, 18 Sep 2019 10:46:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PXCOCYZL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 416BE21906 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id ECEA985EAA; Wed, 18 Sep 2019 10:46:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9fE2FVxQ781w; Wed, 18 Sep 2019 10:46:40 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id A741184CC2; Wed, 18 Sep 2019 10:46:40 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id F2FBA1BF962 for ; Wed, 18 Sep 2019 10:46:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id F024F203B8 for ; Wed, 18 Sep 2019 10:46:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b9Jbb2AAN9QO for ; Wed, 18 Sep 2019 10:46:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ua1-f65.google.com (mail-ua1-f65.google.com [209.85.222.65]) by silver.osuosl.org (Postfix) with ESMTPS id 810782039C for ; Wed, 18 Sep 2019 10:46:38 +0000 (UTC) Received: by mail-ua1-f65.google.com with SMTP id r25so2176502uam.3 for ; Wed, 18 Sep 2019 03:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BrhjnjM/XptL/cFMvLE/Y5Ttnqqp6IMVWZhIN4+ypyQ=; b=PXCOCYZLhjJjZhE0mCL7O99pzsqv5a9ePHsS5rpMpNEI66tHMcwkt6QXk6xsoRFdnX 5xGiHw/Gq49SKAqf4iYSz+w/1DwypCsVdYkNzpMGceTRdxpzhk8epbsMm5g8Vhp0qgu0 f4Gfg4dN+IDjBLnrk813NbLfH/un016KuQeOfs3ol+qbLgNt9wD4UZ1k+ns6Rh8DfLUb COOV5Sjf5+a33CIabIm4SZZfN7T4C1VbzYvwPZneQLdUxApH1uUnjIyavc8Ok9YwDiWA KOLH2G1jDo+JzZD/gzTPSh9TrxVelvjKdbYIFktwsLhftDuNpYvSRZfS1Aq5BrYg856k BKjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BrhjnjM/XptL/cFMvLE/Y5Ttnqqp6IMVWZhIN4+ypyQ=; b=Mj4SJrs//d2U5rRjuqjPK+ovf8a++svIQTcwdz4VZEhDBzBcCdUizpbUZV7tp9nMF7 aZKOnGOEr3VmyUQYQdOFwFSVLaLRXR41Mc0NmRjJ+zS6XpQ49PT0mytALAdhvE4VgUmT ABowDt3GIhCGvF1UyeLRryOdOnNoBfqF7gQ22v4lOZEy2I6D3CH3M88AoCs2qnVdReF3 5gViV1Ny33NZH9WSlBJ1x/M9EfkEhKu68DZ1W3AXbPPQFSlicwetJ16YOFWUX6WujxoH vfmyTVESCg1+okcQbmrWgMISk68ky+4/RMK+yc5ypoGmxMYttygLPvWQhJoC+qcJgqv4 0EpA== X-Gm-Message-State: APjAAAUtWu8kJujMusXR45RnwGOAGcgMoqLlNImVy6rzmmyuofJZ6mCK TdF1u+SC46WmdDrxe6Ml2n4/HR66dtwK3jJ0cjY= X-Google-Smtp-Source: APXvYqwIg2lHMqtsEN5dzTh1ZkxryX4kas0pMBnOy6W/Vn/g0zZ7QGhTYumeAnuCciJllbWcyxE3Z6bF4YyOBG+Ro2A= X-Received: by 2002:ab0:2808:: with SMTP id w8mr1785489uap.75.1568803597279; Wed, 18 Sep 2019 03:46:37 -0700 (PDT) MIME-Version: 1.0 References: <20190917054726.GA2058532@kroah.com> <004401d56dc9$b00fd7a0$102f86e0$@samsung.com> <20190918061605.GA1832786@kroah.com> <20190918063304.GA8354@jagdpanzerIV> <20190918082658.GA1861850@kroah.com> <20190918092405.GC2959@kadam> <20190918100803.GD2959@kadam> In-Reply-To: <20190918100803.GD2959@kadam> From: Ju Hyung Park Date: Wed, 18 Sep 2019 19:46:25 +0900 Message-ID: Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to To: Dan Carpenter X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linkinjeon@gmail.com, Valdis Kletnieks , Sergey Senozhatsky , Namjae Jeon , Greg KH , linux-kernel@vger.kernel.org, alexander.levin@microsoft.com, sergey.senozhatsky@gmail.com, linux-fsdevel@vger.kernel.org, sj1557.seo@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, Sep 18, 2019 at 7:09 PM Dan Carpenter wrote: > Use Kconfig. Not just that. There are a lot of non-static functions that's not marked ex/sdfat-specific. (which we would have to clean it up eventually) Even with sdFAT base, there are some non-static functions named as exfat. Figuring out a solution for this is pretty pointless imho when one of the drivers will be dropped soon(ish) anyways. Thanks. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel