From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Hughes Subject: Re: [PATCH] platform/x86: Export LPC attributes for the system SPI chip Date: Thu, 7 May 2020 19:47:29 +0100 Message-ID: References: <18e48255d68a1408b3e3152780f0e789df540059.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: owner-linux-security-module@vger.kernel.org To: Mario Limonciello Cc: Platform Driver , linux-security-module List-Id: platform-driver-x86.vger.kernel.org On Thu, 7 May 2020 at 18:45, wrote: > To echo Andy's question, I would wonder if it makes sense to just export > these attributes in securityfs directly from the intel-spi-pci driver rather > than to have another driver in platform-x86 to get the information. The "DANGEROUS" in the SPI_INTEL_SPI_PCI and SPI_INTEL_SPI_PLATFORM worried me somewhat. I'm guessing this is why most distros don't compile it as a module by default. If the module isn't actually still considered dangerous, and we can remove the warning I can of course respin my patch on top of that instead. Richard.