All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mohammed Shafi <shafi.wireless@gmail.com>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org,
	John Linville <linville@tuxdriver.com>,
	nbd@openwrt.org
Subject: Re: [RESEND][PATCH] minstrel_ht: fix Open BA session request floods
Date: Tue, 6 Sep 2011 10:03:00 +0530	[thread overview]
Message-ID: <CAD2nsn3FUM-k3bBD3mpwqVVXo3xvwjrf2HEARJddZJq+w0pf9w@mail.gmail.com> (raw)
In-Reply-To: <201109060609.46663.chunkeey@googlemail.com>

On Tue, Sep 6, 2011 at 9:39 AM, Christian Lamparter
<chunkeey@googlemail.com> wrote:
> On Monday, September 05, 2011 05:20:09 PM Mohammed Shafi wrote:
>> On Sat, Sep 3, 2011 at 12:36 PM, Christian Lamparter
>> <chunkeey@googlemail.com> wrote:
>> > Minstrel HT tries very hard to establish a BA session with
>> > each peer once there's some data on the way. However the
>> > stack does not inform minstrel if an aggregation session
>> > is already in place, so it keeps trying and wastes good
>> > cycles in the tx status path.
>> >
>> > [ 8149.946393] Open BA session requested for $AP tid 0
>> > [ 8150.048765] Open BA session requested for $AP tid 0
>> > [ 8150.174509] Open BA session requested for $AP tid 0
>> > [ 8150.274376] Open BA session requested for $AP tid 0
>> > ...
>>
>>
>> Hi Christian,
>>
>> I got this messages in ath9k after few cycles of suspend and resume.
> There's nothing wrong with the message... as long as its reasonable
> and does not spam the logs as in my case [had about 100k entries].

indeed, it spam's the log.

>
>> doing the same fix in ath9k rate control tx_status callback the
>> messages did not re-appear. I will soon send a proper patch for ath9k
>> too.
> Well, ath9k's rc works different than minstrel_ht. In fact that check
> is not needed as ath9k's rc can check the tid state directly in
> ath_tx_aggr_check [which I think it already does... unless something
> is wrong with the txtid->state check?!].

 thanks, i will check  into that.

thanks,
shafi

      reply	other threads:[~2011-09-06  4:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-03  7:06 [RESEND][PATCH] minstrel_ht: fix Open BA session request floods Christian Lamparter
2011-09-03 10:51 ` Felix Fietkau
2011-09-05 15:20 ` Mohammed Shafi
2011-09-06  4:09   ` Christian Lamparter
2011-09-06  4:33     ` Mohammed Shafi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAD2nsn3FUM-k3bBD3mpwqVVXo3xvwjrf2HEARJddZJq+w0pf9w@mail.gmail.com \
    --to=shafi.wireless@gmail.com \
    --cc=chunkeey@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.