>> --- a/xen/include/asm-x86/domain.h

> >> +++ b/xen/include/asm-x86/domain.h
> >> @@ -342,13 +342,15 @@ struct arch_domain
> >>
> >>      /* Monitor options */
> >>      struct {
> >> -        uint16_t write_ctrlreg_enabled       : 4;
> >> -        uint16_t write_ctrlreg_sync          : 4;
> >> -        uint16_t write_ctrlreg_onchangeonly  : 4;
> >> -        uint16_t mov_to_msr_enabled          : 1;
> >> -        uint16_t mov_to_msr_extended         : 1;
> >> -        uint16_t singlestep_enabled          : 1;
> >> -        uint16_t software_breakpoint_enabled : 1;
> >> +        uint32_t write_ctrlreg_enabled       : 4;
> >> +        uint32_t write_ctrlreg_sync          : 4;
> >> +        uint32_t write_ctrlreg_onchangeonly  : 4;
> >> +        uint32_t mov_to_msr_enabled          : 1;
> >> +        uint32_t mov_to_msr_extended         : 1;
> >> +        uint32_t singlestep_enabled          : 1;
> >> +        uint32_t software_breakpoint_enabled : 1;
> >> +        uint32_t request_enabled             : 1;
> >> +        uint32_t request_sync                : 1;
> >
> > Can you please switch to plain unsigned int if you already have to
> > touch this? There's no reason I can see to use a fixed width integer
> > type here.
>
> Ack, will make it plain int.


IMHO having it fix-width is easier to read when adding new elements to see
how many bits we have left free. I would not want this changed unless there
is a clear benefit to doing so.

Tamas