All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Thomas <pthomas8589@gmail.com>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver
Date: Tue, 12 Mar 2019 18:05:04 -0400	[thread overview]
Message-ID: <CAD56B7eM1--nOv=kPvsLfcvhLeYpSM+pVyk3CDi5szx3hCXp_A@mail.gmail.com> (raw)
In-Reply-To: <02874ECE860811409154E81DA85FBB58923253CC@ORSMSX121.amr.corp.intel.com>

Hi Jake, thanks for all the help and for looking at this!

>
> You have two conditionals inside, and I misread where you were doing the checking of the SKBTX_HW_TSTAMP flag.
>
> I would do the following :
>
> if (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HWTSTAMP) &&
>     gem_ptp_do_txstamp(queue, skb, desc)) {
I guess I was thinking the call to gem_ptp_do_txstamp() could be
avoided in many cases, but either way is fine with me..
>   ....
> }
>
-Paul

  reply	other threads:[~2019-03-12 22:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 19:50 [PATCH] Check for SKBTX_HW_TSTAMP in macb driver Paul Thomas
2019-03-12 20:05 ` Paul Thomas
2019-03-12 21:37   ` Keller, Jacob E
2019-03-13  5:59     ` Harini Katakam
2019-03-13 14:50       ` Keller, Jacob E
2019-03-12 21:34 ` Keller, Jacob E
2019-03-12 21:39   ` Keller, Jacob E
2019-03-12 22:05     ` Paul Thomas [this message]
2019-03-12 23:07       ` Keller, Jacob E
2019-03-12 23:30         ` Paul Thomas
2019-03-13  5:40           ` Harini Katakam
2019-03-13 14:46             ` Keller, Jacob E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD56B7eM1--nOv=kPvsLfcvhLeYpSM+pVyk3CDi5szx3hCXp_A@mail.gmail.com' \
    --to=pthomas8589@gmail.com \
    --cc=jacob.e.keller@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.