All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jagan Teki <jagannadh.teki@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] board: Add support for Engicam i.CoreM6 Quad/Dual boards
Date: Wed, 5 Apr 2017 22:24:30 +0530	[thread overview]
Message-ID: <CAD6G_RQqBo_nR4itVjWKrhCRB+MNpGOORPXOq=W_c_7f5L+KeQ@mail.gmail.com> (raw)
In-Reply-To: <20170405181936.109cf410@free-electrons.com>

On Wed, Apr 5, 2017 at 9:49 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Wed, 5 Apr 2017 21:26:16 +0530, Jagan Teki wrote:
>
>> > This script is exactly the same as the one in
>> > board/freescale/common/imx/post-image.sh, I definitely would like to
>> > avoid duplication.
>>
>> Same, but calling genimage.cfg is different in engicam vs freescale common.
>
> What is different?
>
>> > For now, if you're trying to submit the support for a single board, I
>> > would suggest that you:
>> >
>> >  1. Use a "fixed" genimage.cfg, i.e without %FILES% or %DTBS%
>> >
>> >  2. Use support/scripts/genimage.sh
>>
>> I will submit remaining boards soon, so I will keep the genimage.cfg as it is.
>
> What prevents you from using the Freescale common genimage.cfg?

Freescale script doesn't suport SPL and dtb enabled u-boot.

  partition SPL {
    in-partition-table = "no"
    image = "SPL"
    offset = 1024
  }

  partition u-boot-dtb {
    in-partition-table = "no"
    image = "u-boot-dtb.img"
    offset = 69K
  }

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

  reply	other threads:[~2017-04-05 16:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 18:10 [Buildroot] [PATCH v3] board: Add support for Engicam i.CoreM6 Quad/Dual boards Jagan Teki
2017-04-04 20:17 ` Thomas Petazzoni
2017-04-05 15:56   ` Jagan Teki
2017-04-05 16:19     ` Thomas Petazzoni
2017-04-05 16:54       ` Jagan Teki [this message]
2017-04-05 16:32     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD6G_RQqBo_nR4itVjWKrhCRB+MNpGOORPXOq=W_c_7f5L+KeQ@mail.gmail.com' \
    --to=jagannadh.teki@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.