From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Thu, 29 Mar 2018 15:00:14 +0530 Subject: [U-Boot] [PATCH v4 13/19] sunxi: DT: A64: update board .dts files from Linux In-Reply-To: <20180329090736.nricjjpnycnal4re@flea> References: <20180314015715.15615-1-andre.przywara@arm.com> <20180314015715.15615-14-andre.przywara@arm.com> <20180328111550.ivyct4wihqu54gnn@flea> <20180329090736.nricjjpnycnal4re@flea> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Mar 29, 2018 at 2:37 PM, Maxime Ripard wrote: > On Wed, Mar 28, 2018 at 11:29:10PM +0530, Jagan Teki wrote: >> On Wed, Mar 28, 2018 at 4:45 PM, Maxime Ripard >> wrote: >> > On Wed, Mar 28, 2018 at 03:22:20PM +0530, Jagan Teki wrote: >> >> >> May it's good option to look at v3 changes, since DM_MMC Migration >> >> >> expires in coming release, dt changes which are related to MMC we can >> >> >> wait for proper supported feature get IN(like pinctrl, clock, reset), >> >> >> that means we should anyway need to move DM_MMC but with working dt >> >> >> changes. >> >> >> >> >> >> The big question for me here is about SPL, I'm sure we can get the >> >> >> size issues. May be we try platdata but in any case we need to enable >> >> >> DM ie increase the size (atleast for A64, H5) >> >> > >> >> > So my understanding is that those DM_ defines are just for >> >> > U-Boot proper, and the SPL needs extra symbols to be also "DMed". >> >> >> >> I don't think so, Idea about migrating to BLK, DM_MMC should remove >> >> #ifdef code with DM vs non-DM such that the driver should have DM >> >> version with DT along with PLATDATA >> > >> > I'm not even sure what is the point of having the DM in the SPL. We >> > won't be able to have any of the benefits due to our size constraint. >> >> True, but what if MIGRATION.txt intention is to remove old or non-dm >> code after v2018.05? > > Then that intention is unreallistic, and unless the one that wrote it > can make it fit in the SPL of all platforms, that's just wishful > thinking. I do have follow similar approach to remove #ifdef for SPI(_FLASH) areas, I already written to MMC migration thread hope they come back with proper. Jagan.