From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE89C77B73 for ; Mon, 22 May 2023 02:07:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231559AbjEVCH6 (ORCPT ); Sun, 21 May 2023 22:07:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229922AbjEVCH4 (ORCPT ); Sun, 21 May 2023 22:07:56 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 904ABB7; Sun, 21 May 2023 19:07:55 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-510d92184faso9071618a12.1; Sun, 21 May 2023 19:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684721274; x=1687313274; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Sz0Spj8dzzse1twdFWxs7Pr1GkJdyy1KzKMZwqhjwYw=; b=Z5mVGUMcyUthgWsbJz4jMz783W9DnClIAhVXFPkO3Sl1PZ84kkTS+St3Nm+j37fulr sX3mOzNAPu0+dKIhT/h8nzaEofGKN0yqBGudut32cHrc+E3dvf2d7wx578LjgttU8t4s O7EwM4brfMFhEMTdmaD5MyMs6SHBMdFND9VEzZa0pHOUqoirMERGER/wGBo1KoN53BCY T+iMnMZ036ZPnRQFAqeaotfKFAlx8nP7Elw06lTsg6bnJjq5C1f9CPAf/He3V1HuWKVt I2rKlbUzVCasktWwlPlOWr8Zj4b89yC0EVwhecTwlzbZwO909AtW1rPq6CaKmfACWwfE 8THw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684721274; x=1687313274; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Sz0Spj8dzzse1twdFWxs7Pr1GkJdyy1KzKMZwqhjwYw=; b=FSfwtzGOxHK2XjVYZP06Q4c8RopfWhIBk43JwZXwsPzSmHdGmhgRB+eUqJiMGBAtnx cufK2N8rmDt2B2tqxFzjePkfxQE4SQhtO9jZKaBWHlVCZDDe4TDlAp5BpMeXpe+UX8D/ YQXooLySIJAbuq5YJ53BlMbWQ6ucn783j9KydYHiqRbc9ENclPQQvrG4tXNSnrFMimud wMXUWEtMh3/6irD4IzmpSEjfXYTPozXt5oiHZ1fgUXzXAHalHJkISUqKdhgFd/6whHMp 85jKpdfekyT+el9YVSFtLzVYZ2ZrXL+n4Jp0d7cY1kVAUgd1leXJ2C0kN4RcsaW1sn/M Rf8A== X-Gm-Message-State: AC+VfDyA8qrU4hpOG/66UNoJV5EA6NYZX7DW1wY6zRBOTEIBXohi7Ewi qW1jL2YBqV2xcaXA6cZwrMf7TknUq7DEDhQZVQM= X-Google-Smtp-Source: ACHHUZ4wrOhEYShKyW/O1eY1HmQbKQKS6rz1bi7T5GEPQgCb9egPC4yZhclR5xQE+XYa5cZMmp8Cwd8iFnqTUqJgR/g= X-Received: by 2002:aa7:d80b:0:b0:50b:fe20:1c7f with SMTP id v11-20020aa7d80b000000b0050bfe201c7fmr7110715edq.33.1684721273786; Sun, 21 May 2023 19:07:53 -0700 (PDT) MIME-Version: 1.0 References: <20220515203653.4039075-1-jolsa@kernel.org> <20230520094722.5393-1-zegao@tencent.com> In-Reply-To: From: Ze Gao Date: Mon, 22 May 2023 10:07:42 +0800 Message-ID: Subject: Re: To: Jiri Olsa Cc: Yonghong Song , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Hao Luo , John Fastabend , KP Singh , Martin KaFai Lau , Masami Hiramatsu , Song Liu , Stanislav Fomichev , Steven Rostedt , Yonghong Song , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kafai@fb.com, kpsingh@chromium.org, netdev@vger.kernel.org, paulmck@kernel.org, songliubraving@fb.com, Ze Gao Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oops, I missed that. Thanks for pointing that out, which I thought is conditional use of rcu_is_watching before. One last point, I think we should double check on this "fentry does not filter with !rcu_is_watching" as quoted from Yonghong and argue whether it needs the same check for fentry as well. Regards, Ze