All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxim Uvarov <maxim.uvarov@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
	"François Ozog" <francois.ozog@linaro.org>,
	"Shashi Mallela" <shashi.mallela@linaro.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] hw: wdt: implement sbsa watchdog
Date: Fri, 2 Oct 2020 17:06:07 +0300	[thread overview]
Message-ID: <CAD8XO3ZWW87Ze+gX9xWtrZ=XaETvE63WqzobQamoGM2_tb-4Zw@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_76y5DoNw3tirFFaC9FfE6NnxwAkdgV5eSv9NUeBxdhw@mail.gmail.com>

On Thu, 1 Oct 2020 at 23:36, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Thu, 1 Oct 2020 at 20:37, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
> >
> > Initial virtual driver matching linux kernel sbsa_gwdt
> > driver. Driver implements basic functionality and makes
> > watchdog works on virtual machine and allows to reboot
> > secure OS. I.e. atf->optee->efi/uboot->kernel. More
> > information about that device can be found under:
> > ARM DEN0029B - Server Base System Architecture (SBSA)
> >
> > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
>
> Hi; what's the relationship between this SBSA watchdog
> device model and the one that Shashi posted recently?
> https://patchew.org/QEMU/20200929180410.33058-1-shashi.mallela@linaro.org/
>
> thanks
> -- PMM

Nice it's the same driver written a little bit differently. I did not
see his patch before. 2 things missing in Sashis driver which are
useful for me:
1. Add sbsa watchdog to machine virt also. That helped me to reboot a
virtual machine with secure payload.
2. I specially did not disable timer on driver close. I.e. "reboot"
linux path reboots with that watchdog.  And make timeout lower to not
wait for a long period.

Can this driver also be considered for virt machine?

Regards,
Maxim.


  reply	other threads:[~2020-10-02 14:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01 19:36 [PATCH] hw: wdt: implement sbsa watchdog Maxim Uvarov
2020-10-01 20:36 ` Peter Maydell
2020-10-02 14:06   ` Maxim Uvarov [this message]
2020-10-02 14:17     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD8XO3ZWW87Ze+gX9xWtrZ=XaETvE63WqzobQamoGM2_tb-4Zw@mail.gmail.com' \
    --to=maxim.uvarov@linaro.org \
    --cc=francois.ozog@linaro.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shashi.mallela@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.