From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44C65C433EF for ; Wed, 8 Sep 2021 21:11:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1B4160C3E for ; Wed, 8 Sep 2021 21:11:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F1B4160C3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EAE66E2F2; Wed, 8 Sep 2021 21:11:04 +0000 (UTC) Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28D3E6E2F2 for ; Wed, 8 Sep 2021 21:11:03 +0000 (UTC) Received: by mail-il1-x12c.google.com with SMTP id x5so3810861ill.3 for ; Wed, 08 Sep 2021 14:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+zj8C2mmfJJ638Qd3bWay3eU4cSnuwWClo1NJvPy09M=; b=f+YQT8Zhcy0WJVMXuqJy2SGXi599VEQcwuateIHU89hho6VH88YCmFtNPQL7F+BwZy EbGX1Hd6esS8YLn7GMl5tjV7129L2lj3bnXT5O1GQCN4kS6ooyEADilIHmtURZTu9IJ5 h8DVzEDyJOpMpGR1KNeUuiee1NF/E/avz1xtM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+zj8C2mmfJJ638Qd3bWay3eU4cSnuwWClo1NJvPy09M=; b=ZRWAKmhJjXVefVI/r7l5ZNrdqqafc1ycgLp3U2cteiBct6FI/idWAgigLR0nNEyylT zgmZc3DikyqU+hiUDM15z7vI5wrvQ+J9XevpXt/5gxfyKB28DwQuwpD5fmHllOljvhmZ Mobe1r+ULQTIxYK9bFFaCselFURAESI+T3jdSUHCWj5RadpeOPYiHqInTva67dnhWUXz Vfe//m2HkUKXcpE4WUNn8af14A+DI0Iam3HfgO0UEh+3rc76n1vFwhcUajtV0sddXSF/ yx2CeIxEJWt1PFe9EXrtQYuDLq90vf7OyQN0jIGHt85WNJmS2Q9py9bFm/AOM40lhTF0 jSWQ== X-Gm-Message-State: AOAM531DiwxSXjWhPZChplhgI5eNhf/71uziFS/9J470U4mIkwk0emfr so5oQe+/1KCDElb5Ijib8c7eMkM3xDQK/Q== X-Google-Smtp-Source: ABdhPJyLr1z4IWVGXdXXH8wEyv1TRCCg6XQSH4NEqbU6dKqOOd5bt7XRwwbE5H1AwcUOT4bzKaa8EQ== X-Received: by 2002:a05:6e02:1b05:: with SMTP id i5mr200275ilv.5.1631135462028; Wed, 08 Sep 2021 14:11:02 -0700 (PDT) Received: from mail-il1-f177.google.com (mail-il1-f177.google.com. [209.85.166.177]) by smtp.gmail.com with ESMTPSA id z7sm132452ilz.25.2021.09.08.14.11.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 14:11:00 -0700 (PDT) Received: by mail-il1-f177.google.com with SMTP id x5so3810772ill.3 for ; Wed, 08 Sep 2021 14:11:00 -0700 (PDT) X-Received: by 2002:a92:c8c3:: with SMTP id c3mr171707ilq.165.1631135460113; Wed, 08 Sep 2021 14:11:00 -0700 (PDT) MIME-Version: 1.0 References: <20210901201934.1084250-1-dianders@chromium.org> <20210901131531.v3.10.I77d7a48df0a6585ef2cc2ff140fbe8f236a9a9f7@changeid> In-Reply-To: From: Doug Anderson Date: Wed, 8 Sep 2021 14:10:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 10/16] drm/panel-simple: Non-eDP panels don't need "HPD" handling To: Sam Ravnborg Cc: Thierry Reding , Rob Herring , Maarten Lankhorst , linux-arm-msm , Bjorn Andersson , Linus W , Daniel Vetter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Steev Klimaszewski , Thomas Zimmermann , Maxime Ripard , David Airlie , dri-devel , LKML Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Sun, Sep 5, 2021 at 11:46 AM Sam Ravnborg wrote: > > On Wed, Sep 01, 2021 at 01:19:28PM -0700, Douglas Anderson wrote: > > All of the "HPD" handling added to panel-simple recently was for eDP > > panels. Remove it from panel-simple now that panel-simple-edp handles > > eDP panels. The "prepare_to_enable" delay only makes sense in the > > context of HPD, so remove it too. No non-eDP panels used it anyway. > > > > Signed-off-by: Douglas Anderson > > Maybe merge this with the patch that moved all the functionality > from panel-simple to panel-edp? Unless you feel strongly about it, I'm going to keep it separate still in the next version. To try to make diffing easier, I tried hard to make the minimal changes in the "split the driver in two" patch. -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90470C433EF for ; Wed, 8 Sep 2021 21:11:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7156060F23 for ; Wed, 8 Sep 2021 21:11:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234960AbhIHVMW (ORCPT ); Wed, 8 Sep 2021 17:12:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233330AbhIHVML (ORCPT ); Wed, 8 Sep 2021 17:12:11 -0400 Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBDD6C061575 for ; Wed, 8 Sep 2021 14:11:02 -0700 (PDT) Received: by mail-il1-x135.google.com with SMTP id x10so3780260ilm.12 for ; Wed, 08 Sep 2021 14:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+zj8C2mmfJJ638Qd3bWay3eU4cSnuwWClo1NJvPy09M=; b=f+YQT8Zhcy0WJVMXuqJy2SGXi599VEQcwuateIHU89hho6VH88YCmFtNPQL7F+BwZy EbGX1Hd6esS8YLn7GMl5tjV7129L2lj3bnXT5O1GQCN4kS6ooyEADilIHmtURZTu9IJ5 h8DVzEDyJOpMpGR1KNeUuiee1NF/E/avz1xtM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+zj8C2mmfJJ638Qd3bWay3eU4cSnuwWClo1NJvPy09M=; b=bb28Hm5YDguggBE9fwkREg4X5edGNZ5z0cDAOWWRTcFJtISv1lGoU9ThW7J8xFkQwv 7vXQkBkrKuyTRU0Ij3beSC0DJF+EfIf5BEO5ZPpwm8uZBRSXuy9Fxts78vxTuC46IQGb zM+5gq12qz8yZLbBfGvNIhuqIpnIPexWCf/3rCSV8j1ji8/Kd7sCeSA0rQH3s7KC+aSx 4xfd0h07wp7XvFzoyEa2CyvRtdT97RwU97Ho6mlUG9GZDvh9EbpTXr104GpGe7pGaqWQ GLPLxkY4bCmqpQeC9Gks3Z48/A1O4+kBcPdoJsR7yUbtoW2divXsR4/VwZRpv62nJEEg 9s9Q== X-Gm-Message-State: AOAM5319dtrnGWNxj5Yy+47KlL78OM4NmEwbwTwk4U7HlX3DJXEXepet o5QIn2r4m/szYxNn71cdOowqKpumdSYx2w== X-Google-Smtp-Source: ABdhPJx6jz/11aeP/TCjdv0FbDcT5ISPLvXSqET68tGt19AcqEe7Zvr+oEzZNpz9w//m2fS7Wa7rdA== X-Received: by 2002:a92:2a10:: with SMTP id r16mr165830ile.309.1631135461746; Wed, 08 Sep 2021 14:11:01 -0700 (PDT) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com. [209.85.166.182]) by smtp.gmail.com with ESMTPSA id i20sm101151ila.62.2021.09.08.14.11.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 14:11:00 -0700 (PDT) Received: by mail-il1-f182.google.com with SMTP id z2so3957894iln.0 for ; Wed, 08 Sep 2021 14:11:00 -0700 (PDT) X-Received: by 2002:a92:c8c3:: with SMTP id c3mr171707ilq.165.1631135460113; Wed, 08 Sep 2021 14:11:00 -0700 (PDT) MIME-Version: 1.0 References: <20210901201934.1084250-1-dianders@chromium.org> <20210901131531.v3.10.I77d7a48df0a6585ef2cc2ff140fbe8f236a9a9f7@changeid> In-Reply-To: From: Doug Anderson Date: Wed, 8 Sep 2021 14:10:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 10/16] drm/panel-simple: Non-eDP panels don't need "HPD" handling To: Sam Ravnborg Cc: Thierry Reding , Rob Herring , Maarten Lankhorst , linux-arm-msm , Bjorn Andersson , Linus W , Daniel Vetter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Steev Klimaszewski , Thomas Zimmermann , Maxime Ripard , David Airlie , dri-devel , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Sun, Sep 5, 2021 at 11:46 AM Sam Ravnborg wrote: > > On Wed, Sep 01, 2021 at 01:19:28PM -0700, Douglas Anderson wrote: > > All of the "HPD" handling added to panel-simple recently was for eDP > > panels. Remove it from panel-simple now that panel-simple-edp handles > > eDP panels. The "prepare_to_enable" delay only makes sense in the > > context of HPD, so remove it too. No non-eDP panels used it anyway. > > > > Signed-off-by: Douglas Anderson > > Maybe merge this with the patch that moved all the functionality > from panel-simple to panel-edp? Unless you feel strongly about it, I'm going to keep it separate still in the next version. To try to make diffing easier, I tried hard to make the minimal changes in the "split the driver in two" patch. -Doug