From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED46C4320A for ; Tue, 24 Aug 2021 22:52:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21417613AD for ; Tue, 24 Aug 2021 22:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231540AbhHXWxQ (ORCPT ); Tue, 24 Aug 2021 18:53:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231552AbhHXWxO (ORCPT ); Tue, 24 Aug 2021 18:53:14 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13FFCC06179A for ; Tue, 24 Aug 2021 15:52:28 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id n24so28434627ion.10 for ; Tue, 24 Aug 2021 15:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gaFUFYkq0aAQb9fBgckSLrpv7E3PmSpqoTQXohZW4cw=; b=IvPy+MabaZ/Bejpu9hF3104ynjKW9brt/qnAFarovpAHfVE+su5MGecyK0USm1S/TP gv+Ii7noRCgKZpU+IbZOBMPtf7xGO2HOjtHNFDsuSb4qW2gy/9DiqKx5AsTsBuyYfuiJ +E1hjLs3fjG3YKjZg1reMsmh46TSbvjKiIzfg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gaFUFYkq0aAQb9fBgckSLrpv7E3PmSpqoTQXohZW4cw=; b=btVa3+9DlJnyykT3hcXFatVWdFs+lnN/wy4zWZ6wduOvdSFR8H6HUPwKZswlc/qTHG GShVgQNRuL3JnTsJ0UtNVTiXHxB6KEcdbhrPXkxmMsX5Gph5K+cq86LE4ST4EgBVcvrw rZMkTJdoP3VutxYgJm2qZ6/bbBdstmS56XfPyO8m8NxyqWLI3qZwS9aUS51ugrXUw+Jg IaDCsYAfA153WfjvAn2z2qBXTgMWL6uMIUxniqV6n47q4rwMM/k4j4rIInrGDvmBzqAD oGW0wh+ZSTFXI9j+EHmtvWEeWkUCGKhItuzZwa7IxQtAL+K6GtiOHnE+GtUQenSi6A8u Q9OQ== X-Gm-Message-State: AOAM532tu8iOc0vb2iF11wxXauADOkhgYD+BdX0K0WDUXmxlP/+pFl83 tb3u6/49YmmygFMjb/ZeMshGNFDjimgdGA== X-Google-Smtp-Source: ABdhPJxXMtSDy3zDdWcRfBhTLL8JF4+ZjMN5/qeRbLHe1E7DSsHOMwKHY0NgpufJmV3LND5bXZo2Ww== X-Received: by 2002:a02:1d04:: with SMTP id 4mr36045951jaj.98.1629845547235; Tue, 24 Aug 2021 15:52:27 -0700 (PDT) Received: from mail-il1-f169.google.com (mail-il1-f169.google.com. [209.85.166.169]) by smtp.gmail.com with ESMTPSA id b12sm10707774ilo.44.2021.08.24.15.52.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Aug 2021 15:52:26 -0700 (PDT) Received: by mail-il1-f169.google.com with SMTP id b4so12571349ilr.11 for ; Tue, 24 Aug 2021 15:52:26 -0700 (PDT) X-Received: by 2002:a92:cf4a:: with SMTP id c10mr24580250ilr.269.1629845546303; Tue, 24 Aug 2021 15:52:26 -0700 (PDT) MIME-Version: 1.0 References: <1628642571-25383-1-git-send-email-tdas@codeaurora.org> In-Reply-To: <1628642571-25383-1-git-send-email-tdas@codeaurora.org> From: Doug Anderson Date: Tue, 24 Aug 2021 15:52:14 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1] arm64: dts: qcom: sc7280: Add clock controller ID headers To: Taniya Das Cc: Rob Herring , Bjorn Andersson , Stephen Boyd , Andy Gross , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Tue, Aug 10, 2021 at 5:43 PM Taniya Das wrote: > > Add the GPUCC, DISPCC and VIDEOCC clock headers which were dropped > earlier. > > Fixes: 422a295221bb ("arm64: dts: qcom: sc7280: Add clock controller nodes") IMO drop the "Fixes". To me having the "Fixes" there means that there was a bug in the old patch. This isn't really fixing a bug. > Signed-off-by: Taniya Das > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ > 1 file changed, 3 insertions(+) Other than removing the "Fixes" then this seems like it would be nice to land soon after the next -rc1 comes out so that patches that start referring to the clocks in these controllers can take advantage of them. Snooze 3 weeks till (presumably) -rc1 might come out. Reviewed-by: Douglas Anderson