From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Marc Zyngier <maz@kernel.org>, Lina Iyer <ilina@codeaurora.org>,
Maulik Shah <mkshah@codeaurora.org>
Subject: Re: [PATCH v2] genirq: Clarify that irq wake state is orthogonal to enable/disable
Date: Thu, 6 Feb 2020 11:32:51 -0800 [thread overview]
Message-ID: <CAD=FV=U5YNe5ODREBMcxSfhih8O48kwD_t+apAFD391Oekmkcg@mail.gmail.com> (raw)
In-Reply-To: <20200206191521.94559-1-swboyd@chromium.org>
Hi,
On Thu, Feb 6, 2020 at 11:15 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> There's some confusion around if an irq that's disabled with
> disable_irq() can still wake the system from sleep states such as
> "suspend to RAM". Let's clarify this in the kernel documentation for
> irq_set_irq_wake() so that it's clear that an irq can be disabled and
> still wake the system if it has been marked for wakeup.
>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Lina Iyer <ilina@codeaurora.org>
> Cc: Maulik Shah <mkshah@codeaurora.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>
> Changes from v1:
> * Added the last sentence from tglx
>
> kernel/irq/manage.c | 7 +++++++
> 1 file changed, 7 insertions(+)
FWIW this mathes my understanding and in the past I've done work to
'drivers/pinctrl/pinctrl-rockchip.c' making it support this exact
thing. Thanks for documenting.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
-Doug
next prev parent reply other threads:[~2020-02-06 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 19:15 [PATCH v2] genirq: Clarify that irq wake state is orthogonal to enable/disable Stephen Boyd
2020-02-06 19:32 ` Doug Anderson [this message]
2020-02-06 19:57 ` Lina Iyer
2020-02-07 18:59 ` Doug Anderson
2020-02-07 20:33 ` Thomas Gleixner
2020-02-07 20:40 ` [tip: irq/urgent] " tip-bot2 for Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=U5YNe5ODREBMcxSfhih8O48kwD_t+apAFD391Oekmkcg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mkshah@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.