From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C30C3526D for ; Wed, 26 Jan 2022 15:55:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231177AbiAZPzJ (ORCPT ); Wed, 26 Jan 2022 10:55:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231776AbiAZPzJ (ORCPT ); Wed, 26 Jan 2022 10:55:09 -0500 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEC49C061747 for ; Wed, 26 Jan 2022 07:55:08 -0800 (PST) Received: by mail-il1-x132.google.com with SMTP id y17so57030ilm.1 for ; Wed, 26 Jan 2022 07:55:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8N6pkwfXspakdaJZNWnP38Bamfx4gDdG3F4Wrj2z8a0=; b=R4PjleZoJRZEHoITMXop0eh4gJ/ykFxgKSZE/XIEndxWeSjox8Ho5Y5WSEwGWD5nwI 9IYUDjyO/sH115RZ8zr4aaHKv4uwuJ6DuRjt//KHrKEHmkUBteL2Q1nGUdQFKi1z9vuI qG8pW5RzxHr7VPzE3Xb0fueZxlRwCDsn2SfCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8N6pkwfXspakdaJZNWnP38Bamfx4gDdG3F4Wrj2z8a0=; b=EV01ssL6xeNkVJYdYXJfbeaApLRToLBy9NWNFJAlPtvoXuUWAIBpOTJUf0W+R1opg2 fZJlX+8Q6kj+VJwJHBNDTKciOPTqSgSgql/BAvw4l1VCAEN9p64Wrpi4lNlD6wtjYGQo CdS6D1XC7WjcLqmxv7zepWmY3WFsnfUWr6zOyFCDybcNmeywSp6ykW9fTP+3CrxEY45Z 1XYQjrvRT5wn3bd1S11i+zyPf1gytQmS2Xab9mmK6l2fMt2zcibnUC8i90SXPnhgN+sj /q5ldCiZm+J8qMlVbeCJvLNj0TYzYJ+K+r+dFDhppFiYM5miiVGaP7BCafy/g6bbLDLQ YuRw== X-Gm-Message-State: AOAM5332nMDaaJ61PT7Rvttq6tVifdXtdxrkB1qgENMBvn0OwLf74wWV jLxv1h1INKK+zn1/DAcshDdHTkYcJBPo4g== X-Google-Smtp-Source: ABdhPJyDRa2mmcSjtK4Wi/quje3J4F96XM0F9JmQGfWue2qOFtL8UQZp4aucPx03A0jeb3CveHiHog== X-Received: by 2002:a92:c267:: with SMTP id h7mr14121952ild.272.1643212507997; Wed, 26 Jan 2022 07:55:07 -0800 (PST) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com. [209.85.166.42]) by smtp.gmail.com with ESMTPSA id f4sm10706790iow.7.2022.01.26.07.55.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jan 2022 07:55:06 -0800 (PST) Received: by mail-io1-f42.google.com with SMTP id q204so27611iod.8 for ; Wed, 26 Jan 2022 07:55:06 -0800 (PST) X-Received: by 2002:a02:7a4f:: with SMTP id z15mr10410746jad.50.1643212505706; Wed, 26 Jan 2022 07:55:05 -0800 (PST) MIME-Version: 1.0 References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-8-s.hauer@pengutronix.de> In-Reply-To: <20220126145549.617165-8-s.hauer@pengutronix.de> From: Doug Anderson Date: Wed, 26 Jan 2022 07:54:53 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 07/27] drm/rockchip: dw_hdmi: Use auto-generated tables To: Sascha Hauer Cc: dri-devel , Linux ARM , "open list:ARM/Rockchip SoC..." , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sascha Hauer , Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Peter Geis , Yakir Yang , =?UTF-8?Q?St=C3=A9phane_Marchesin?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Wed, Jan 26, 2022 at 6:58 AM Sascha Hauer wrote= : > > From: Douglas Anderson > > The previous tables for mpll_cfg and curr_ctrl were created using the > 20-pages of example settings provided by the PHY vendor. Those > example settings weren't particularly dense, so there were places > where we were guessing what the settings would be for 10-bit and > 12-bit (not that we use those anyway). It was also always a lot of > extra work every time we wanted to add a new clock rate since we had > to cross-reference several tables. > > In I've gone through the work to figure The `crosreview.com` syntax doesn't seem to work anymore. Could maybe update to https://crrev.com/c/285855 ? > out how to generate this table automatically. Let's now use the > automatically generated table and then we'll never need to look at it > again. > > We only support 8-bit mode right now and only support a small number > of clock rates and and I've verified that the only 8-bit rate that was > affected was 148.5. That mode appears to have been wrong in the old > table. > > Changes since v3: > - new patch > > Signed-off-by: Douglas Anderson > Signed-off-by: Yakir Yang Should probably change the "at" to "@" ? > Reviewed-by: St=C3=A9phane Marchesin In general shouldn't carry downstream reviews when posting upstream unless you're certain that the person intended it... It's been a long time, but in general I think I was fairly confident in the numbers that my script pumped out, at least given the caveat of no pixel repetition and 8-bit only. That being said, I didn't have any inside knowledge of the hardware and just figured out formulas that seemed to match the table that I had. YMMV. I'll also say that when I did a rebase of veyron (rk3288-based Chromebook) to 4.19 about 2.5 years ago, I ended up squashing several of these patches into 1. That can be found at . That also has details about why some of these patches never made it upstream. The main reason, at least in the case of rk3288, was the PLL sharing problem that nobody ever solved. rk3288 didn't have quite enough PLLs and thus, if you were using both VOPs, one of the VOPs was going to be severely limited in what pixel clocks it could make. There was no framework deciding which VOP should be limited and how the system should react to this... In any case, I'm pretty far disconnected from all this stuff now, but I wish you the best of luck in trying to get it all solved! -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4116C63684 for ; Wed, 26 Jan 2022 15:55:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EBC1210E40F; Wed, 26 Jan 2022 15:55:10 +0000 (UTC) Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6237A10E40F for ; Wed, 26 Jan 2022 15:55:09 +0000 (UTC) Received: by mail-il1-x12e.google.com with SMTP id y17so57048ilm.1 for ; Wed, 26 Jan 2022 07:55:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8N6pkwfXspakdaJZNWnP38Bamfx4gDdG3F4Wrj2z8a0=; b=R4PjleZoJRZEHoITMXop0eh4gJ/ykFxgKSZE/XIEndxWeSjox8Ho5Y5WSEwGWD5nwI 9IYUDjyO/sH115RZ8zr4aaHKv4uwuJ6DuRjt//KHrKEHmkUBteL2Q1nGUdQFKi1z9vuI qG8pW5RzxHr7VPzE3Xb0fueZxlRwCDsn2SfCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8N6pkwfXspakdaJZNWnP38Bamfx4gDdG3F4Wrj2z8a0=; b=xw4tmPb01K7dwBWcWDQI2/KqjCLNjxWe93cRhnc4l56jmOG56VAxLY1BafxOdkLfob CBOyHP5miNPxnQqMHaIwWBK9PgedCOxBst1sBYD9gSBFoX1d/XioUwZ9woDrFeMK7fCW yiHycEOp/Kgya3MAgXdmnLjQphCpSRLSacFyPWZFIg9o9vwyedaXU8trs+8JuRs7yuEI eV75rkkA5Oc/XutrkEc6RUJCuzgE/5t0W5bcVvtYhPH/wsaPD9/7t7n54/pQ55DEpcfX IX9H9l4wiIjG1uDL5FYhTADCUk85yBUtaRX1YjFOtPI/7UrjDRn7UBunzz8YvANO+dhR +0GA== X-Gm-Message-State: AOAM530cW27sF5yZrKxdUjo2mwqQ/8cWtv++fWAlbtUCUJa8m/JveRTx AY9ItRl2jylTXZbo7g1S5YXNn5I0phHGaw== X-Google-Smtp-Source: ABdhPJwZI+uWQ95oyC277fiEDxaCArUDDLa+trdHxvPvrj81gjt3VZfJqqNU5Ehz6tKRC+KPtXO7EA== X-Received: by 2002:a92:8747:: with SMTP id d7mr14621815ilm.203.1643212508571; Wed, 26 Jan 2022 07:55:08 -0800 (PST) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com. [209.85.166.53]) by smtp.gmail.com with ESMTPSA id i11sm10755599iow.9.2022.01.26.07.55.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jan 2022 07:55:06 -0800 (PST) Received: by mail-io1-f53.google.com with SMTP id c188so40652iof.6 for ; Wed, 26 Jan 2022 07:55:06 -0800 (PST) X-Received: by 2002:a02:7a4f:: with SMTP id z15mr10410746jad.50.1643212505706; Wed, 26 Jan 2022 07:55:05 -0800 (PST) MIME-Version: 1.0 References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-8-s.hauer@pengutronix.de> In-Reply-To: <20220126145549.617165-8-s.hauer@pengutronix.de> From: Doug Anderson Date: Wed, 26 Jan 2022 07:54:53 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 07/27] drm/rockchip: dw_hdmi: Use auto-generated tables To: Sascha Hauer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Benjamin Gaignard , Peter Geis , =?UTF-8?Q?St=C3=A9phane_Marchesin?= , Sandy Huang , dri-devel , "open list:ARM/Rockchip SoC..." , Michael Riesch , Sascha Hauer , Yakir Yang , Andy Yan , Linux ARM Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Wed, Jan 26, 2022 at 6:58 AM Sascha Hauer wrote= : > > From: Douglas Anderson > > The previous tables for mpll_cfg and curr_ctrl were created using the > 20-pages of example settings provided by the PHY vendor. Those > example settings weren't particularly dense, so there were places > where we were guessing what the settings would be for 10-bit and > 12-bit (not that we use those anyway). It was also always a lot of > extra work every time we wanted to add a new clock rate since we had > to cross-reference several tables. > > In I've gone through the work to figure The `crosreview.com` syntax doesn't seem to work anymore. Could maybe update to https://crrev.com/c/285855 ? > out how to generate this table automatically. Let's now use the > automatically generated table and then we'll never need to look at it > again. > > We only support 8-bit mode right now and only support a small number > of clock rates and and I've verified that the only 8-bit rate that was > affected was 148.5. That mode appears to have been wrong in the old > table. > > Changes since v3: > - new patch > > Signed-off-by: Douglas Anderson > Signed-off-by: Yakir Yang Should probably change the "at" to "@" ? > Reviewed-by: St=C3=A9phane Marchesin In general shouldn't carry downstream reviews when posting upstream unless you're certain that the person intended it... It's been a long time, but in general I think I was fairly confident in the numbers that my script pumped out, at least given the caveat of no pixel repetition and 8-bit only. That being said, I didn't have any inside knowledge of the hardware and just figured out formulas that seemed to match the table that I had. YMMV. I'll also say that when I did a rebase of veyron (rk3288-based Chromebook) to 4.19 about 2.5 years ago, I ended up squashing several of these patches into 1. That can be found at . That also has details about why some of these patches never made it upstream. The main reason, at least in the case of rk3288, was the PLL sharing problem that nobody ever solved. rk3288 didn't have quite enough PLLs and thus, if you were using both VOPs, one of the VOPs was going to be severely limited in what pixel clocks it could make. There was no framework deciding which VOP should be limited and how the system should react to this... In any case, I'm pretty far disconnected from all this stuff now, but I wish you the best of luck in trying to get it all solved! -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25861C28CF5 for ; Wed, 26 Jan 2022 17:06:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YgHJ4dRCE5tabDODp5BiheTVmqErvUBt8YPUN2djhCY=; b=0u7FBpbs8ls7WO XC04rJS+Ys/F7k2z0hXR7BGCM4Xebtirq6ofoweuwzp6u+Mb6u8q3pYbrcL3BX7+1QWOkxfVtCU39 MFqthCJ6wq7DcXdgUPggnVO2Kq60tepPBpr41kuhDYJDroMsbbtUyHzvjxg7u/W9hfX9qSCSYoEZi 0gWPLzShOXwtCXOnN8mHosis5b9k0rd6coRcd9oa+kwtCXBnfJ21DVxVFCJXclkp405zQMYTTEgXB X+sECS5jjtIL5vnMYJ4/UY2uMINqwfkIwCIji81kCkJHbT4X3+wXF+Jt8xxJwXVpblBV8LxOy9m3C 8g0vD5qIp3cieJS3KRkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nClkR-00CrsB-UA; Wed, 26 Jan 2022 17:06:19 +0000 Received: from mail-io1-xd2c.google.com ([2607:f8b0:4864:20::d2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCkdY-00CRiZ-C3 for linux-rockchip@lists.infradead.org; Wed, 26 Jan 2022 15:55:13 +0000 Received: by mail-io1-xd2c.google.com with SMTP id c188so40719iof.6 for ; Wed, 26 Jan 2022 07:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8N6pkwfXspakdaJZNWnP38Bamfx4gDdG3F4Wrj2z8a0=; b=R4PjleZoJRZEHoITMXop0eh4gJ/ykFxgKSZE/XIEndxWeSjox8Ho5Y5WSEwGWD5nwI 9IYUDjyO/sH115RZ8zr4aaHKv4uwuJ6DuRjt//KHrKEHmkUBteL2Q1nGUdQFKi1z9vuI qG8pW5RzxHr7VPzE3Xb0fueZxlRwCDsn2SfCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8N6pkwfXspakdaJZNWnP38Bamfx4gDdG3F4Wrj2z8a0=; b=yVcT8DXARKl2Jbbqd8ssSq+smHVAOSSsSP1wYEmLhk896N8YZ2CJEFscKAHBAtNMWc qwJ/z5HQXrHn+SDnQQo83s20YQfKnbCNqccajD53B7amAUI00WcOk1FxX4T0X4kevNfG EsOd8P/3YeT3yMbWDLuAnw8C2FeDU/09jub17UjyWMD4NbbhxuM/fHeI9kc0uIfzH77q E1cIHDo+YjC939HC66ELzv1RPSdjvaUndx6IPFkpXlVUYCAaJ299LAziDVJEKG9zjT+D v00kOc6INslvim1Ne1b1qr4/NX8ZhEl6O/sD3ZDbAx5AMQrmph2VRoxYeOCvHTXT6oSW KS0Q== X-Gm-Message-State: AOAM531Jy78HSgkeSWg1nIVYcrwZNvCPk7fW1BvvTCalkqcwZk1NDkeG 3YX1ptZTc9SwFurCDNYrRIKH+e3HFI4T3Q== X-Google-Smtp-Source: ABdhPJxpRHxfK+qLScX4a42/U2fTGShW5S02zbl8bPLAOrgCaeH0LKisNCQ9+9/9jZFSvu3f7LRkgg== X-Received: by 2002:a02:caa5:: with SMTP id e5mr8224600jap.159.1643212506916; Wed, 26 Jan 2022 07:55:06 -0800 (PST) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com. [209.85.166.47]) by smtp.gmail.com with ESMTPSA id z23sm3862335iol.11.2022.01.26.07.55.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jan 2022 07:55:06 -0800 (PST) Received: by mail-io1-f47.google.com with SMTP id h7so62512iof.3 for ; Wed, 26 Jan 2022 07:55:06 -0800 (PST) X-Received: by 2002:a02:7a4f:: with SMTP id z15mr10410746jad.50.1643212505706; Wed, 26 Jan 2022 07:55:05 -0800 (PST) MIME-Version: 1.0 References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-8-s.hauer@pengutronix.de> In-Reply-To: <20220126145549.617165-8-s.hauer@pengutronix.de> From: Doug Anderson Date: Wed, 26 Jan 2022 07:54:53 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 07/27] drm/rockchip: dw_hdmi: Use auto-generated tables To: Sascha Hauer Cc: dri-devel , Linux ARM , "open list:ARM/Rockchip SoC..." , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sascha Hauer , Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Peter Geis , Yakir Yang , =?UTF-8?Q?St=C3=A9phane_Marchesin?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220126_075508_484192_B095DC5F X-CRM114-Status: GOOD ( 22.34 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGksCgpPbiBXZWQsIEphbiAyNiwgMjAyMiBhdCA2OjU4IEFNIFNhc2NoYSBIYXVlciA8cy5oYXVl ckBwZW5ndXRyb25peC5kZT4gd3JvdGU6Cj4KPiBGcm9tOiBEb3VnbGFzIEFuZGVyc29uIDxkaWFu ZGVycyBhdCBjaHJvbWl1bS5vcmc+Cj4KPiBUaGUgcHJldmlvdXMgdGFibGVzIGZvciBtcGxsX2Nm ZyBhbmQgY3Vycl9jdHJsIHdlcmUgY3JlYXRlZCB1c2luZyB0aGUKPiAyMC1wYWdlcyBvZiBleGFt cGxlIHNldHRpbmdzIHByb3ZpZGVkIGJ5IHRoZSBQSFkgdmVuZG9yLiAgVGhvc2UKPiBleGFtcGxl IHNldHRpbmdzIHdlcmVuJ3QgcGFydGljdWxhcmx5IGRlbnNlLCBzbyB0aGVyZSB3ZXJlIHBsYWNl cwo+IHdoZXJlIHdlIHdlcmUgZ3Vlc3Npbmcgd2hhdCB0aGUgc2V0dGluZ3Mgd291bGQgYmUgZm9y IDEwLWJpdCBhbmQKPiAxMi1iaXQgKG5vdCB0aGF0IHdlIHVzZSB0aG9zZSBhbnl3YXkpLiAgSXQg d2FzIGFsc28gYWx3YXlzIGEgbG90IG9mCj4gZXh0cmEgd29yayBldmVyeSB0aW1lIHdlIHdhbnRl ZCB0byBhZGQgYSBuZXcgY2xvY2sgcmF0ZSBzaW5jZSB3ZSBoYWQKPiB0byBjcm9zcy1yZWZlcmVu Y2Ugc2V2ZXJhbCB0YWJsZXMuCj4KPiBJbiA8aHR0cDovL2Nyb3NyZXZpZXcuY29tLzI4NTg1NT4g SSd2ZSBnb25lIHRocm91Z2ggdGhlIHdvcmsgdG8gZmlndXJlCgpUaGUgYGNyb3NyZXZpZXcuY29t YCBzeW50YXggZG9lc24ndCBzZWVtIHRvIHdvcmsgYW55bW9yZS4gQ291bGQgbWF5YmUKdXBkYXRl IHRvIGh0dHBzOi8vY3JyZXYuY29tL2MvMjg1ODU1ID8KCj4gb3V0IGhvdyB0byBnZW5lcmF0ZSB0 aGlzIHRhYmxlIGF1dG9tYXRpY2FsbHkuICBMZXQncyBub3cgdXNlIHRoZQo+IGF1dG9tYXRpY2Fs bHkgZ2VuZXJhdGVkIHRhYmxlIGFuZCB0aGVuIHdlJ2xsIG5ldmVyIG5lZWQgdG8gbG9vayBhdCBp dAo+IGFnYWluLgo+Cj4gV2Ugb25seSBzdXBwb3J0IDgtYml0IG1vZGUgcmlnaHQgbm93IGFuZCBv bmx5IHN1cHBvcnQgYSBzbWFsbCBudW1iZXIKPiBvZiBjbG9jayByYXRlcyBhbmQgYW5kIEkndmUg dmVyaWZpZWQgdGhhdCB0aGUgb25seSA4LWJpdCByYXRlIHRoYXQgd2FzCj4gYWZmZWN0ZWQgd2Fz IDE0OC41LiAgVGhhdCBtb2RlIGFwcGVhcnMgdG8gaGF2ZSBiZWVuIHdyb25nIGluIHRoZSBvbGQK PiB0YWJsZS4KPgo+IENoYW5nZXMgc2luY2UgdjM6Cj4gLSBuZXcgcGF0Y2gKPgo+IFNpZ25lZC1v ZmYtYnk6IERvdWdsYXMgQW5kZXJzb24gPGRpYW5kZXJzIGF0IGNocm9taXVtLm9yZz4KPiBTaWdu ZWQtb2ZmLWJ5OiBZYWtpciBZYW5nIDx5a2sgYXQgcm9jay1jaGlwcy5jb20+CgpTaG91bGQgcHJv YmFibHkgY2hhbmdlIHRoZSAiYXQiIHRvICJAIiA/Cgo+IFJldmlld2VkLWJ5OiBTdMOpcGhhbmUg TWFyY2hlc2luIDxtYXJjaGV1IGF0IGNocm9taXVtLm9yZz4KCkluIGdlbmVyYWwgc2hvdWxkbid0 IGNhcnJ5IGRvd25zdHJlYW0gcmV2aWV3cyB3aGVuIHBvc3RpbmcgdXBzdHJlYW0KdW5sZXNzIHlv dSdyZSBjZXJ0YWluIHRoYXQgdGhlIHBlcnNvbiBpbnRlbmRlZCBpdC4uLgoKCkl0J3MgYmVlbiBh IGxvbmcgdGltZSwgYnV0IGluIGdlbmVyYWwgSSB0aGluayBJIHdhcyBmYWlybHkgY29uZmlkZW50 CmluIHRoZSBudW1iZXJzIHRoYXQgbXkgc2NyaXB0IHB1bXBlZCBvdXQsIGF0IGxlYXN0IGdpdmVu IHRoZSBjYXZlYXQgb2YKbm8gcGl4ZWwgcmVwZXRpdGlvbiBhbmQgOC1iaXQgb25seS4gVGhhdCBi ZWluZyBzYWlkLCBJIGRpZG4ndCBoYXZlIGFueQppbnNpZGUga25vd2xlZGdlIG9mIHRoZSBoYXJk d2FyZSBhbmQganVzdCBmaWd1cmVkIG91dCBmb3JtdWxhcyB0aGF0CnNlZW1lZCB0byBtYXRjaCB0 aGUgdGFibGUgdGhhdCBJIGhhZC4gWU1NVi4KCkknbGwgYWxzbyBzYXkgdGhhdCB3aGVuIEkgZGlk IGEgcmViYXNlIG9mIHZleXJvbiAocmszMjg4LWJhc2VkCkNocm9tZWJvb2spIHRvIDQuMTkgYWJv dXQgMi41IHllYXJzIGFnbywgSSBlbmRlZCB1cCBzcXVhc2hpbmcgc2V2ZXJhbApvZiB0aGVzZSBw YXRjaGVzIGludG8gMS4gVGhhdCBjYW4gYmUgZm91bmQgYXQKPGh0dHBzOi8vY3JyZXYuY29tL2Mv MTY2MTA1Nj4uIFRoYXQgYWxzbyBoYXMgZGV0YWlscyBhYm91dCB3aHkgc29tZSBvZgp0aGVzZSBw YXRjaGVzIG5ldmVyIG1hZGUgaXQgdXBzdHJlYW0uIFRoZSBtYWluIHJlYXNvbiwgYXQgbGVhc3Qg aW4gdGhlCmNhc2Ugb2YgcmszMjg4LCB3YXMgdGhlIFBMTCBzaGFyaW5nIHByb2JsZW0gdGhhdCBu b2JvZHkgZXZlciBzb2x2ZWQuCnJrMzI4OCBkaWRuJ3QgaGF2ZSBxdWl0ZSBlbm91Z2ggUExMcyBh bmQgdGh1cywgaWYgeW91IHdlcmUgdXNpbmcgYm90aApWT1BzLCBvbmUgb2YgdGhlIFZPUHMgd2Fz IGdvaW5nIHRvIGJlIHNldmVyZWx5IGxpbWl0ZWQgaW4gd2hhdCBwaXhlbApjbG9ja3MgaXQgY291 bGQgbWFrZS4gVGhlcmUgd2FzIG5vIGZyYW1ld29yayBkZWNpZGluZyB3aGljaCBWT1Agc2hvdWxk CmJlIGxpbWl0ZWQgYW5kIGhvdyB0aGUgc3lzdGVtIHNob3VsZCByZWFjdCB0byB0aGlzLi4uCgoK SW4gYW55IGNhc2UsIEknbSBwcmV0dHkgZmFyIGRpc2Nvbm5lY3RlZCBmcm9tIGFsbCB0aGlzIHN0 dWZmIG5vdywgYnV0Ckkgd2lzaCB5b3UgdGhlIGJlc3Qgb2YgbHVjayBpbiB0cnlpbmcgdG8gZ2V0 IGl0IGFsbCBzb2x2ZWQhCgotRG91ZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlw QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 118A0C28CF5 for ; Wed, 26 Jan 2022 17:08:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6G/sPUnLgnSbtbTzNPp+NjgrwOkZRPZbSLIQrOTgbxQ=; b=sO3WVL19PCvX0u RXm4+t/g0Peij/1WlB74UzssD9w1Jqn5m77afJ/WmSfcSY31JMiByHCSamKLuydcBCQDH+NRB/RtQ RYLERsGDXhF2q9osrd2aeB3X44xIP+3sVFWtk5UFDgDfE8ZkTsSj+C5kOPFn07ZgxofoXUmCNckBM lgZZ/3W3WWqisATZf0RD5pw4y2s+nmMZdAnlueyrbHw2hNRtzYjkE7iFJ3qpb5p4mbVjbiAwTIMet +kMge04yPRnIPJ7JzmO4kx6zFvIcuWuS0O3uMxWKpPMdd3KjSXnuem3K2ROUzbF3KJeIhKSDSm8g9 W16L3P/xY73d2jL2TpYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nClkc-00Crsm-2I; Wed, 26 Jan 2022 17:06:33 +0000 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCkdZ-00CRij-0C for linux-arm-kernel@lists.infradead.org; Wed, 26 Jan 2022 15:55:14 +0000 Received: by mail-io1-xd2b.google.com with SMTP id y84so119660iof.0 for ; Wed, 26 Jan 2022 07:55:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8N6pkwfXspakdaJZNWnP38Bamfx4gDdG3F4Wrj2z8a0=; b=R4PjleZoJRZEHoITMXop0eh4gJ/ykFxgKSZE/XIEndxWeSjox8Ho5Y5WSEwGWD5nwI 9IYUDjyO/sH115RZ8zr4aaHKv4uwuJ6DuRjt//KHrKEHmkUBteL2Q1nGUdQFKi1z9vuI qG8pW5RzxHr7VPzE3Xb0fueZxlRwCDsn2SfCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8N6pkwfXspakdaJZNWnP38Bamfx4gDdG3F4Wrj2z8a0=; b=hghIWyoy0pl/jl6Nn9L5Z/5s0+xEZhlFS9BncmRMTffVao+O0Z/iPxNORbXDkmfs4y nP0ku3Qn6x47dizWFn+fw1D9oHFqqPTz/EL6yMQ7VWYKVC61viU7CZVI0WP3UGxCsJCo dz8I6F3T6EiGf0YOo/CdsKZ8erlm4xB8RYsdIlCJ/J+tsoyi0kUPrIKoA58iFbHTwALj zXgVUS1Pi6F/GhYeSP6NCd4AbNQP7p1YFGIoaMgzbxE5loPiqrOqbD0m49oiSexFNa09 nKfxIvNx3WzXqsIU+ACKhpOeyPU8hYCoi/eqVePPf0n2IHWZgkpoe56EwC9rkwiMN21k Fa5g== X-Gm-Message-State: AOAM533puMhiex2ZABaT2EeS0jQDZG3bdI6dSQUOKbQuiIuu0TzBWQAJ KJzJtULYZZfAaDLLWcv+9Pd2bPif2R+Cyg== X-Google-Smtp-Source: ABdhPJxK9pehjUG4euzAdtdytIHhXMeS07GeJCpcsVeuhwB0SRIkOp+BjLD4voYdC7AQ+6QxM0dP7w== X-Received: by 2002:a02:6d0b:: with SMTP id m11mr12085825jac.108.1643212507558; Wed, 26 Jan 2022 07:55:07 -0800 (PST) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com. [209.85.166.52]) by smtp.gmail.com with ESMTPSA id c24sm2623131ioh.40.2022.01.26.07.55.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jan 2022 07:55:06 -0800 (PST) Received: by mail-io1-f52.google.com with SMTP id s18so11324698ioa.12 for ; Wed, 26 Jan 2022 07:55:06 -0800 (PST) X-Received: by 2002:a02:7a4f:: with SMTP id z15mr10410746jad.50.1643212505706; Wed, 26 Jan 2022 07:55:05 -0800 (PST) MIME-Version: 1.0 References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-8-s.hauer@pengutronix.de> In-Reply-To: <20220126145549.617165-8-s.hauer@pengutronix.de> From: Doug Anderson Date: Wed, 26 Jan 2022 07:54:53 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 07/27] drm/rockchip: dw_hdmi: Use auto-generated tables To: Sascha Hauer Cc: dri-devel , Linux ARM , "open list:ARM/Rockchip SoC..." , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sascha Hauer , Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Peter Geis , Yakir Yang , =?UTF-8?Q?St=C3=A9phane_Marchesin?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220126_075509_095864_07B47A9D X-CRM114-Status: GOOD ( 23.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBXZWQsIEphbiAyNiwgMjAyMiBhdCA2OjU4IEFNIFNhc2NoYSBIYXVlciA8cy5oYXVl ckBwZW5ndXRyb25peC5kZT4gd3JvdGU6Cj4KPiBGcm9tOiBEb3VnbGFzIEFuZGVyc29uIDxkaWFu ZGVycyBhdCBjaHJvbWl1bS5vcmc+Cj4KPiBUaGUgcHJldmlvdXMgdGFibGVzIGZvciBtcGxsX2Nm ZyBhbmQgY3Vycl9jdHJsIHdlcmUgY3JlYXRlZCB1c2luZyB0aGUKPiAyMC1wYWdlcyBvZiBleGFt cGxlIHNldHRpbmdzIHByb3ZpZGVkIGJ5IHRoZSBQSFkgdmVuZG9yLiAgVGhvc2UKPiBleGFtcGxl IHNldHRpbmdzIHdlcmVuJ3QgcGFydGljdWxhcmx5IGRlbnNlLCBzbyB0aGVyZSB3ZXJlIHBsYWNl cwo+IHdoZXJlIHdlIHdlcmUgZ3Vlc3Npbmcgd2hhdCB0aGUgc2V0dGluZ3Mgd291bGQgYmUgZm9y IDEwLWJpdCBhbmQKPiAxMi1iaXQgKG5vdCB0aGF0IHdlIHVzZSB0aG9zZSBhbnl3YXkpLiAgSXQg d2FzIGFsc28gYWx3YXlzIGEgbG90IG9mCj4gZXh0cmEgd29yayBldmVyeSB0aW1lIHdlIHdhbnRl ZCB0byBhZGQgYSBuZXcgY2xvY2sgcmF0ZSBzaW5jZSB3ZSBoYWQKPiB0byBjcm9zcy1yZWZlcmVu Y2Ugc2V2ZXJhbCB0YWJsZXMuCj4KPiBJbiA8aHR0cDovL2Nyb3NyZXZpZXcuY29tLzI4NTg1NT4g SSd2ZSBnb25lIHRocm91Z2ggdGhlIHdvcmsgdG8gZmlndXJlCgpUaGUgYGNyb3NyZXZpZXcuY29t YCBzeW50YXggZG9lc24ndCBzZWVtIHRvIHdvcmsgYW55bW9yZS4gQ291bGQgbWF5YmUKdXBkYXRl IHRvIGh0dHBzOi8vY3JyZXYuY29tL2MvMjg1ODU1ID8KCj4gb3V0IGhvdyB0byBnZW5lcmF0ZSB0 aGlzIHRhYmxlIGF1dG9tYXRpY2FsbHkuICBMZXQncyBub3cgdXNlIHRoZQo+IGF1dG9tYXRpY2Fs bHkgZ2VuZXJhdGVkIHRhYmxlIGFuZCB0aGVuIHdlJ2xsIG5ldmVyIG5lZWQgdG8gbG9vayBhdCBp dAo+IGFnYWluLgo+Cj4gV2Ugb25seSBzdXBwb3J0IDgtYml0IG1vZGUgcmlnaHQgbm93IGFuZCBv bmx5IHN1cHBvcnQgYSBzbWFsbCBudW1iZXIKPiBvZiBjbG9jayByYXRlcyBhbmQgYW5kIEkndmUg dmVyaWZpZWQgdGhhdCB0aGUgb25seSA4LWJpdCByYXRlIHRoYXQgd2FzCj4gYWZmZWN0ZWQgd2Fz IDE0OC41LiAgVGhhdCBtb2RlIGFwcGVhcnMgdG8gaGF2ZSBiZWVuIHdyb25nIGluIHRoZSBvbGQK PiB0YWJsZS4KPgo+IENoYW5nZXMgc2luY2UgdjM6Cj4gLSBuZXcgcGF0Y2gKPgo+IFNpZ25lZC1v ZmYtYnk6IERvdWdsYXMgQW5kZXJzb24gPGRpYW5kZXJzIGF0IGNocm9taXVtLm9yZz4KPiBTaWdu ZWQtb2ZmLWJ5OiBZYWtpciBZYW5nIDx5a2sgYXQgcm9jay1jaGlwcy5jb20+CgpTaG91bGQgcHJv YmFibHkgY2hhbmdlIHRoZSAiYXQiIHRvICJAIiA/Cgo+IFJldmlld2VkLWJ5OiBTdMOpcGhhbmUg TWFyY2hlc2luIDxtYXJjaGV1IGF0IGNocm9taXVtLm9yZz4KCkluIGdlbmVyYWwgc2hvdWxkbid0 IGNhcnJ5IGRvd25zdHJlYW0gcmV2aWV3cyB3aGVuIHBvc3RpbmcgdXBzdHJlYW0KdW5sZXNzIHlv dSdyZSBjZXJ0YWluIHRoYXQgdGhlIHBlcnNvbiBpbnRlbmRlZCBpdC4uLgoKCkl0J3MgYmVlbiBh IGxvbmcgdGltZSwgYnV0IGluIGdlbmVyYWwgSSB0aGluayBJIHdhcyBmYWlybHkgY29uZmlkZW50 CmluIHRoZSBudW1iZXJzIHRoYXQgbXkgc2NyaXB0IHB1bXBlZCBvdXQsIGF0IGxlYXN0IGdpdmVu IHRoZSBjYXZlYXQgb2YKbm8gcGl4ZWwgcmVwZXRpdGlvbiBhbmQgOC1iaXQgb25seS4gVGhhdCBi ZWluZyBzYWlkLCBJIGRpZG4ndCBoYXZlIGFueQppbnNpZGUga25vd2xlZGdlIG9mIHRoZSBoYXJk d2FyZSBhbmQganVzdCBmaWd1cmVkIG91dCBmb3JtdWxhcyB0aGF0CnNlZW1lZCB0byBtYXRjaCB0 aGUgdGFibGUgdGhhdCBJIGhhZC4gWU1NVi4KCkknbGwgYWxzbyBzYXkgdGhhdCB3aGVuIEkgZGlk IGEgcmViYXNlIG9mIHZleXJvbiAocmszMjg4LWJhc2VkCkNocm9tZWJvb2spIHRvIDQuMTkgYWJv dXQgMi41IHllYXJzIGFnbywgSSBlbmRlZCB1cCBzcXVhc2hpbmcgc2V2ZXJhbApvZiB0aGVzZSBw YXRjaGVzIGludG8gMS4gVGhhdCBjYW4gYmUgZm91bmQgYXQKPGh0dHBzOi8vY3JyZXYuY29tL2Mv MTY2MTA1Nj4uIFRoYXQgYWxzbyBoYXMgZGV0YWlscyBhYm91dCB3aHkgc29tZSBvZgp0aGVzZSBw YXRjaGVzIG5ldmVyIG1hZGUgaXQgdXBzdHJlYW0uIFRoZSBtYWluIHJlYXNvbiwgYXQgbGVhc3Qg aW4gdGhlCmNhc2Ugb2YgcmszMjg4LCB3YXMgdGhlIFBMTCBzaGFyaW5nIHByb2JsZW0gdGhhdCBu b2JvZHkgZXZlciBzb2x2ZWQuCnJrMzI4OCBkaWRuJ3QgaGF2ZSBxdWl0ZSBlbm91Z2ggUExMcyBh bmQgdGh1cywgaWYgeW91IHdlcmUgdXNpbmcgYm90aApWT1BzLCBvbmUgb2YgdGhlIFZPUHMgd2Fz IGdvaW5nIHRvIGJlIHNldmVyZWx5IGxpbWl0ZWQgaW4gd2hhdCBwaXhlbApjbG9ja3MgaXQgY291 bGQgbWFrZS4gVGhlcmUgd2FzIG5vIGZyYW1ld29yayBkZWNpZGluZyB3aGljaCBWT1Agc2hvdWxk CmJlIGxpbWl0ZWQgYW5kIGhvdyB0aGUgc3lzdGVtIHNob3VsZCByZWFjdCB0byB0aGlzLi4uCgoK SW4gYW55IGNhc2UsIEknbSBwcmV0dHkgZmFyIGRpc2Nvbm5lY3RlZCBmcm9tIGFsbCB0aGlzIHN0 dWZmIG5vdywgYnV0Ckkgd2lzaCB5b3UgdGhlIGJlc3Qgb2YgbHVjayBpbiB0cnlpbmcgdG8gZ2V0 IGl0IGFsbCBzb2x2ZWQhCgotRG91ZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=