From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings Date: Thu, 3 May 2018 08:01:27 -0700 Message-ID: References: <39b676d2ba7dac2436196cc5a090c6f151498dc8.1523673467.git.collinsd@codeaurora.org>

Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: David Collins Cc: Mark Brown , Liam Girdwood , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, Linux ARM , devicetree@vger.kernel.org, LKML , Rajendra Nayak , Stephen Boyd List-Id: linux-arm-msm@vger.kernel.org Hi, On Wed, May 2, 2018 at 5:13 PM, David Collins wrote: > On 05/02/2018 09:37 AM, Doug Anderson wrote: >> On Fri, Apr 13, 2018 at 7:50 PM, David Collins wrote: >>> +- vdd_l26-supply >>> +- vdd_lvs1_lvs2-supply >>> +- vdd_lvs1_lvs2-supply >>> + Usage: optional (PM8998 only) >>> + Value type: >>> + Definition: phandle of the parent supply regulator of one or more of the >>> + regulators for this PMIC. >> >> One small additional nit here is that "vdd_lvs1_lvs2-supply" is listed twice. > > I'll remove the duplicate. > > >> Also on the schematics (and in the PM8998 datasheet) I have this is >> "VIN_LVS_1_2". It seems like you should be consistent here and call >> this "vin-lvs-1-2-supply". > > I was trying to keep the naming consistent within device tree binding > documentation for LVS vs LDO and SMPS (e.g. 'vdd' vs 'vin' prefix). I > suppose that I can change this to match the hardware documentation pin > name. I can also change '_' to '-' in the supply names if that is preferred. I'd rather it match the docs. I personally have no idea for why the writer of the docs used "vdd" vs. "vin", but even if they had no good reason matching the docs makes this searchable. As far as the "_" to "-", Rob asked for that earlier in this thread and you says "I will change this on the next patch set." In general the desire to convert "_" to "-" makes this less searchable (since the docs use "_"), but that's the way device tree guys want it so so c'est la vie. Luckily it's easily to mentally change the "-"s back to "_"s when searching... -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 From: dianders@chromium.org (Doug Anderson) Date: Thu, 3 May 2018 08:01:27 -0700 Subject: [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings In-Reply-To: References: <39b676d2ba7dac2436196cc5a090c6f151498dc8.1523673467.git.collinsd@codeaurora.org>

Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Wed, May 2, 2018 at 5:13 PM, David Collins wrote: > On 05/02/2018 09:37 AM, Doug Anderson wrote: >> On Fri, Apr 13, 2018 at 7:50 PM, David Collins wrote: >>> +- vdd_l26-supply >>> +- vdd_lvs1_lvs2-supply >>> +- vdd_lvs1_lvs2-supply >>> + Usage: optional (PM8998 only) >>> + Value type: >>> + Definition: phandle of the parent supply regulator of one or more of the >>> + regulators for this PMIC. >> >> One small additional nit here is that "vdd_lvs1_lvs2-supply" is listed twice. > > I'll remove the duplicate. > > >> Also on the schematics (and in the PM8998 datasheet) I have this is >> "VIN_LVS_1_2". It seems like you should be consistent here and call >> this "vin-lvs-1-2-supply". > > I was trying to keep the naming consistent within device tree binding > documentation for LVS vs LDO and SMPS (e.g. 'vdd' vs 'vin' prefix). I > suppose that I can change this to match the hardware documentation pin > name. I can also change '_' to '-' in the supply names if that is preferred. I'd rather it match the docs. I personally have no idea for why the writer of the docs used "vdd" vs. "vin", but even if they had no good reason matching the docs makes this searchable. As far as the "_" to "-", Rob asked for that earlier in this thread and you says "I will change this on the next patch set." In general the desire to convert "_" to "-" makes this less searchable (since the docs use "_"), but that's the way device tree guys want it so so c'est la vie. Luckily it's easily to mentally change the "-"s back to "_"s when searching... -Doug