From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C0B7C433EF for ; Fri, 1 Oct 2021 18:03:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A74D61A10 for ; Fri, 1 Oct 2021 18:03:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355647AbhJASE4 (ORCPT ); Fri, 1 Oct 2021 14:04:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355592AbhJASEy (ORCPT ); Fri, 1 Oct 2021 14:04:54 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BE40C061775 for ; Fri, 1 Oct 2021 11:03:10 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id 134so12608284iou.12 for ; Fri, 01 Oct 2021 11:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TL04/DBPEoOSN56nSu3eaqiiO8NlK2fOuX7kmrPsg2w=; b=DRsDMqGo5t/bxn9+5wBzcERkuPc5KHDjQdwCt2EXk2REWJWg+v7NDlDKBEdVOQV8Tr rQiDclsnWhqlLo4weSCvtBOjuEtmMTeV0JLQ1zReAAvXljaJID8LuFvXtejnhGd9SZ7o pK5cJL6I4QrcjwMawjpp8sJMzu1gxIxRLfMuc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TL04/DBPEoOSN56nSu3eaqiiO8NlK2fOuX7kmrPsg2w=; b=sT0vL2Ne3iZUfeAqoZrulKeEmHTp42/7X0tYHVfdZfq25IrIloT0ySrc4yP8uo1uKI mnhuEQo3wsNTLc9IlxLiorOpfzpwQLrfboClnDXnMmFD0VHsfEuU4EJSAXLI+d51c+Yn L3kLxYvVzJBm4ggz/CcHHpbi71T7CItJ8wroCuNd+AMXjcpd/RpbCQ/la/Y4e4o1mnAS M8l7G3NZxesDfiXE6tOD5X4kprIJObi1yusIfI3YnM6ejlTfFoTf21tEOd/5J59R+Is2 /TCb9UY4vU9d4K9wnMaa0dMfq8NznYuqb79tEzgVmmT1jIa5L350YH0kdmtEShVR/Tqv WAmA== X-Gm-Message-State: AOAM533P6LaEfcdlI0AEje/byqYecWQ/zpzYWwtyKdD2EWFNKCGKPdJ1 mJz1yYabsx3JclFwLaDEWeMH/VZWRLNg8Q== X-Google-Smtp-Source: ABdhPJwzDDDweNSrSs4jtohsCN5Qwgg1dMhInRCwuNmiCUR6L/C+Ld1vG+69nNA/mlPAdumdUJIPZA== X-Received: by 2002:a6b:3bd1:: with SMTP id i200mr517538ioa.190.1633111389784; Fri, 01 Oct 2021 11:03:09 -0700 (PDT) Received: from mail-il1-f176.google.com (mail-il1-f176.google.com. [209.85.166.176]) by smtp.gmail.com with ESMTPSA id a3sm1424866ilr.29.2021.10.01.11.03.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 11:03:07 -0700 (PDT) Received: by mail-il1-f176.google.com with SMTP id j15so11434678ila.6 for ; Fri, 01 Oct 2021 11:03:06 -0700 (PDT) X-Received: by 2002:a05:6e02:20eb:: with SMTP id q11mr10049918ilv.165.1633111385834; Fri, 01 Oct 2021 11:03:05 -0700 (PDT) MIME-Version: 1.0 References: <20210920225801.227211-1-robdclark@gmail.com> <20210920225801.227211-4-robdclark@gmail.com> In-Reply-To: From: Doug Anderson Date: Fri, 1 Oct 2021 11:02:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support To: Laurent Pinchart Cc: Rob Clark , dri-devel , freedreno , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Sep 23, 2021 at 7:26 PM Laurent Pinchart wrote: > > > > > err_conn_init: > > > > drm_dp_aux_unregister(&pdata->aux); > > > > return ret; > > > > @@ -792,9 +790,30 @@ static void ti_sn_bridge_set_dsi_rate(struct ti_sn65dsi86 *pdata) > > > > regmap_write(pdata->regmap, SN_DSIA_CLK_FREQ_REG, val); > > > > } > > > > > > > > +/* > > > > + * Find the connector and fish out the bpc from display_info. It would > > > > + * be nice if we could get this instead from drm_bridge_state, but that > > > > + * doesn't yet appear to be the case. > > > > > > You already have a bus format in the bridge state, from which you can > > > derive the bpp. Could you give it a try ? > > > > Possibly the bridge should be converted to ->atomic_enable(), etc.. > > I'll leave that for another time > > It should be fairly straightforward, and would avoid the hack below. Given this point of controversy, my inclination is to wait and not apply this patch now. I don't think there's anything urgent here, right? Worst case eventually Laurent might pick it up in his patch series? At least we know it will work with the MSM driver once patch #1 lands. :-) -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B26C0C433F5 for ; Fri, 1 Oct 2021 18:03:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82F5A61A10 for ; Fri, 1 Oct 2021 18:03:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 82F5A61A10 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B37F66EEB6; Fri, 1 Oct 2021 18:03:12 +0000 (UTC) Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by gabe.freedesktop.org (Postfix) with ESMTPS id 177CD6EEB0 for ; Fri, 1 Oct 2021 18:03:11 +0000 (UTC) Received: by mail-io1-xd30.google.com with SMTP id n71so12735673iod.0 for ; Fri, 01 Oct 2021 11:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TL04/DBPEoOSN56nSu3eaqiiO8NlK2fOuX7kmrPsg2w=; b=DRsDMqGo5t/bxn9+5wBzcERkuPc5KHDjQdwCt2EXk2REWJWg+v7NDlDKBEdVOQV8Tr rQiDclsnWhqlLo4weSCvtBOjuEtmMTeV0JLQ1zReAAvXljaJID8LuFvXtejnhGd9SZ7o pK5cJL6I4QrcjwMawjpp8sJMzu1gxIxRLfMuc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TL04/DBPEoOSN56nSu3eaqiiO8NlK2fOuX7kmrPsg2w=; b=vULSp93tPXwiw5nd7VxoMDDFR7myFfchzOGc+MGKomr5rNUcXEP9Rx0PaI9C/4Vclr bbv1xCFqaM6ZwKjIMpP5Buoxrbm9kWn8hiw//7xWkLDgscm0s8TrrgFRnWHBpYQYoW63 OCNgCgz4Hk7rbfscKptX27UXbBReOZQLerLP/ivVnh531B4J4z40pMPNpW9C+9k1xwPe /Em/znzOnhAsHTDLp2fjQEQxvj8U/ergtHDeqe3AOzHEwhC4YY5Sb6WeStMqOn/06iKC Wckh/1Bm9g+E+BAuEo7U77Y1iv9xVzHs/hBq9g2mByhRZzPNMU2pRJPQeyoGawK5oX58 I4AQ== X-Gm-Message-State: AOAM533B9X8RO8szxx5StwU98ZSY35yeb96wsxR21+ygdowp2ZDZpd8J uKkhy+BUw65JEktVYQstTpkGeCbqYTpzfg== X-Google-Smtp-Source: ABdhPJwirXnWzM4B0z7yd84DOFcIV9CzRKe/nmisrBzmixwZK1hUVxXn18cuHTrtrx8+RRviSkwtPQ== X-Received: by 2002:a02:23c3:: with SMTP id u186mr4189699jau.34.1633111390038; Fri, 01 Oct 2021 11:03:10 -0700 (PDT) Received: from mail-il1-f169.google.com (mail-il1-f169.google.com. [209.85.166.169]) by smtp.gmail.com with ESMTPSA id e13sm4051640iod.36.2021.10.01.11.03.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 11:03:07 -0700 (PDT) Received: by mail-il1-f169.google.com with SMTP id d11so11423019ilc.8 for ; Fri, 01 Oct 2021 11:03:06 -0700 (PDT) X-Received: by 2002:a05:6e02:20eb:: with SMTP id q11mr10049918ilv.165.1633111385834; Fri, 01 Oct 2021 11:03:05 -0700 (PDT) MIME-Version: 1.0 References: <20210920225801.227211-1-robdclark@gmail.com> <20210920225801.227211-4-robdclark@gmail.com> In-Reply-To: From: Doug Anderson Date: Fri, 1 Oct 2021 11:02:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support To: Laurent Pinchart Cc: Rob Clark , dri-devel , freedreno , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , open list Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Thu, Sep 23, 2021 at 7:26 PM Laurent Pinchart wrote: > > > > > err_conn_init: > > > > drm_dp_aux_unregister(&pdata->aux); > > > > return ret; > > > > @@ -792,9 +790,30 @@ static void ti_sn_bridge_set_dsi_rate(struct ti_sn65dsi86 *pdata) > > > > regmap_write(pdata->regmap, SN_DSIA_CLK_FREQ_REG, val); > > > > } > > > > > > > > +/* > > > > + * Find the connector and fish out the bpc from display_info. It would > > > > + * be nice if we could get this instead from drm_bridge_state, but that > > > > + * doesn't yet appear to be the case. > > > > > > You already have a bus format in the bridge state, from which you can > > > derive the bpp. Could you give it a try ? > > > > Possibly the bridge should be converted to ->atomic_enable(), etc.. > > I'll leave that for another time > > It should be fairly straightforward, and would avoid the hack below. Given this point of controversy, my inclination is to wait and not apply this patch now. I don't think there's anything urgent here, right? Worst case eventually Laurent might pick it up in his patch series? At least we know it will work with the MSM driver once patch #1 lands. :-) -Doug