All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sm8250: add pinctrl for SPI using GPIO as a CS
Date: Fri, 5 Feb 2021 07:00:06 -0800	[thread overview]
Message-ID: <CAD=FV=UYmv-PH-m4T6RcuW1JuQ-fCZ2Lg6gCCUJ5xquT1NP1jA@mail.gmail.com> (raw)
In-Reply-To: <YByQizVTnj2uTNt2@builder.lan>

Hi,

On Thu, Feb 4, 2021 at 4:25 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> > > > +                             mux {
> > >
> > > Rather than splitting the properties in {mux, cs, config} I think it
> > > makes more sense to split them in {spi, cs} or something like that.
> >
> > In general pinconf doesn't belong in the SoC dts file.  If there's no
> > reason to change it seems like this should match what sc7180 did.
> >
>
> Right, but I still would prefer the pinctrl state to be split by
> function/pins, rather than pinmux vs pinconf. That way it's natural to
> add pinconf properties to the various functional parts (i.e. bias or
> drive-strength for the spi pins vs cs).
>
> Do you have any concerns with this?

I read this a few times and I'm not exactly sure what you're
proposing.  Can you provide an example of what you want it to look
like in this case?

-Doug

  reply	other threads:[~2021-02-05 22:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 20:49 [PATCH 1/2] arm64: dts: qcom: sm8250: add pinctrl for SPI using GPIO as a CS Dmitry Baryshkov
2021-02-04 20:49 ` [PATCH 2/2] arm64: dts: qcom: qrb5165-rb5: switch into using GPIO for SPI0 CS Dmitry Baryshkov
2021-02-04 23:07 ` [PATCH 1/2] arm64: dts: qcom: sm8250: add pinctrl for SPI using GPIO as a CS Bjorn Andersson
2021-02-04 23:31   ` Doug Anderson
2021-02-05  0:08     ` Dmitry Baryshkov
2021-02-05  0:25     ` Bjorn Andersson
2021-02-05 15:00       ` Doug Anderson [this message]
2021-02-05 16:48         ` Bjorn Andersson
2021-02-08 15:58           ` Doug Anderson
2021-02-08 18:04             ` Bjorn Andersson
2021-02-09 10:21               ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=UYmv-PH-m4T6RcuW1JuQ-fCZ2Lg6gCCUJ5xquT1NP1jA@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.