From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752446AbcF3WkE (ORCPT ); Thu, 30 Jun 2016 18:40:04 -0400 Received: from mail-vk0-f45.google.com ([209.85.213.45]:36020 "EHLO mail-vk0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbcF3WkC (ORCPT ); Thu, 30 Jun 2016 18:40:02 -0400 MIME-Version: 1.0 In-Reply-To: <2709691.LCsUme3dJo@phil> References: <1467251760-14695-1-git-send-email-wxt@rock-chips.com> <2709691.LCsUme3dJo@phil> From: Doug Anderson Date: Thu, 30 Jun 2016 15:32:01 -0700 X-Google-Sender-Auth: 23Tolrvk5ZRf_kjTQ-4fmQRCNRU Message-ID: Subject: Re: [PATCH] arm64: dts: rockchip: add the power domain node for rk3399 To: Heiko Stuebner Cc: Caesar Wang , Xu Jianqun , Brian Norris , "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Elaine Zhang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Jun 30, 2016 at 2:57 PM, Heiko Stuebner wrote: >> It looks like there are also more power domains that you haven't >> listed here (like PD_GMAC, for instance, or PD_CORE_L). Are you >> planning to add those in a followon patch? > > that reminds me, nodes with a reg property should have the base address in > the node name as well. Using the constant works nicely, as can be seen on > the rk3288 where we have for example: > > pd_vio@RK3288_PD_VIO I was wondering about that. The device tree bindings are similarly missing the reg from the example. I'm curious: for sorting purposes, are you supposed to know the underlying integer and use that for sorting, or sort by the name of the #define? -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [PATCH] arm64: dts: rockchip: add the power domain node for rk3399 Date: Thu, 30 Jun 2016 15:32:01 -0700 Message-ID: References: <1467251760-14695-1-git-send-email-wxt@rock-chips.com> <2709691.LCsUme3dJo@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2709691.LCsUme3dJo@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Heiko Stuebner Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Elaine Zhang , Brian Norris , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "open list:ARM/Rockchip SoC..." , Xu Jianqun , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Caesar Wang List-Id: devicetree@vger.kernel.org Hi, On Thu, Jun 30, 2016 at 2:57 PM, Heiko Stuebner wrote: >> It looks like there are also more power domains that you haven't >> listed here (like PD_GMAC, for instance, or PD_CORE_L). Are you >> planning to add those in a followon patch? > > that reminds me, nodes with a reg property should have the base address in > the node name as well. Using the constant works nicely, as can be seen on > the rk3288 where we have for example: > > pd_vio@RK3288_PD_VIO I was wondering about that. The device tree bindings are similarly missing the reg from the example. I'm curious: for sorting purposes, are you supposed to know the underlying integer and use that for sorting, or sort by the name of the #define? -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 From: dianders@chromium.org (Doug Anderson) Date: Thu, 30 Jun 2016 15:32:01 -0700 Subject: [PATCH] arm64: dts: rockchip: add the power domain node for rk3399 In-Reply-To: <2709691.LCsUme3dJo@phil> References: <1467251760-14695-1-git-send-email-wxt@rock-chips.com> <2709691.LCsUme3dJo@phil> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thu, Jun 30, 2016 at 2:57 PM, Heiko Stuebner wrote: >> It looks like there are also more power domains that you haven't >> listed here (like PD_GMAC, for instance, or PD_CORE_L). Are you >> planning to add those in a followon patch? > > that reminds me, nodes with a reg property should have the base address in > the node name as well. Using the constant works nicely, as can be seen on > the rk3288 where we have for example: > > pd_vio at RK3288_PD_VIO I was wondering about that. The device tree bindings are similarly missing the reg from the example. I'm curious: for sorting purposes, are you supposed to know the underlying integer and use that for sorting, or sort by the name of the #define? -Doug