From: Doug Anderson <dianders@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: sc7180: Add CoachZ rev3
Date: Tue, 16 Mar 2021 10:11:53 -0700 [thread overview]
Message-ID: <CAD=FV=UbwiQEq_C_y7P9D-L9Gyb9tpjaqJZ8ZgHCaW=xwDp6xQ@mail.gmail.com> (raw)
In-Reply-To: <20210315181509.v3.3.I95b8a63103b77cab6a7cf9c150f0541db57fda98@changeid>
Hi,
On Mon, Mar 15, 2021 at 6:15 PM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> CoachZ rev3 uses a 100k NTC thermistor for the charger temperatures,
> instead of the 47k NTC that is stuffed in earlier revisions. Add .dts
> files for rev3.
>
> The 47k NTC currently isn't supported by the PM6150 ADC driver.
> Disable the charger thermal zone for rev1 and rev2 to avoid the use
> of bogus temperature values.
>
> This also gets rid of the explicit DT files for rev2 and handles
> rev2 in the rev1 .dts instead. There was some back and forth
> downstream involving the 'dmic_clk_en' pin, after that was sorted
> out the DT for rev1 and rev2 is the same.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
> Changes in v3:
> - get rid of separate .dts for rev2
>
> Changes in v2:
> - added CoachZ rev3
> - updated subject and commit message
>
> arch/arm64/boot/dts/qcom/Makefile | 4 ++--
> .../boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dts | 4 ++--
> .../boot/dts/qcom/sc7180-trogdor-coachz-r1.dts | 13 +++++++++++--
> ...-r2-lte.dts => sc7180-trogdor-coachz-r3-lte.dts} | 6 +++---
> ...r-coachz-r2.dts => sc7180-trogdor-coachz-r3.dts} | 4 ++--
> 5 files changed, 20 insertions(+), 11 deletions(-)
Looks keen to me now, thanks!
Reviewed-by: Douglas Anderson <dianders@chromium.org>
prev parent reply other threads:[~2021-03-16 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 1:15 [PATCH v3 0/3] arm64: dts: qcom: sc7180: Disable the charger thermal zone on more trogdor boards Matthias Kaehlcke
2021-03-16 1:15 ` [PATCH v3 1/3] arm64: dts: qcom: sc7180: lazor: Simplify disabling of charger thermal zone Matthias Kaehlcke
2021-03-16 1:15 ` [PATCH v3 2/3] arm64: dts: qcom: sc7180: Add pompom rev3 Matthias Kaehlcke
2021-03-16 17:09 ` Doug Anderson
2021-03-19 15:12 ` Doug Anderson
2021-03-22 16:26 ` Matthias Kaehlcke
2021-03-16 1:15 ` [PATCH v3 3/3] arm64: dts: qcom: sc7180: Add CoachZ rev3 Matthias Kaehlcke
2021-03-16 17:11 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UbwiQEq_C_y7P9D-L9Gyb9tpjaqJZ8ZgHCaW=xwDp6xQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.