From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] clk: rockchip: add a dummy clock for the watchdog pclk on rk3288
Date: Wed, 21 Jan 2015 15:30:13 -0800 [thread overview]
Message-ID: <CAD=FV=UhOAdCZNKdKu3d-gj4JB9Vcf+D3bJJ2_SMrfj_k4NmKg@mail.gmail.com> (raw)
In-Reply-To: <40627478.oB4De9HGiG@phil>
Heiko,
On Wed, Jan 21, 2015 at 11:56 AM, Heiko St?bner <heiko@sntech.de> wrote:
> The pclk supplying the watchdog is controlled via the SGRF register area.
> Currently we don't have any clock-type handling external clock bits like
> this one. Additionally the SGRF isn't even writable in every boot mode.
>
> But still the clock control is available and in the future someone might
> want to use it. Therefore define a simple clock for the time being so
> that the watchdog driver can read its rate.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/clk/rockchip/clk-rk3288.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Doug Anderson <dianders@chromium.org>
On rk3288 on a 3.14 kernel with backports, I tested this and confirmed
that the clock rate was right (when programmed to ~43 seconds, the
watchdog caused a reboot when not patted for ~43 seconds).
Tested-by: Doug Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2015-01-21 23:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 19:54 [PATCH 0/3] ARM: rockchip: provide the watchdog with a clock Heiko Stübner
2015-01-21 19:55 ` [PATCH 1/3] clk: rockchip: add id for watchdog pclk on rk3288 Heiko Stübner
2015-01-21 23:28 ` Doug Anderson
2015-01-21 19:56 ` [PATCH 2/3] clk: rockchip: add a dummy clock for the " Heiko Stübner
2015-01-21 23:30 ` Doug Anderson [this message]
2015-01-21 19:56 ` [PATCH 3/3] ARM: dts: rockchip: add rk3288 watchdog clock Heiko Stübner
2015-01-21 23:30 ` Doug Anderson
2015-01-28 10:15 ` [PATCH 0/3] ARM: rockchip: provide the watchdog with a clock Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UhOAdCZNKdKu3d-gj4JB9Vcf+D3bJJ2_SMrfj_k4NmKg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.