From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA4CC4320E for ; Thu, 12 Aug 2021 16:00:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CA726103E for ; Thu, 12 Aug 2021 16:00:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238518AbhHLQA4 (ORCPT ); Thu, 12 Aug 2021 12:00:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238438AbhHLQAz (ORCPT ); Thu, 12 Aug 2021 12:00:55 -0400 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34D1EC061756 for ; Thu, 12 Aug 2021 09:00:30 -0700 (PDT) Received: by mail-il1-x12d.google.com with SMTP id f15so3508253ilk.4 for ; Thu, 12 Aug 2021 09:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rkJ9eY9sNpdQyMVe+0pcG6m3ooB5K5M6INJoQWT+o/s=; b=GjuNVqDaRiqBz4zyK3V+2n5ScpxGtvZN3wriHUi73F3HvZgp8MxBgFES6Be6wbG5m0 GSxHwamV94HZmZTH8PfGJhxOIGpstPYtiq6pZsX0M7UqSaCCe1EiGRggq5unN6IQSwxU Jj9XsqDEaiovSVkXYaqxVSyDGOCN4INNyRZ3A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rkJ9eY9sNpdQyMVe+0pcG6m3ooB5K5M6INJoQWT+o/s=; b=Nbb/XFaecm6m+ckLs3UoFv8CiF8Sy+p8JWasgrecoyK5mM8rXGZwHuspzntlJDl4j8 AIAe4zViOa9IviuzG/MAYdENBMYI489mM144o1cKiJL6QhCC0mWEN5m/1s6/91FW6at5 SusXowiLZ1ACxAGzdawrZH4qUJ47ejZpXnLz0hjuKTnsY4et9B0wBqBroFykD8AL2cMq LIHSzq+dGqTKO3wygpEgq+q5bygpLcj6PvL8PPprHs95yh8UPzr95YfnlkD/0WIrit1Y jCu8t7OsEH4EBULw3mJP6qO5UySoIqU6PKuTb9W7wln/xPlsNwjz2rFzyWg1RepppofM WoKQ== X-Gm-Message-State: AOAM530tbiFsYk54wk+GqKs5Wcg6mQV5+2Ll5Pkkq/WAslR+4cKeeuPN TvjNP5eUGtR/+vDLpSIxG9DqL9VcwU+m1A== X-Google-Smtp-Source: ABdhPJw7vqnzU7g4/wEYmVuQktZxa67o+z961hJXGXdR8Z4dVN6ZxXlNlpjwHNCENZKwNd2P8tvdNA== X-Received: by 2002:a92:194c:: with SMTP id e12mr3222005ilm.199.1628784029426; Thu, 12 Aug 2021 09:00:29 -0700 (PDT) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com. [209.85.166.53]) by smtp.gmail.com with ESMTPSA id u16sm1448105iob.41.2021.08.12.09.00.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Aug 2021 09:00:27 -0700 (PDT) Received: by mail-io1-f53.google.com with SMTP id q16so6736690ioj.0 for ; Thu, 12 Aug 2021 09:00:27 -0700 (PDT) X-Received: by 2002:a05:6602:713:: with SMTP id f19mr3710787iox.140.1628784026906; Thu, 12 Aug 2021 09:00:26 -0700 (PDT) MIME-Version: 1.0 References: <20210730212625.3071831-1-dianders@chromium.org> In-Reply-To: From: Doug Anderson Date: Thu, 12 Aug 2021 09:00:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/6] eDP: Support probing eDP panels dynamically instead of hardcoding To: Sam Ravnborg Cc: Thierry Reding , Rob Herring , Thomas Zimmermann , Daniel Vetter , dri-devel , linux-arm-msm , Maarten Lankhorst , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , David Airlie , Bjorn Andersson , Maxime Ripard , Steev Klimaszewski , Linus W , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Thu, Aug 12, 2021 at 2:38 AM Sam Ravnborg wrote: > > Hi Doug, > On Mon, Aug 09, 2021 at 03:18:03PM -0700, Doug Anderson wrote: > > Hi, > > > > On Tue, Aug 3, 2021 at 1:41 PM Sam Ravnborg wrote: > > > > > > Hi Douglas, > > > > > > On Fri, Jul 30, 2021 at 02:26:19PM -0700, Douglas Anderson wrote: > > > > The goal of this patch series is to move away from hardcoding exact > > > > eDP panels in device tree files. As discussed in the various patches > > > > in this series (I'm not repeating everything here), most eDP panels > > > > are 99% probable and we can get that last 1% by allowing two "power > > > > up" delays to be specified in the device tree file and then using the > > > > panel ID (found in the EDID) to look up additional power sequencing > > > > delays for the panel. > > > > > > Have you considered a new driver for edp panels? > > > panel-edp.c? > > > > > > There will be some duplicate code from pnale-simple - but the same can > > > be said by the other panel drivers too. > > > In the end I think it is better to separate them so we end up with two > > > less complex panel drivers rather than one do-it-all panel driver. > > > > > > I have not looked in detail how this would look like, but my first > > > impression is that we should split it out. > > > > I certainly could, but my argument against it is that really it's the > > exact same set of eDP panels that would be supported by both drivers. > > The idea was to move all eDP panels to the new driver. > > My hope it that we can make panel-simple handle a more more narrow set > of panels. eDP capable displays are IMO not simple panels. Ah! OK, this makes sense. I can work on this, though it might be a short while before I can. I think moving all eDP panels out of panel-simple.c to something like panel-simple-edp.c makes sense. It will be a patch that will be very hard to cherry-pick anywhere since it will conflict with everything but it should be doable. > Likewise DSI capable panels could also be pulled out of panel-simple. At the moment I haven't done much with DSI panels so I might leave them in panel-simple for now. I'll evaluate to see how nasty it would be for me to try this. > This would continue to duplicate some code - but we have a lot of > duplicated code across the various panels and the best way forward > would be to implement more helpers that can be used by the drivers. > > Sam - who is trying to recover form the deadly man flu... Feel better! -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0461FC4320A for ; Thu, 12 Aug 2021 16:00:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76D4F60FC0 for ; Thu, 12 Aug 2021 16:00:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 76D4F60FC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 98C546E42D; Thu, 12 Aug 2021 16:00:31 +0000 (UTC) Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 994686E42A for ; Thu, 12 Aug 2021 16:00:29 +0000 (UTC) Received: by mail-il1-x130.google.com with SMTP id v2so1303886ilg.12 for ; Thu, 12 Aug 2021 09:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rkJ9eY9sNpdQyMVe+0pcG6m3ooB5K5M6INJoQWT+o/s=; b=GjuNVqDaRiqBz4zyK3V+2n5ScpxGtvZN3wriHUi73F3HvZgp8MxBgFES6Be6wbG5m0 GSxHwamV94HZmZTH8PfGJhxOIGpstPYtiq6pZsX0M7UqSaCCe1EiGRggq5unN6IQSwxU Jj9XsqDEaiovSVkXYaqxVSyDGOCN4INNyRZ3A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rkJ9eY9sNpdQyMVe+0pcG6m3ooB5K5M6INJoQWT+o/s=; b=bOHorDoHXk5Oy03Nv64QX73x1GVvGJRoxH/r1H+LOQddX6d9ILFPxw6PXv+DK6GJbB +AA6D3fXWVHCZ8JV8GkSwT3qyycEuJAXGpzGfNOvOhl10Gq8m7x4q0615xCRhnNnOTgN F2ab4lPvpE4VNBCKDG77BT2RIWSU4JJH/R9H0rp0sLXUvYm7+ro6UnAp8Zn4WeN/16/G BxVcy+yCbj96Xq8R8MEfTXwJsi76NAsWoGsPqWKZefgY1uUadZ8lF/3CMr7wbramIxhe 5WqhwRT+rHWDwK/6FGQxvxjvlIM7lDxi8jmXS/habSrAqqmX6lWKkjo9jociObLbqETc KZMw== X-Gm-Message-State: AOAM53228yVBz9qu6ZR4Acbtm7B1p61+CXUTrrgnC5W3J/ucJce55pU7 HHki8Q5Q6xOmwbsvALbFtK6IlIXF7BjbjQ== X-Google-Smtp-Source: ABdhPJxYhu4k8we8gExfzrlAs9nNK1VCtaf64zIzJbEYTCN2KXRt6rdihq3acj8lwmidtgfsGwEKbQ== X-Received: by 2002:a92:6408:: with SMTP id y8mr3485185ilb.84.1628784028648; Thu, 12 Aug 2021 09:00:28 -0700 (PDT) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com. [209.85.166.42]) by smtp.gmail.com with ESMTPSA id x6sm1517078iop.30.2021.08.12.09.00.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Aug 2021 09:00:27 -0700 (PDT) Received: by mail-io1-f42.google.com with SMTP id x10so9055769iop.13 for ; Thu, 12 Aug 2021 09:00:27 -0700 (PDT) X-Received: by 2002:a05:6602:713:: with SMTP id f19mr3710787iox.140.1628784026906; Thu, 12 Aug 2021 09:00:26 -0700 (PDT) MIME-Version: 1.0 References: <20210730212625.3071831-1-dianders@chromium.org> In-Reply-To: From: Doug Anderson Date: Thu, 12 Aug 2021 09:00:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/6] eDP: Support probing eDP panels dynamically instead of hardcoding To: Sam Ravnborg Cc: Thierry Reding , Rob Herring , Thomas Zimmermann , Daniel Vetter , dri-devel , linux-arm-msm , Maarten Lankhorst , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , David Airlie , Bjorn Andersson , Maxime Ripard , Steev Klimaszewski , Linus W , LKML Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Thu, Aug 12, 2021 at 2:38 AM Sam Ravnborg wrote: > > Hi Doug, > On Mon, Aug 09, 2021 at 03:18:03PM -0700, Doug Anderson wrote: > > Hi, > > > > On Tue, Aug 3, 2021 at 1:41 PM Sam Ravnborg wrote: > > > > > > Hi Douglas, > > > > > > On Fri, Jul 30, 2021 at 02:26:19PM -0700, Douglas Anderson wrote: > > > > The goal of this patch series is to move away from hardcoding exact > > > > eDP panels in device tree files. As discussed in the various patches > > > > in this series (I'm not repeating everything here), most eDP panels > > > > are 99% probable and we can get that last 1% by allowing two "power > > > > up" delays to be specified in the device tree file and then using the > > > > panel ID (found in the EDID) to look up additional power sequencing > > > > delays for the panel. > > > > > > Have you considered a new driver for edp panels? > > > panel-edp.c? > > > > > > There will be some duplicate code from pnale-simple - but the same can > > > be said by the other panel drivers too. > > > In the end I think it is better to separate them so we end up with two > > > less complex panel drivers rather than one do-it-all panel driver. > > > > > > I have not looked in detail how this would look like, but my first > > > impression is that we should split it out. > > > > I certainly could, but my argument against it is that really it's the > > exact same set of eDP panels that would be supported by both drivers. > > The idea was to move all eDP panels to the new driver. > > My hope it that we can make panel-simple handle a more more narrow set > of panels. eDP capable displays are IMO not simple panels. Ah! OK, this makes sense. I can work on this, though it might be a short while before I can. I think moving all eDP panels out of panel-simple.c to something like panel-simple-edp.c makes sense. It will be a patch that will be very hard to cherry-pick anywhere since it will conflict with everything but it should be doable. > Likewise DSI capable panels could also be pulled out of panel-simple. At the moment I haven't done much with DSI panels so I might leave them in panel-simple for now. I'll evaluate to see how nasty it would be for me to try this. > This would continue to duplicate some code - but we have a lot of > duplicated code across the various panels and the best way forward > would be to implement more helpers that can be used by the drivers. > > Sam - who is trying to recover form the deadly man flu... Feel better! -Doug