From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 217DCC5ACC6 for ; Tue, 16 Oct 2018 23:43:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C20952148C for ; Tue, 16 Oct 2018 23:43:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="W8Guo2Fn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C20952148C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727253AbeJQHgV (ORCPT ); Wed, 17 Oct 2018 03:36:21 -0400 Received: from mail-ua1-f65.google.com ([209.85.222.65]:34541 "EHLO mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727020AbeJQHgV (ORCPT ); Wed, 17 Oct 2018 03:36:21 -0400 Received: by mail-ua1-f65.google.com with SMTP id k4so4076546uao.1 for ; Tue, 16 Oct 2018 16:43:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uFcRdt04RpB+VehUbvDFJ90UxlQzQWDTHC1WwHYUXxs=; b=W8Guo2Fnm3TkODJs+14L3dsR3F+pRAxaxqOkJIpMQ58Dc+gxFvEt4eY0yLr+XEbMmo Uz2IbQ5Su+VzM8V9UcuSncwJNLbI59aliE34PMeyGsCtszlPBHUmfWtB5zeVWKdpgtRk 4Jh55IzzqBg7tkl7eyWAqpPyHqVgXwNMuB0VA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uFcRdt04RpB+VehUbvDFJ90UxlQzQWDTHC1WwHYUXxs=; b=BSAiW2CBX9NemrO2wzkanTxFHbFnb/Nx+IsFgRS410SXhsCGfOpTvO9Z825UMJdTEF G4m7pWbpzWfViHHLkeV3OvVhlNIfYW99Ro71M42hOILY7dz8Hs/JxgvAJUVpVRLp6HaN SRA6rl5UmU1kUuOu+Uo/C5M/GfF4qn0oIHHEgdwib2GahATC+l0ueuDlC2405cfuvecX e7F7gZfctQPGz/RwLr6b2CG9mvS91sIydtM0xg9Zeh/Xf3WM5g/Ev7KeT1B9qTOgKsRE 1SOiJSY/2de9jP+lF188mmJgtul3NjY36SUZ7H3R6TJgVD/ytuTnDjG+wIrycalJVbjj CU0Q== X-Gm-Message-State: ABuFfojaoZ0vofva6k5N7W3NSlivFALek/tmL0NyR9B12TOduEsCeKvW GD6X6FScCDft69I87HsGE0GLqpaU+1w= X-Google-Smtp-Source: ACcGV63Jw5/4sE7KzrH+BUg7fcSGAoYx2G4jc8ZcCLVXuiqE8NeDG85rOrPbj3w53Ddv52D6hLZahw== X-Received: by 2002:a9f:3048:: with SMTP id i8mr9887119uab.9.1539733413940; Tue, 16 Oct 2018 16:43:33 -0700 (PDT) Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com. [209.85.222.43]) by smtp.gmail.com with ESMTPSA id a2sm2441398uao.8.2018.10.16.16.43.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Oct 2018 16:43:32 -0700 (PDT) Received: by mail-ua1-f43.google.com with SMTP id z8so4075669uap.13 for ; Tue, 16 Oct 2018 16:43:32 -0700 (PDT) X-Received: by 2002:ab0:7291:: with SMTP id w17mr10587021uao.115.1539733412269; Tue, 16 Oct 2018 16:43:32 -0700 (PDT) MIME-Version: 1.0 References: <20181013005504.46399-1-briannorris@chromium.org> In-Reply-To: <20181013005504.46399-1-briannorris@chromium.org> From: Doug Anderson Date: Tue, 16 Oct 2018 16:43:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] ath10k: snoc: remove 'wcn3990' from generic resource handling To: Brian Norris Cc: kvalo@qca.qualcomm.com, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Govind Singh , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi, On Fri, Oct 12, 2018 at 5:55 PM Brian Norris wrote: > > ath10k_wcn3990_clk_info and ath10k_wcn3990_vreg_info are not > WCN3990-specific structures. They hold generic data. So don't name them > with wcn3990 specifics. > > Signed-off-by: Brian Norris > --- > drivers/net/wireless/ath/ath10k/snoc.c | 34 +++++++++++++------------- > drivers/net/wireless/ath/ath10k/snoc.h | 8 +++--- > 2 files changed, 21 insertions(+), 21 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c > index 8d3d9bca410f..c6254db17dab 100644 > --- a/drivers/net/wireless/ath/ath10k/snoc.c > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > @@ -46,14 +46,14 @@ static char *const ce_name[] = { > "WLAN_CE_11", > }; > > -static struct ath10k_wcn3990_vreg_info vreg_cfg[] = { > +static struct ath10k_vreg_info vreg_cfg[] = { Ironically, you could sorta make the argument that this should be: static struct ath10k_vreg_info wcn3990_vreg_cfg AKA the "wcn3990" shouldn't be in the name of the structure (since all snoc devices can have the concept of an array of regulators) but wcn3990 could be in the name of the variable since it's possible that different snoc devices could have different arrays. However I'm OK w/ waiting to do that part until we actually see a different snoc device with a different array. Reviewed-by: Douglas Anderson From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ua1-x941.google.com ([2607:f8b0:4864:20::941]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gCZ06-0000CM-6j for ath10k@lists.infradead.org; Tue, 16 Oct 2018 23:43:47 +0000 Received: by mail-ua1-x941.google.com with SMTP id j13so4078123ual.0 for ; Tue, 16 Oct 2018 16:43:35 -0700 (PDT) Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com. [209.85.222.48]) by smtp.gmail.com with ESMTPSA id i10-v6sm4207754vke.41.2018.10.16.16.43.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Oct 2018 16:43:32 -0700 (PDT) Received: by mail-ua1-f48.google.com with SMTP id m18so4074863uaq.2 for ; Tue, 16 Oct 2018 16:43:32 -0700 (PDT) MIME-Version: 1.0 References: <20181013005504.46399-1-briannorris@chromium.org> In-Reply-To: <20181013005504.46399-1-briannorris@chromium.org> From: Doug Anderson Date: Tue, 16 Oct 2018 16:43:17 -0700 Message-ID: Subject: Re: [PATCH 1/4] ath10k: snoc: remove 'wcn3990' from generic resource handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Brian Norris Cc: kvalo@qca.qualcomm.com, Govind Singh , linux-wireless@vger.kernel.org, LKML , ath10k@lists.infradead.org Hi, On Fri, Oct 12, 2018 at 5:55 PM Brian Norris wrote: > > ath10k_wcn3990_clk_info and ath10k_wcn3990_vreg_info are not > WCN3990-specific structures. They hold generic data. So don't name them > with wcn3990 specifics. > > Signed-off-by: Brian Norris > --- > drivers/net/wireless/ath/ath10k/snoc.c | 34 +++++++++++++------------- > drivers/net/wireless/ath/ath10k/snoc.h | 8 +++--- > 2 files changed, 21 insertions(+), 21 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c > index 8d3d9bca410f..c6254db17dab 100644 > --- a/drivers/net/wireless/ath/ath10k/snoc.c > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > @@ -46,14 +46,14 @@ static char *const ce_name[] = { > "WLAN_CE_11", > }; > > -static struct ath10k_wcn3990_vreg_info vreg_cfg[] = { > +static struct ath10k_vreg_info vreg_cfg[] = { Ironically, you could sorta make the argument that this should be: static struct ath10k_vreg_info wcn3990_vreg_cfg AKA the "wcn3990" shouldn't be in the name of the structure (since all snoc devices can have the concept of an array of regulators) but wcn3990 could be in the name of the variable since it's possible that different snoc devices could have different arrays. However I'm OK w/ waiting to do that part until we actually see a different snoc device with a different array. Reviewed-by: Douglas Anderson _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k