From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F6EC433FE for ; Fri, 20 May 2022 00:21:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233287AbiETAUv (ORCPT ); Thu, 19 May 2022 20:20:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343944AbiETAUu (ORCPT ); Thu, 19 May 2022 20:20:50 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77AD1CE24 for ; Thu, 19 May 2022 17:20:47 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id fd25so8877839edb.3 for ; Thu, 19 May 2022 17:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q2SsP49FcCChtmjGtwbSaTMmlIgf4FKqMdxkNXcLZxo=; b=HXRvwBSe1kdLw+E5XZQUg1aqD+Xzx1EPDD38vER8o23tEByEWKBd7UsuCsmlQjS2IA UrFRDsWb1JfLL64GhKqULVkddtRl8NXbTC9LPYW7SISZVG8H9KSTco/tZyI1GcTczIEC gnDMhQk9vYaGXJfrN3vT+O6EmsVeRrRGlccwc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q2SsP49FcCChtmjGtwbSaTMmlIgf4FKqMdxkNXcLZxo=; b=vvKgrdM24ewrTNVPNRQYTSsjD2HLNAlVoKmYtWOtZROoz01iJuckIJxAD2z42aZDSU kfRrLqzu5UXOYa1J2rTIMT4lHUHVdXup/2fogVEEwQwqGdQhicS960JkzyelweHb+smH wWmcHDqbGfjQIKkuHsf/O0YUXzUpkNp1Pkwv9S4IxhSbKMSOiyRdb7uM656BvhSe34vK Prnj28RopT5MSgAPKd2d0ziIvzGF0O6dVeJPoBXkkMd+cNc8SDwIRsiP3I4bvX+SWTvy 8UEA/FH6N23DkvAfAHrQs6EJYmQBmCptDat0rGAIIlgnLyhJIBBPtABFgg63ZtNOm8nX r4ZA== X-Gm-Message-State: AOAM530JfgN78QV7lo+/Sh2oEh7B8Sbma+h+91EFk8L2GSuWgOoQ2D5p E9d6jmzuasCGJlQzqGsg3SLVU/y53bzS4k6wLFI= X-Google-Smtp-Source: ABdhPJxy1erGW9Wkn+ut0rYp7/MngvZZW4uFd8Rp8WvpJcTYlvWRLI1+71ljszokXRxqxhH7ejMpJQ== X-Received: by 2002:a05:6402:2805:b0:42a:ea9b:e6a0 with SMTP id h5-20020a056402280500b0042aea9be6a0mr8101152ede.102.1653006045685; Thu, 19 May 2022 17:20:45 -0700 (PDT) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com. [209.85.221.41]) by smtp.gmail.com with ESMTPSA id y28-20020a170906519c00b006fa981fcd78sm2651024ejk.93.2022.05.19.17.20.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 17:20:44 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id j25so9359928wrc.9 for ; Thu, 19 May 2022 17:20:44 -0700 (PDT) X-Received: by 2002:a5d:6d09:0:b0:20c:53a9:cc30 with SMTP id e9-20020a5d6d09000000b0020c53a9cc30mr5985688wrq.513.1653006043655; Thu, 19 May 2022 17:20:43 -0700 (PDT) MIME-Version: 1.0 References: <20220511155749.v3.1.I2dd93486c6952bd52f2020904de0133970d11b29@changeid> In-Reply-To: <20220511155749.v3.1.I2dd93486c6952bd52f2020904de0133970d11b29@changeid> From: Doug Anderson Date: Thu, 19 May 2022 17:20:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes() To: dri-devel Cc: freedreno , Stephen Boyd , "Kuogee Hsieh (QUIC)" , Sankeerth Billakanti , "Abhinav Kumar (QUIC)" , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , "Aravind Venkateswaran (QUIC)" , Thomas Zimmermann , Dmitry Baryshkov , Rob Clark , linux-arm-msm , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Wed, May 11, 2022 at 3:58 PM Douglas Anderson wrote: > > The drm_helper_probe_single_connector_modes() is a bit long. Let's > break a chunk off to update and validate modes. This helps avoid one > goto and also will allow us to more easily call the helper a second > time in a future patch without adding looping or another goto. > > This change is intended to be a no-op change--just code movement. > > Signed-off-by: Douglas Anderson > Reviewed-by: Abhinav Kumar > Reviewed-by: Thomas Zimmermann > --- > > Changes in v3: > - Removed WARN_ON > > Changes in v2: > - Two underscores for __drm_helper_update_and_validate(). > - Return err and use WARN_ON instead of returning a bool. > > drivers/gpu/drm/drm_probe_helper.c | 106 ++++++++++++++++------------- > 1 file changed, 60 insertions(+), 46 deletions(-) Pushed to drm-misc-next: 4a2a13a57b60 drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes() From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AF4AC433EF for ; Fri, 20 May 2022 00:20:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5A9C10E3FA; Fri, 20 May 2022 00:20:49 +0000 (UTC) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDAF410E3FB for ; Fri, 20 May 2022 00:20:47 +0000 (UTC) Received: by mail-ej1-x632.google.com with SMTP id wh22so12637408ejb.7 for ; Thu, 19 May 2022 17:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q2SsP49FcCChtmjGtwbSaTMmlIgf4FKqMdxkNXcLZxo=; b=HXRvwBSe1kdLw+E5XZQUg1aqD+Xzx1EPDD38vER8o23tEByEWKBd7UsuCsmlQjS2IA UrFRDsWb1JfLL64GhKqULVkddtRl8NXbTC9LPYW7SISZVG8H9KSTco/tZyI1GcTczIEC gnDMhQk9vYaGXJfrN3vT+O6EmsVeRrRGlccwc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q2SsP49FcCChtmjGtwbSaTMmlIgf4FKqMdxkNXcLZxo=; b=rKQIo3eukZIHAOb0MB8yDGLNaHWzy6QTCexkiwaS7MZqd9qvVSm4PT7wx+vYFDS6we 00IDQN4lqjTjma7WCVK7fPTedCe4WD9MReERi/++twQ413NSnH7CJk/Iauiml7CLQcG7 sxZmWPY3Cp5tyu7IJmO/ht2zyH7SSCZTRy3sErU17Ht196MVzlKiLkf9Zfw6UrJd5RCg 6ZPYcwKpRlaQkShf8F/otV3u7a1Usr1/MPBpRXXbnB9x9tJsH5jeFEfR5L+SRcNEoxlB RhIM6ZUs4ALo04bLcrQXxo4QxH3+1Vb6mCiPOFJ+gJGhPuhyEkKXfXDkdif/XVX490H+ PE/w== X-Gm-Message-State: AOAM530PPd6TjwIjsxzaNchTQFy8LUVNLzBtXu9fOkBsTGydKHn80McI 3duAnSu6NRiWTUfSBZAyjC3N2glXVkl2cufGeAI= X-Google-Smtp-Source: ABdhPJyqcIpn6QJQT5KjrINV2u/ClpFvtGlc/3/m6J8u4YRgli0/S3wV4VmhSXwyXVgzOnqRSG6GOQ== X-Received: by 2002:a17:906:58d0:b0:6fe:ae38:1aca with SMTP id e16-20020a17090658d000b006feae381acamr486927ejs.109.1653006046250; Thu, 19 May 2022 17:20:46 -0700 (PDT) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com. [209.85.221.50]) by smtp.gmail.com with ESMTPSA id p25-20020aa7c4d9000000b004278942f86asm3507978edr.7.2022.05.19.17.20.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 17:20:45 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id t6so9387387wra.4 for ; Thu, 19 May 2022 17:20:44 -0700 (PDT) X-Received: by 2002:a5d:6d09:0:b0:20c:53a9:cc30 with SMTP id e9-20020a5d6d09000000b0020c53a9cc30mr5985688wrq.513.1653006043655; Thu, 19 May 2022 17:20:43 -0700 (PDT) MIME-Version: 1.0 References: <20220511155749.v3.1.I2dd93486c6952bd52f2020904de0133970d11b29@changeid> In-Reply-To: <20220511155749.v3.1.I2dd93486c6952bd52f2020904de0133970d11b29@changeid> From: Doug Anderson Date: Thu, 19 May 2022 17:20:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes() To: dri-devel Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sankeerth Billakanti , LKML , David Airlie , linux-arm-msm , "Abhinav Kumar \(QUIC\)" , "Kuogee Hsieh \(QUIC\)" , Thomas Zimmermann , Dmitry Baryshkov , "Aravind Venkateswaran \(QUIC\)" , Stephen Boyd , freedreno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Wed, May 11, 2022 at 3:58 PM Douglas Anderson wrote: > > The drm_helper_probe_single_connector_modes() is a bit long. Let's > break a chunk off to update and validate modes. This helps avoid one > goto and also will allow us to more easily call the helper a second > time in a future patch without adding looping or another goto. > > This change is intended to be a no-op change--just code movement. > > Signed-off-by: Douglas Anderson > Reviewed-by: Abhinav Kumar > Reviewed-by: Thomas Zimmermann > --- > > Changes in v3: > - Removed WARN_ON > > Changes in v2: > - Two underscores for __drm_helper_update_and_validate(). > - Return err and use WARN_ON instead of returning a bool. > > drivers/gpu/drm/drm_probe_helper.c | 106 ++++++++++++++++------------- > 1 file changed, 60 insertions(+), 46 deletions(-) Pushed to drm-misc-next: 4a2a13a57b60 drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes()