From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 113A1C433F5 for ; Wed, 8 Sep 2021 15:10:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8E5E611C6 for ; Wed, 8 Sep 2021 15:10:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349510AbhIHPLH (ORCPT ); Wed, 8 Sep 2021 11:11:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbhIHPLG (ORCPT ); Wed, 8 Sep 2021 11:11:06 -0400 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E79DC061575 for ; Wed, 8 Sep 2021 08:09:58 -0700 (PDT) Received: by mail-il1-x136.google.com with SMTP id s16so2657478ilo.9 for ; Wed, 08 Sep 2021 08:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yRPp5IHtHZbh2VaC3A/pPLLamUQg+uMH0n8xJchofN8=; b=I2IrUovC0NAik8gQxEeKQbBh/+E3r1Ftc2iriNrtCYRmaOT/WfeH2y3O4YSWdUy8sq 6jAWU0V6WXZyy9beh89xVm0hzWeWloejNkfBnlYCfYncR05Lt/w1j02hKERMBtQ0dJe9 1rPWIKVprNObr/nlryClStiA51vf+aQWK6+as= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yRPp5IHtHZbh2VaC3A/pPLLamUQg+uMH0n8xJchofN8=; b=3ou3JE8QfB0g7jc8IYwSgVtmEvzhBWe3gMXaWUvlDCDuPtU0k//6zRom6qQKOMdS6K 5vEBrT6XMJ5LvnsasATcpuPn0yWnnPOXBsJA3DQzzkv3P5xu82KXL8NAMwijeLV881LO tPj3EmlaqjzSAK4Om2mbKKgLQImUFeRGEvDLxW4BFuSGTT4Z8AFjk8nchhgBqQeWGY6s 22Ksv+W6JI70Y8o3vSIEPZVo/3jav+Mb9j0OJbqbA30QwpRCmgroJUo9zJandGESl3VZ PUfAlj9E2pTcb18fKfHi6H9OZBaik7Hv/HviUsGz3kFCLzhOkUHNBv/VVYTIJTlNxHW8 VWgg== X-Gm-Message-State: AOAM531CtefVPEchR12j5imFYKO2w5/lzVtU+zYjTC7SUZfI52fzIrZQ DGLolN8pb/lRyUl2/z/tqhG6d1sFMGFQwQ== X-Google-Smtp-Source: ABdhPJzSzWLKmrpgL1ZaJGmUobiBa/Cg1G8P5jh5ygZuAB3hLkbcdcUKZy+IHFi0iovh+wKszKP28A== X-Received: by 2002:a92:cda4:: with SMTP id g4mr262464ild.236.1631113797651; Wed, 08 Sep 2021 08:09:57 -0700 (PDT) Received: from mail-il1-f173.google.com (mail-il1-f173.google.com. [209.85.166.173]) by smtp.gmail.com with ESMTPSA id o2sm1272854ilg.47.2021.09.08.08.09.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 08:09:57 -0700 (PDT) Received: by mail-il1-f173.google.com with SMTP id x10so2646994ilm.12 for ; Wed, 08 Sep 2021 08:09:56 -0700 (PDT) X-Received: by 2002:a92:cb52:: with SMTP id f18mr274812ilq.120.1631113795742; Wed, 08 Sep 2021 08:09:55 -0700 (PDT) MIME-Version: 1.0 References: <20210907094628.RESEND.1.If29cd838efbcee4450a62b8d84a99b23c86e0a3f@changeid> <20210907094628.RESEND.2.Ibc87b4785709543c998cc852c1edaeb7a08edf5c@changeid> In-Reply-To: <20210907094628.RESEND.2.Ibc87b4785709543c998cc852c1edaeb7a08edf5c@changeid> From: Doug Anderson Date: Wed, 8 Sep 2021 08:09:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RESEND PATCH 2/2] arm64: dts: rockchip: add Coresight debug range for RK3399 To: Brian Norris Cc: Heiko Stuebner , Michael Turquette , Stephen Boyd , linux-clk , Chen-Yu Tsai , LKML , "open list:ARM/Rockchip SoC..." , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Sep 7, 2021 at 9:46 AM Brian Norris wrote: > > Per Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt. > > This IP block can be used for sampling the PC of any given CPU, which is > useful in certain panic scenarios where you can't get the CPU to stop > cleanly (e.g., hard lockup). > > Signed-off-by: Brian Norris > --- > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 48 ++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 3871c7fd83b0..c8c62637b600 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -433,6 +433,54 @@ usbdrd_dwc3_1: usb@fe900000 { > }; > }; > > + debug@fe430000 { I think your sort order is wrong? 0xfe430000 comes before 0xfe900000? Other than that this looks good to me. Reviewed-by: Douglas Anderson From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AADF0C433EF for ; Wed, 8 Sep 2021 15:10:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 632BA611C7 for ; Wed, 8 Sep 2021 15:10:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 632BA611C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CJbuw49fDvhQkJh6BtW8BGcPpQ3l5igggN/yTPMgWrs=; b=2R7e+/hmtkzP15 MkGT431qoZE/o50qn+8jeEC29U8MtDaavqBol5laLju6IgDB4HFdEJw833Nt75NpduaXYf1yF3Hjo RGZ9nrUiraT+ymejhqXnTCtaxXkGXc7UeyCBzF9SYveG/Sh9U/+8MzxTSCX8JT4DMb7XxH6ycGyxu dqDSGdNVirbf1wMMuRVpZhq2SHJiUVv5EuAm3iZHffTBLX5hob2DZEGKNubXCOPXdDFgRsJ5FQ7IP iUDvb6NwmiQh99brFkH5SYUo7tEgOprskGGEwMJrc1MHWO5J1oZU+j5L+bKZnmfoKTFwkgwsUWyJf hIlyJaLpyzx2YyuHJtGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNzDH-0071TW-TR; Wed, 08 Sep 2021 15:10:11 +0000 Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNzD5-0071S6-Ft for linux-rockchip@lists.infradead.org; Wed, 08 Sep 2021 15:10:00 +0000 Received: by mail-io1-xd36.google.com with SMTP id g9so3662136ioq.11 for ; Wed, 08 Sep 2021 08:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yRPp5IHtHZbh2VaC3A/pPLLamUQg+uMH0n8xJchofN8=; b=I2IrUovC0NAik8gQxEeKQbBh/+E3r1Ftc2iriNrtCYRmaOT/WfeH2y3O4YSWdUy8sq 6jAWU0V6WXZyy9beh89xVm0hzWeWloejNkfBnlYCfYncR05Lt/w1j02hKERMBtQ0dJe9 1rPWIKVprNObr/nlryClStiA51vf+aQWK6+as= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yRPp5IHtHZbh2VaC3A/pPLLamUQg+uMH0n8xJchofN8=; b=68u6n4H5XmKwc4aaNG/R9tA7Nv4vvSGtbmApTCItstxrVg8YvcIFMCtK+/U2HjHW3D c/czSI+VWLtKL9qq/mZyPJef5JxmaM/7ySzf4xWU6z2XNJ+SwKxoP1sSg89I0Ag4zUV0 lM+dvfmssI+VvPXhmmeseXDX/8m4KvmnzdWiR51hUtj0ZSF7ijNIYI6vbWjEuQz8I+X7 16VVtBcIRael5BZIyfeoPYseaFW2Pl4bmcxoHoNRbRvW2u3QmjtTlDx7nvO48IEW1Tzh PFNVA2JyzolZV9/DxbHgTknZORXR71bA4F8yOZcmcuk8jhQ2p/RGQTEk6zC33cBVYNd1 X64Q== X-Gm-Message-State: AOAM531v/eByAVOmkgGl65a/XhZa8bACiuPjA29OzSpSijQLO9qbiafs ECXLBWdQzs7lWaEIqvmTlEuEZO9RH8AuoQ== X-Google-Smtp-Source: ABdhPJywP4DfNGSg1x4Zc49K7K0F83xsye+R+TKAv1GfIH37OSk8VT1+G2brm26IjmDVlwfV+8N0Bw== X-Received: by 2002:a05:6638:59:: with SMTP id a25mr4158343jap.111.1631113797306; Wed, 08 Sep 2021 08:09:57 -0700 (PDT) Received: from mail-il1-f169.google.com (mail-il1-f169.google.com. [209.85.166.169]) by smtp.gmail.com with ESMTPSA id e13sm1279982iod.36.2021.09.08.08.09.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 08:09:56 -0700 (PDT) Received: by mail-il1-f169.google.com with SMTP id b4so2646554ilr.11 for ; Wed, 08 Sep 2021 08:09:56 -0700 (PDT) X-Received: by 2002:a92:cb52:: with SMTP id f18mr274812ilq.120.1631113795742; Wed, 08 Sep 2021 08:09:55 -0700 (PDT) MIME-Version: 1.0 References: <20210907094628.RESEND.1.If29cd838efbcee4450a62b8d84a99b23c86e0a3f@changeid> <20210907094628.RESEND.2.Ibc87b4785709543c998cc852c1edaeb7a08edf5c@changeid> In-Reply-To: <20210907094628.RESEND.2.Ibc87b4785709543c998cc852c1edaeb7a08edf5c@changeid> From: Doug Anderson Date: Wed, 8 Sep 2021 08:09:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RESEND PATCH 2/2] arm64: dts: rockchip: add Coresight debug range for RK3399 To: Brian Norris Cc: Heiko Stuebner , Michael Turquette , Stephen Boyd , linux-clk , Chen-Yu Tsai , LKML , "open list:ARM/Rockchip SoC..." , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_080959_558096_D6AB9D4B X-CRM114-Status: GOOD ( 15.80 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi, On Tue, Sep 7, 2021 at 9:46 AM Brian Norris wrote: > > Per Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt. > > This IP block can be used for sampling the PC of any given CPU, which is > useful in certain panic scenarios where you can't get the CPU to stop > cleanly (e.g., hard lockup). > > Signed-off-by: Brian Norris > --- > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 48 ++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 3871c7fd83b0..c8c62637b600 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -433,6 +433,54 @@ usbdrd_dwc3_1: usb@fe900000 { > }; > }; > > + debug@fe430000 { I think your sort order is wrong? 0xfe430000 comes before 0xfe900000? Other than that this looks good to me. Reviewed-by: Douglas Anderson _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD91C433EF for ; Wed, 8 Sep 2021 15:12:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83F0B60F5B for ; Wed, 8 Sep 2021 15:12:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 83F0B60F5B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=guQ6NVvNAeJBjJ+4NXpq7ajVGE8/3KvxuDRgx/oMBy0=; b=nbacfhxih+rP/j oAZSAC8gnzxzHSl5MM+KkFxw9KrYs+v0N3mnmwhQj0JYyArZvGF6EechAe5UEbZjoYEcoRm0o08l5 xCP8KDAYxBG+j5xEdUczuTDeg/ADqOOxcVCteBSIGduFYkS6h3E0fioQfX2NFOTTSU3Emm/cSMTP6 IyvWl8775GhtRUsnOy29BoyTYzj/k1ZsemCcxM0EkP+MixiUdOQTUTilHgoZfivuZbxN181u41Pju kIb8oJ0bXAB6IIDCj8VuuRs88BzboDAOCX6I4FMvLYx+P9YsA4bKO1A+9B4J52dh6Zx0HJqNE8Ldv ovAM+Eo12xKKOvTVvZYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNzD8-0071T5-L9; Wed, 08 Sep 2021 15:10:02 +0000 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNzD5-0071S7-3u for linux-arm-kernel@lists.infradead.org; Wed, 08 Sep 2021 15:10:00 +0000 Received: by mail-il1-x133.google.com with SMTP id l10so2657930ilh.8 for ; Wed, 08 Sep 2021 08:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yRPp5IHtHZbh2VaC3A/pPLLamUQg+uMH0n8xJchofN8=; b=I2IrUovC0NAik8gQxEeKQbBh/+E3r1Ftc2iriNrtCYRmaOT/WfeH2y3O4YSWdUy8sq 6jAWU0V6WXZyy9beh89xVm0hzWeWloejNkfBnlYCfYncR05Lt/w1j02hKERMBtQ0dJe9 1rPWIKVprNObr/nlryClStiA51vf+aQWK6+as= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yRPp5IHtHZbh2VaC3A/pPLLamUQg+uMH0n8xJchofN8=; b=LBrl0vMguVloqiCEFmMUUjeKQiQh92alCuDsy+UnMtcWoWNgK5MkYYoget7SmOmvrU EzHznrDWNBlwD3qZZhzkmsCyy+vepJBf86q2pKzcmH8s5mDC1jiOfDpd4LvvgXVi5wkR GBC0dkCOTYYmIv0RNBwkjicIZIdH+Pj5os/TvhYsjZbuRca+ACTJMiiczzrp+Ybq9Bsh +dDsWVEENE9rBgTG3DWphe2T8ziaFi1h6LpjhtghvQGWTaKYkEhKJNFDaxoPpgx0fSZx GeDi1Vd0dtpgG043XjA4Ce7PArBrJj16bOSYo+x21T/IGsUVYdFZEIpNIHf5pNF+nsfp YqUA== X-Gm-Message-State: AOAM530f8dguGIUBy5wogmlhDxKbLvVKdy22BzY17pGkoaszVzi+EsFY 7BLhr97+bwyOExqBQr3SXS0Ci4AiUivIWw== X-Google-Smtp-Source: ABdhPJwb7NY+4OPkyYfYMwqnk9zPO8dgJpEacFdj7A0p2j1SLyXDDpZ2Td5DuD7fBLXk7Lug+ZPZKA== X-Received: by 2002:a92:3012:: with SMTP id x18mr231389ile.249.1631113797998; Wed, 08 Sep 2021 08:09:57 -0700 (PDT) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com. [209.85.166.172]) by smtp.gmail.com with ESMTPSA id s5sm1208099ilq.59.2021.09.08.08.09.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 08:09:57 -0700 (PDT) Received: by mail-il1-f172.google.com with SMTP id u11so2674462ilj.5 for ; Wed, 08 Sep 2021 08:09:56 -0700 (PDT) X-Received: by 2002:a92:cb52:: with SMTP id f18mr274812ilq.120.1631113795742; Wed, 08 Sep 2021 08:09:55 -0700 (PDT) MIME-Version: 1.0 References: <20210907094628.RESEND.1.If29cd838efbcee4450a62b8d84a99b23c86e0a3f@changeid> <20210907094628.RESEND.2.Ibc87b4785709543c998cc852c1edaeb7a08edf5c@changeid> In-Reply-To: <20210907094628.RESEND.2.Ibc87b4785709543c998cc852c1edaeb7a08edf5c@changeid> From: Doug Anderson Date: Wed, 8 Sep 2021 08:09:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RESEND PATCH 2/2] arm64: dts: rockchip: add Coresight debug range for RK3399 To: Brian Norris Cc: Heiko Stuebner , Michael Turquette , Stephen Boyd , linux-clk , Chen-Yu Tsai , LKML , "open list:ARM/Rockchip SoC..." , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_080959_223037_872E1AC2 X-CRM114-Status: GOOD ( 17.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Sep 7, 2021 at 9:46 AM Brian Norris wrote: > > Per Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt. > > This IP block can be used for sampling the PC of any given CPU, which is > useful in certain panic scenarios where you can't get the CPU to stop > cleanly (e.g., hard lockup). > > Signed-off-by: Brian Norris > --- > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 48 ++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 3871c7fd83b0..c8c62637b600 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -433,6 +433,54 @@ usbdrd_dwc3_1: usb@fe900000 { > }; > }; > > + debug@fe430000 { I think your sort order is wrong? 0xfe430000 comes before 0xfe900000? Other than that this looks good to me. Reviewed-by: Douglas Anderson _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel